Skip to content

Change some matches!(.., .. if ..) with let-chains - #150406

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:matches-let-chain
Jan 14, 2026
Merged

Change some matches!(.., .. if ..) with let-chains#150406
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:matches-let-chain

Conversation

@estebank

@estebankestebank commented Dec 26, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Follow up to #149933.

@rustbot

rustbot commented Dec 26, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in check-cfg diagnostics

cc @Urgau

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2025
@rustbot

rustbot commented Dec 26, 2025

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@estebank

estebank commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

As per #149933 (comment)

Kivooeo
Kivooeo approved these changes Dec 26, 2025
View reviewed changes

@KivooeoKivooeo left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as well,

r? me

View changes since this review

@rustbotrustbot assigned Kivooeo and unassigned davidtwcoDec 26, 2025
fmease
fmease reviewed Dec 26, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/src/early/diagnostics/check_cfg.rs Outdated
BoxyUwU
BoxyUwU reviewed Dec 26, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/src/transmute.rs
@Kivooeo

Kivooeo commented Dec 27, 2025•
edited
Loading

Copy link
Copy Markdown
Member

r=me and Oli and Boxy and fmease :)

with nit from @fmease

@estebank
estebankforce-pushed the matches-let-chain branch 2 times, most recently from 0a59e89 to 132837aCompareJanuary 2, 2026 20:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@estebank

estebank commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

@bors r=Kivooeo,oli-obk,BoxyUwU,fmease

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026
@rust-bors

rust-borsBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 814647f has been approved by Kivooeo,oli-obk,BoxyUwU,fmease

It is now in the queue for this repository.

@samueltardieusamueltardieu mentioned this pull request Jan 13, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 14, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#150406- matches-let-chain, r=Kivooeo,oli-o…
84e4804
…bk,BoxyUwU,fmease
Change some `matches!(.., .. if ..)` with let-chains
Follow up to rust-lang#149933.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 14, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of#151104- JonathanBrouwer:rollup-5gICySg, r=JonathanBro…
a8e0083
…uwer
Rollup of 12 pull requests
Successful merges:
- #149408 (refactor: remove Ord bound from BinaryHeap::new etc)
- #150406 (Change some `matches!(.., .. if ..)` with let-chains)
- #150723 (std: move `errno` and related functions into `sys::io`)
- #150877 (resolve: Refactor away the side table `decl_parent_modules`)
- #150902 (Update to_uppercase docs to avoid ß->SS example)
- #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
- #151034 (std: Change UEFI env vars to volatile storage)
- #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
- #151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
- #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
- #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
- #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)
Failed merges:
- #150939 (resolve: Relax some asserts in glob overwriting and add tests)
r? @ghost
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 14, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of#151107- JonathanBrouwer:rollup-9CIxxuZ, r=JonathanBro…
8c52f73
…uwer
Rollup of 11 pull requests
Successful merges:
- #149408 (refactor: remove Ord bound from BinaryHeap::new etc)
- #150406 (Change some `matches!(.., .. if ..)` with let-chains)
- #150723 (std: move `errno` and related functions into `sys::io`)
- #150877 (resolve: Refactor away the side table `decl_parent_modules`)
- #150902 (Update to_uppercase docs to avoid ß->SS example)
- #151034 (std: Change UEFI env vars to volatile storage)
- #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
- #151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
- #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
- #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
- #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)
Failed merges:
- #150939 (resolve: Relax some asserts in glob overwriting and add tests)
r? @ghost
@rust-bors
rust-borsBot merged commit 4e4bee8 into rust-lang:mainJan 14, 2026
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 14, 2026
rust-timer added a commit that referenced this pull request Jan 14, 2026
@rust-timer
Unrolled build for#150406
94f4304
Rollup merge of #150406 - matches-let-chain, r=Kivooeo,oli-obk,BoxyUwU,fmease
Change some `matches!(.., .. if ..)` with let-chains
Follow up to #149933.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jan 15, 2026
@bors
Auto merge of #151107 - JonathanBrouwer:rollup-9CIxxuZ, r=JonathanBro…
a1c2d8f
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#149408 (refactor: remove Ord bound from BinaryHeap::new etc)
- rust-lang/rust#150406 (Change some `matches!(.., .. if ..)` with let-chains)
- rust-lang/rust#150723 (std: move `errno` and related functions into `sys::io`)
- rust-lang/rust#150877 (resolve: Refactor away the side table `decl_parent_modules`)
- rust-lang/rust#150902 (Update to_uppercase docs to avoid ß->SS example)
- rust-lang/rust#151034 (std: Change UEFI env vars to volatile storage)
- rust-lang/rust#151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
- rust-lang/rust#151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
- rust-lang/rust#151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
- rust-lang/rust#151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
- rust-lang/rust#151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)
Failed merges:
- rust-lang/rust#150939 (resolve: Relax some asserts in glob overwriting and add tests)
r? @ghost
@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeasefmeasefmease left review comments
@BoxyUwUBoxyUwUBoxyUwU left review comments
@oli-obkoli-obkoli-obk approved these changes
@KivooeoKivooeoKivooeo approved these changes

Assignees

@KivooeoKivooeo

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

8 participants

@estebank@rustbot@Kivooeo@rust-log-analyzer@oli-obk@fmease@BoxyUwU@davidtwco