Skip to content

do not suggest method call removal if it changes receiver type - #150441

Merged
bors merged 2 commits into
rust-lang:mainfrom
fee1-dead-contrib:push-smqzpwrpvqll
Jan 3, 2026
Merged

do not suggest method call removal if it changes receiver type#150441
bors merged 2 commits into
rust-lang:mainfrom
fee1-dead-contrib:push-smqzpwrpvqll

Conversation

@fee1-dead

@fee1-deadfee1-dead commented Dec 27, 2025

Copy link
Copy Markdown
Member

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@JonathanBrouwer

Copy link
Copy Markdown
Member

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@rust-log-analyzer

This comment has been minimized.

@JonathanBrouwer

Copy link
Copy Markdown
Member

Not comfortable enough with this part of the codebase to review, rerolling
r? compiler

@rustbotrustbot assigned lcnr and unassigned JonathanBrouwerDec 29, 2025
@fee1-deadfee1-dead added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2025
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 998a0df has been approved by estebank

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
bors added a commit that referenced this pull request Jan 2, 2026
…uwer
Rollup of 4 pull requests
Successful merges:
- #149991 (Add checks for gpu-kernel calling conv)
- #150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
- #150441 (do not suggest method call removal if it changes receiver type)
- #150616 (Update `browser-ui-test` version to `0.23.0`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ce43d6c into rust-lang:mainJan 3, 2026
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 3, 2026
rust-timer added a commit that referenced this pull request Jan 3, 2026
Rollup merge of #150441 - fee1-dead-contrib:push-smqzpwrpvqll, r=estebank
do not suggest method call removal if it changes receiver type
Fixes#149487, cc `@estebank`
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jan 3, 2026
…uwer
Rollup of 4 pull requests
Successful merges:
- rust-lang/rust#149991 (Add checks for gpu-kernel calling conv)
- rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
- rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type)
- rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 12, 2026
…uwer
Rollup of 4 pull requests
Successful merges:
- rust-lang/rust#149991 (Add checks for gpu-kernel calling conv)
- rust-lang/rust#150047 (std: merge `sys::pal::common` and `sys_common` into `sys::helpers`)
- rust-lang/rust#150441 (do not suggest method call removal if it changes receiver type)
- rust-lang/rust#150616 (Update `browser-ui-test` version to `0.23.0`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diagnostic for .unwrap_or_default() suggests removing unrelated code

7 participants

@fee1-dead@rustbot@rust-log-analyzer@JonathanBrouwer@estebank@bors@lcnr