Uh oh!
There was an error while loading. Please reload this page.
Replace -Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe] - #150591
Draft
Enselic wants to merge 1 commit into
Draft
Replace -Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe]#150591Enselic wants to merge 1 commit into
-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe]#150591Enselic wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Enselicforce-pushed
the
add-on_broken_pipe
branch
2 times, most recently
from
January 5, 2026 21:46
5825fb6 to
7b52018Compare#![feature(on_broken_pipe)] code-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe() -> std::io::OnBrokenPipe-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe() -> std::io::OnBrokenPipe-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe]
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Jan 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 6, 2026
Kobzol added a commit
to Kobzol/rust
that referenced
this pull request
Jan 7, 2026
rustc book: fix grammar It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test. Tracking issue: - rust-lang#150588
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2026
tests/ui/runtime/on-broken-pipe/with-rustc_main.rs: Not needed so remove It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test. Tracking issue: - rust-lang#150588
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2026
tests/ui/runtime/on-broken-pipe/with-rustc_main.rs: Not needed so remove It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test. Tracking issue: - rust-lang#150588
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2026
tests/ui/runtime/on-broken-pipe/with-rustc_main.rs: Not needed so remove It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test. Tracking issue: - rust-lang#150588
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2026
Fix `alloc_error_handler` signature mismatch It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test. Tracking issue: - rust-lang#150588
rust-timer added a commit
that referenced
this pull request
Jan 8, 2026
Rollup merge of #150757 - rm-unneded-test, r=bjorn3 Fix `alloc_error_handler` signature mismatch It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`: #[unix_sigpipe = "sig_dfl"] #[rustc_main] fn rustc_main() { The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see #150591). Let's remove this test. Tracking issue: - #150588
Enselicforce-pushed
the
add-on_broken_pipe
branch
from
January 8, 2026 18:20
76f940b to
fc9e23bCompareEnselicforce-pushed
the
add-on_broken_pipe
branch
from
January 15, 2026 05:40
faa9930 to
c6bdfdeCompare
This comment has been minimized.
This comment has been minimized.
1 task
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Feb 3, 2026
…mic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang#150591 because of rust-lang#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang#151695
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Feb 3, 2026
…mic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang#150591 because of rust-lang#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang#151695
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Feb 3, 2026
…mic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang#150591 because of rust-lang#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang#151695
rust-timer added a commit
that referenced
this pull request
Feb 3, 2026
Rollup merge of #151691 - Enselic:dylib-only-for-prefer-dynamic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - #150591 because of #151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] #151695
github-actionsBot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Feb 3, 2026
…=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang/rust#150591 because of rust-lang/rust#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang/rust#151695
Enselicforce-pushed
the
add-on_broken_pipe
branch
from
February 3, 2026 20:35
c6bdfde to
6f8667dCompareEnselicforce-pushed
the
add-on_broken_pipe
branch
from
February 3, 2026 20:37
6f8667d to
5a96eb9Compare
This comment has been minimized.
This comment has been minimized.
Enselicforce-pushed
the
add-on_broken_pipe
branch
from
February 4, 2026 04:12
5a96eb9 to
065e343Compare
This comment has been minimized.
This comment has been minimized.
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 4, 2026
…=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang/rust#150591 because of rust-lang/rust#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang/rust#151695
Enselicforce-pushed
the
add-on_broken_pipe
branch
from
February 4, 2026 18:25
065e343 to
5524ab1Comparegithub-actionsBot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Feb 5, 2026
…=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang/rust#150591 because of rust-lang/rust#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang/rust#151695
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…, r=ChrisDenton library/std: Rename `ON_BROKEN_PIPE_FLAG_USED` to `ON_BROKEN_PIPE_USED` This commit is a pure internal rename and does not change any functionality. The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the compiler flag `-Zon-broken-pipe=...` is used to enable the feature. Remove the `FLAG_` part so the name works both for the current compiler flag `-Zon-broken-pipe=...` and for the upcoming [Externally Implementable Item `#[std::io::on_broken_pipe]`](rust-lang#150591) PR. This makes the diff of that PR smaller. The local variable name `sigpipe_attr_specified` comes from way back when the feature was controlled with an `fn main()` attribute called `#[unix_sigpipe = "..."]`. Rename that too.
rust-timer added a commit
that referenced
this pull request
Feb 5, 2026
Rollup merge of #152133 - Enselic:on-broken-pipe-flag-rename, r=ChrisDenton library/std: Rename `ON_BROKEN_PIPE_FLAG_USED` to `ON_BROKEN_PIPE_USED` This commit is a pure internal rename and does not change any functionality. The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the compiler flag `-Zon-broken-pipe=...` is used to enable the feature. Remove the `FLAG_` part so the name works both for the current compiler flag `-Zon-broken-pipe=...` and for the upcoming [Externally Implementable Item `#[std::io::on_broken_pipe]`](#150591) PR. This makes the diff of that PR smaller. The local variable name `sigpipe_attr_specified` comes from way back when the feature was controlled with an `fn main()` attribute called `#[unix_sigpipe = "..."]`. Rename that too.
This comment has been minimized.
This comment has been minimized.
Enselicforce-pushed
the
add-on_broken_pipe
branch
from
February 5, 2026 20:01
5524ab1 to
4bca7a1Compare
This comment has been minimized.
This comment has been minimized.
…std::io::on_broken_pipe]`
Contributor
☔ The latest upstream changes (presumably #157913) made this pull request unmergeable. Please resolve the merge conflicts. |
ghaaj pushed a commit
to ghaaj/polygrammar
that referenced
this pull request
Aug 7, 2026
…=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang/rust#150591 because of rust-lang/rust#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang/rust#151695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently (2026-05-18) Blocked On
We need to make
tests/run-make/broken-pipe-no-ice/rmake.rspass. I and others think we know what the problem is, but it is not easy to fix. TODO: File a detailed and separate issue (maybe).Previously Blocked On
error: undefined symbolwith dynamic linking #151271 because oftests/run-make/broken-pipe-no-ice/rmake.rs.Tracking Issues:
#[std::io::on_broken_pipe]#150588