Skip to content

vec in-place-drop: avoid creating an intermediate slice - #150643

Merged
bors merged 1 commit into
rust-lang:mainfrom
hkBst:cast-slice-from-raw-parts-1
Jan 4, 2026
Merged

vec in-place-drop: avoid creating an intermediate slice#150643
bors merged 1 commit into
rust-lang:mainfrom
hkBst:cast-slice-from-raw-parts-1

Conversation

@hkBst

@hkBsthkBst commented Jan 3, 2026

Copy link
Copy Markdown
Member

Avoids clippy warning:

warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [T]`
--> library/alloc/src/vec/in_place_drop.rs:25:32
|
25 | ptr::drop_in_place(slice::from_raw_parts_mut(self.inner, self.len()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `core::ptr::slice_from_raw_parts_mut(self.inner, self.len())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts
= note: `-W clippy::cast-slice-from-raw-parts` implied by `-W clippy::suspicious`
= help: to override `-W clippy::suspicious` add `#[allow(clippy::cast_slice_from_raw_parts)]`

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 3, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed the cast-slice-from-raw-parts-1 branch from 90cfcdf to 47798e2CompareJanuary 3, 2026 12:08
@tgross35

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 47798e2 has been approved by tgross35

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@ZalatharZalathar mentioned this pull request Jan 4, 2026
bors added a commit that referenced this pull request Jan 4, 2026
Rollup of 7 pull requests
Successful merges:
- #150201 (compiletest: Support revisions in debuginfo (read: debugger) tests)
- #150642 (mutex.rs: remove needless-maybe-unsized bounds)
- #150643 (vec in-place-drop: avoid creating an intermediate slice)
- #150650 (Forbid generic parameters in types of #[type_const] items)
- #150658 (Clarify panic conditions in `Iterator::last`)
- #150659 (Add missing translator resources for interface parse_cfg and parse_check_cfg)
- #150666 (Fix ambig-unambig-ty-and-consts link)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f63ab49 into rust-lang:mainJan 4, 2026
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
rust-timer added a commit that referenced this pull request Jan 4, 2026
Rollup merge of #150643 - hkBst:cast-slice-from-raw-parts-1, r=tgross35
vec in-place-drop: avoid creating an intermediate slice
Avoids clippy warning:
```text
warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [T]`
--> library/alloc/src/vec/in_place_drop.rs:25:32
|
25 | ptr::drop_in_place(slice::from_raw_parts_mut(self.inner, self.len()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `core::ptr::slice_from_raw_parts_mut(self.inner, self.len())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts
= note: `-W clippy::cast-slice-from-raw-parts` implied by `-W clippy::suspicious`
= help: to override `-W clippy::suspicious` add `#[allow(clippy::cast_slice_from_raw_parts)]`
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hkBst@rustbot@rust-log-analyzer@tgross35@bors