Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Rollup of 2 pull requests - #150655

Merged
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb
Jan 4, 2026
Merged

Rollup of 2 pull requests#150655
bors merged 5 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-8oshivb

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzyand others added 5 commits January 3, 2026 00:16
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
…-typo, r=nnethercote
Fix typo in pattern usefulness documentation
Line 171 introduced and as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.
Fixesrust-lang#149803
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e25ee6b into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150596Add tracking issue for sized_hierarchy7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651Fix typo in pattern usefulness documentation0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.8%[-2.8%, -2.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.8%[-2.8%, -2.8%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@bors@rust-timer@rustbot@reddevilmidzy@Sekar-C-Mca