MGCA: Support literals as direct const arguments - #150699

Merged

rust-bors[bot] merged 1 commit into

rust-lang:mainfrom

Human9000-bit:literals-as-direct-const-args

Jan 9, 2026

Human9000-bit commented Jan 5, 2026

Member

initial changes for mcga literals
rustfmt

rustbot assigned BoxyUwU

rustbot added S-waiting-on-author T-clippy T-compiler T-rustdoc labels

rustbot commented Jan 5, 2026

Collaborator

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

Human9000-bit commented Jan 5, 2026•
edited
Loading

MemberAuthor

rn this is very basic changes, lots of todo!() s
took me some time to figure out what to do

This comment has been minimized.

Sign in to view

BoxyUwU reviewed

View reviewed changes

BoxyUwU left a comment •
edited by rustbot
Loading

Member

This is looking good already! You've touched pretty much everywhere that will be necessary for this change so it's only filling out these todo!s now :)

View changes since this review

compiler/rustc_hir/src/hir.rs Outdated

compiler/rustc_ast_lowering/src/lib.rs Outdated

compiler/rustc_hir/src/intravisit.rs Outdated

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

compiler/rustc_hir_pretty/src/lib.rs Outdated

src/librustdoc/clean/mod.rs Outdated

src/librustdoc/clean/mod.rs Outdated

BoxyUwU mentioned this pull request

Tracking Issue for Generic Constant Arguments MVP #132980

Open

29 tasks

Human9000-bit marked this pull request as ready for review

January 6, 2026 11:35

rustbot added the S-waiting-on-review label

rustbot commented Jan 6, 2026

Collaborator

HIR ty lowering was modified

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot removed the S-waiting-on-author label

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits label

Human9000-bit commented Jan 6, 2026

MemberAuthor

too bad I have made a merge commit

This comment has been minimized.

Sign in to view

Human9000-bit force-pushed the literals-as-direct-const-args branch from acd1271 to 78149e6Compare

January 6, 2026 12:31

This comment has been minimized.

Sign in to view

rustbot removed the has-merge-commits label

Human9000-bit marked this pull request as draft

January 6, 2026 12:31

rustbot added S-waiting-on-author and removed S-waiting-on-review labels

Human9000-bit force-pushed the literals-as-direct-const-args branch 2 times, most recently from d60c5dd to 37f084aCompare

January 6, 2026 13:05

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

BoxyUwU reviewed

View reviewed changes

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

Human9000-bit commented Jan 8, 2026•
edited
Loading

MemberAuthor

😅 I've noticed i named it MCGA instead of MGCA

Human9000-bit force-pushed the literals-as-direct-const-args branch from 1d10a8f to 9f3956fCompare

January 8, 2026 15:29

camelid reviewed

View reviewed changes

compiler/rustc_hir/src/intravisit.rs

BoxyUwU commented Jan 8, 2026

Member

@bors r+ rollup

there's definitely follow up work here:

negated literals (important for isize const generics)
lit_to_const is very ICEy on wrong types and we should have proper diagnostics

so if you're interested in doing more work here that'd be very cool :)

rust-borsBot added S-waiting-on-bors and removed S-waiting-on-review labels

rust-borsBot commented Jan 8, 2026

Contributor

📌 Commit 9f3956f has been approved by BoxyUwU

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

bab3c6a

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 12 pull requests #150830

Closed

rust-borsBot added a commit that referenced this pull request

Auto merge of#150830- matthiaskrgr:rollup-x97BiJe, r=matthiaskrgr

c6f0428

Rollup of 12 pull requests
Successful merges:
- #149961 (tidy: add if-installed prefix condition to extra checks system)
- #150475 (std: sys: fs: uefi: Implement initial File)
- #150533 (std: sys: fs: uefi: Implement remove_dir_all)
- #150549 (fix missing_panics_doc in `std::os::fd::owned`)
- #150699 (MGCA: Support literals as direct const arguments)
- #150721 (Deprecated doc intra link)
- #150752 (Update libc to v0.2.180)
- #150802 (Minor cleanups to fn_abi_new_uncached)
- #150803 (compiler-builtins subtree update)
- #150809 (Update `literal-escaper` version to `0.0.7`)
- #150811 (Store defids instead of symbol names in the aliases list)
- #150825 (Query associated_item_def_ids when needed)
r? @ghost

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

5a3e316

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 11 pull requests #150832

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

1a5ba32

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 10 pull requests #150837

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

2b8d954

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

eb4256d

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

a74c2fb

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#150699- literals-as-direct-const-args, r=B…

ab5075d

…oxyUwU
MGCA: Support literals as direct const arguments
Fixes [rust-lang#150168](rust-lang#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

This was referenced Jan 8, 2026

Rollup of 12 pull requests #150838

Closed

Rollup of 11 pull requests #150839

Merged

rust-borsBot added a commit that referenced this pull request

Auto merge of#150839- matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr

3fda0e4

Rollup of 11 pull requests
Successful merges:
- #149961 (tidy: add if-installed prefix condition to extra checks system)
- #150475 (std: sys: fs: uefi: Implement initial File)
- #150533 (std: sys: fs: uefi: Implement remove_dir_all)
- #150549 (fix missing_panics_doc in `std::os::fd::owned`)
- #150699 (MGCA: Support literals as direct const arguments)
- #150721 (Deprecated doc intra link)
- #150802 (Minor cleanups to fn_abi_new_uncached)
- #150803 (compiler-builtins subtree update)
- #150809 (Update `literal-escaper` version to `0.0.7`)
- #150811 (Store defids instead of symbol names in the aliases list)
- #150825 (Query associated_item_def_ids when needed)
r? @ghost

rust-borsBot merged commit cb3b2d8 into rust-lang:main

11 checks passed

rustbot added this to the 1.94.0 milestone

rust-timer added a commit that referenced this pull request

Unrolled build for#150699

7dcb568

Rollup merge of #150699 - literals-as-direct-const-args, r=BoxyUwU
MGCA: Support literals as direct const arguments
Fixes [#150168](#150618)
- **initial changes for mcga literals**
- **rustfmt**
r? @BoxyUwU

zachs18 mentioned this pull request

[ICE]: ty::ConstKind::Error constructed but no error reported#151625

Closed

github-actionsBot mentioned this pull request

Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345

Closed

github-actionsBot pushed a commit to rust-lang/compiler-builtins that referenced this pull request

Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr

a8b25fe

Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#149961 (tidy: add if-installed prefix condition to extra checks system)
- rust-lang/rust#150475 (std: sys: fs: uefi: Implement initial File)
- rust-lang/rust#150533 (std: sys: fs: uefi: Implement remove_dir_all)
- rust-lang/rust#150549 (fix missing_panics_doc in `std::os::fd::owned`)
- rust-lang/rust#150699 (MGCA: Support literals as direct const arguments)
- rust-lang/rust#150721 (Deprecated doc intra link)
- rust-lang/rust#150802 (Minor cleanups to fn_abi_new_uncached)
- rust-lang/rust#150803 (compiler-builtins subtree update)
- rust-lang/rust#150809 (Update `literal-escaper` version to `0.0.7`)
- rust-lang/rust#150811 (Store defids instead of symbol names in the aliases list)
- rust-lang/rust#150825 (Query associated_item_def_ids when needed)
r? @ghost

tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request

Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr

5bc14e3

Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#149961 (tidy: add if-installed prefix condition to extra checks system)
- rust-lang/rust#150475 (std: sys: fs: uefi: Implement initial File)
- rust-lang/rust#150533 (std: sys: fs: uefi: Implement remove_dir_all)
- rust-lang/rust#150549 (fix missing_panics_doc in `std::os::fd::owned`)
- rust-lang/rust#150699 (MGCA: Support literals as direct const arguments)
- rust-lang/rust#150721 (Deprecated doc intra link)
- rust-lang/rust#150802 (Minor cleanups to fn_abi_new_uncached)
- rust-lang/rust#150803 (compiler-builtins subtree update)
- rust-lang/rust#150809 (Update `literal-escaper` version to `0.0.7`)
- rust-lang/rust#150811 (Store defids instead of symbol names in the aliases list)
- rust-lang/rust#150825 (Query associated_item_def_ids when needed)
r? @ghost

BoxyUwU mentioned this pull request

mGCA: Support directly represented negated literals #152123

Closed

flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request

Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr

8500810

Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#149961 (tidy: add if-installed prefix condition to extra checks system)
- rust-lang/rust#150475 (std: sys: fs: uefi: Implement initial File)
- rust-lang/rust#150533 (std: sys: fs: uefi: Implement remove_dir_all)
- rust-lang/rust#150549 (fix missing_panics_doc in `std::os::fd::owned`)
- rust-lang/rust#150699 (MGCA: Support literals as direct const arguments)
- rust-lang/rust#150721 (Deprecated doc intra link)
- rust-lang/rust#150802 (Minor cleanups to fn_abi_new_uncached)
- rust-lang/rust#150803 (compiler-builtins subtree update)
- rust-lang/rust#150809 (Update `literal-escaper` version to `0.0.7`)
- rust-lang/rust#150811 (Store defids instead of symbol names in the aliases list)
- rust-lang/rust#150825 (Query associated_item_def_ids when needed)
r? @ghost

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsT-clippyT-compilerT-rustdoc