Skip to content

ui: add test for normalizing const projections with assoc const equality - #150975

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vsriramv:add-test-norm-const-projections-mgca
Jan 12, 2026
Merged

ui: add test for normalizing const projections with assoc const equality#150975
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vsriramv:add-test-norm-const-projections-mgca

Conversation

@vsriramv

@vsriramvvsriramv commented Jan 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This adds a UI test to associated-const-bindings (created new) directory to ensure that constant projections with associated const equality bounds are correctly normalized.

File added:

  • tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs

r? @fmease
r? @camelid

Fixes#120905

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@rustbot

rustbot commented Jan 11, 2026

Copy link
Copy Markdown
Collaborator

fmease is not on the review rotation at the moment.
They may take a while to respond.

fmease
fmease approved these changes Jan 11, 2026
View reviewed changes

@fmeasefmease left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

Comment threadtests/ui/const-generics/mgca/assoc-const-equality-normalization.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease

fmease commented Jan 11, 2026•
edited
Loading

Copy link
Copy Markdown
Member

In PR #150843, I've created a new test subdirectory specifically for associated const equality aka associated const bindings, namely tests/ui/const-generics/associated-const-bindings/. Well, the change hasn't been merged yet but it's in the merge queue (see PR #150843).

Could you move that test into this directory (which you have to create first since it doesn't exist on main yet). I hope that that won't lead to merge conflicts down the line but it really shouldn't.

@fmease

fmease commented Jan 11, 2026

Copy link
Copy Markdown
Member

Could you please also squash your changes into one commit? Thanks!

@vsriramv

vsriramv commented Jan 11, 2026

Copy link
Copy Markdown
ContributorAuthor

ok, sure!

fmease
fmease reviewed Jan 11, 2026
View reviewed changes
Comment threadtests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs

@fmeasefmeaseJan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move+rename this file to tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs? Thanks in advance!

See #150975 (comment) for context.

@vsriramvvsriramvJan 11, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@vsriramv
vsriramvforce-pushed the add-test-norm-const-projections-mgca branch from 4f26b69 to 8d1d88bCompareJanuary 11, 2026 18:40
@rustbot

rustbot commented Jan 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@fmease

fmease commented Jan 11, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-borsrust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026
@rust-bors

rust-borsBot commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8d1d88b has been approved by fmease

It is now in the queue for this repository.

@rust-borsrust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2026
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 11, 2026
Merged
rust-borsBot added a commit that referenced this pull request Jan 12, 2026
@rust-bors
Auto merge of#150981- matthiaskrgr:rollup-px5fFnj, r=matthiaskrgr
840245e
Rollup of 9 pull requests
Successful merges:
- #147938 (Add const cloning of slices and tests)
- #149718 (Add freeze file times on Windows)
- #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
- #150790 (feat: invisible character help string)
- #150906 (Simplify `#[eii]` macro using methods on ecx)
- #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
- #150953 (std: sys: fs: uefi: Implement copy)
- #150964 (Completely list all unparsed attributes)
- #150975 (ui: add test for normalizing const projections with assoc const equality)
Failed merges:
- #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))
r? @ghost
@rust-bors
rust-borsBot merged commit c31e68f into rust-lang:mainJan 12, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 12, 2026
@rust-timer
Unrolled build for#150975
b392bb4
Rollup merge of #150975 - add-test-norm-const-projections-mgca, r=fmease
ui: add test for normalizing const projections with assoc const equality
This adds a UI test to associated-const-bindings (created new) directory to ensure that constant projections with associated const equality bounds are correctly normalized.
File added:
- `tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs`
r? @fmease
r? @camelidFixes#120905
@rustbotrustbot added this to the 1.94.0 milestone Jan 12, 2026
@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

Assoc const bindings aren't taken into consideration when normalizing const projections

4 participants

@vsriramv@rustbot@rust-log-analyzer@fmease