Port some crate level attrs to the attribute parser - #151343

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
Ozzy1423:attrs2
Jan 22, 2026
Merged

Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
Ozzy1423:attrs2

Conversation

@Ozzy1423

@Ozzy1423Ozzy1423 commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

Tracking issue: #131229

Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.

r? @JonathanBrouwer

@rustbot

rustbot commented Jan 18, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 19, 2026
Open
9 tasks
JonathanBrouwer
JonathanBrouwer reviewed Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs Outdated
JonathanBrouwer
JonathanBrouwer reviewed Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs Outdated
JonathanBrouwer
JonathanBrouwer approved these changes Jan 19, 2026
View reviewed changes

@JonathanBrouwerJonathanBrouwer left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing

View changes since this review

@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented Jan 19, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b755b3b has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented Jan 20, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 37d505c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2026
@jhprattjhpratt mentioned this pull request Jan 21, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 21, 2026
@rustbot

rustbot commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Ozzy1423

Ozzy1423 commented Jan 21, 2026

Copy link
Copy Markdown
ContributorAuthor

I'll wait for this #151442 and then rebase a final time!

@JonathanBrouwer

JonathanBrouwer commented Jan 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

I'll let this one go first, crate_type still needs a perf run
@bors r+

@rust-bors

rust-borsBot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f6d7638 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 21, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 21, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot merged commit 18504a1 into rust-lang:mainJan 22, 2026
11 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Jan 22, 2026
rust-timer added a commit that referenced this pull request Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423 deleted the attrs2 branch February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Port some crate level attrs to the attribute parser - #151343
Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Jan 22, 2026
Merged
Port some crate level attrs to the attribute parser#151343
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom 
Ozzy1423:attrs2
Conversation
@Ozzy1423
@Ozzy1423Ozzy1423
commented
Jan 18, 2026

Copy link


Copy Markdown

Contributor
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@rustbot
rustbot
commented
Jan 18, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_hir/src/attrs
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 19, 2026

Open

9 tasks
JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
Outdated

JonathanBrouwer
JonathanBrouwer
reviewed
Jan 19, 2026
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs
Outdated

JonathanBrouwer
JonathanBrouwer
approved these changes
Jan 19, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebasing
View changes since this review
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 19, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 19, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b755b3b has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwer
commented
Jan 20, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jan 20, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 37d505c has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 20, 2026
@jhprattjhpratt
mentioned this pull request
Jan 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151436- jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4
Rollup of 6 pull requests
Successful merges:
- #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- #151340 (Port `#[patchable_function_entry]` to attr parser)
- #151351 (Deduplicate diagnostics for const trait supertraits)
- #151424 (missing colon after the compile-flags directive)
- #151428 (Port variance attrs to attr parser.)
- #151429 (s390x: Support aligned stack datalayout)
Failed merges:
- #151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 21, 2026
@rustbot
rustbot
commented
Jan 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@Ozzy1423
Ozzy1423
commented
Jan 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I'll wait for this #151442 and then rebase a final time!
@JonathanBrouwer
JonathanBrouwer
commented
Jan 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'll let this one go first, crate_type still needs a perf run
@bors r+
@rust-bors
rust-borsBot
commented
Jan 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit f6d7638 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 21, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Merged

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#151343- Ozzy1423:attrs2, r=JonathanBrouwer
f0c7d97
Port some crate level attrs to the attribute parser
Tracking issue: rust-lang#131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jan 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jan 21, 2026
@bors
Auto merge of#151471- JonathanBrouwer:rollup-EgxENYU, r=JonathanBro…
004d710
…uwer
Rollup of 5 pull requests
Successful merges:
- #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
- #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
- #151219 (Fixed ICE when using function pointer as const generic parameter)
- #151343 (Port some crate level attrs to the attribute parser)
- #151463 (add x86_64-unknown-linux-gnuasan to CI)
r? @ghost
@rust-bors
rust-borsBot
merged commit 18504a1
into
rust-lang:mainJan 22, 2026

11 checks passed

@rustbotrustbot
added this to the 1.95.0 milestone
Jan 22, 2026
rust-timer added a commit
that referenced
this pull request
Jan 22, 2026
@rust-timer
Unrolled build for#151343
833a172
Rollup merge of #151343 - Ozzy1423:attrs2, r=JonathanBrouwer
Port some crate level attrs to the attribute parser
Tracking issue: #131229
Ports compiler_builtins, panic_runtime, needs_panic_runtime, profiler_runtime and no_builtins to the attribute parsing infrastructure.
r? @JonathanBrouwer
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
bdb1708
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
christian-schilling pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
51f061e
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
- rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser)
- rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits)
- rust-lang/rust#151424 (missing colon after the compile-flags directive)
- rust-lang/rust#151428 (Port variance attrs to attr parser.)
- rust-lang/rust#151429 (s390x: Support aligned stack datalayout)
Failed merges:
- rust-lang/rust#151343 (Port some crate level attrs to the attribute parser)
r? @ghost
@Ozzy1423
Ozzy1423
deleted the

attrs2

branch
February 3, 2026 07:04
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer approved these changes

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozzy1423@rustbot@JonathanBrouwer