Skip to content

Stabilize proc_macro_value feature - #151973

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-proc_macro_value
Open

Stabilize proc_macro_value feature#151973
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-proc_macro_value

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 2, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Fixes#136652.

The feature implementation is complete: all string related values now have their _value method and proc_macro2 integration seems to be working as expected.

Integers are voluntarily left untouched as an equivalent API for them is much trickier to provide. I'll open an ACP once I come up with a design I'm happy with.

r? @Amanieu

@GuillaumeGomezGuillaumeGomez added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 2, 2026
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2026
@jhprattjhpratt added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Feb 2, 2026
@Amanieu

Amanieu commented Mar 28, 2026

Copy link
Copy Markdown
Member

r? @dtolnay

@rustbotrustbot assigned dtolnay and unassigned AmanieuMar 28, 2026
@Amanieu

Amanieu commented Mar 28, 2026

Copy link
Copy Markdown
Member

I'm not sure if we should be stabilizing this without at least a sketch for the the integer value API, but I'm not the best person to determine this since I haven't used the proc macro API much.

traviscross
traviscross reviewed May 31, 2026
View reviewed changes
Comment threadlibrary/proc_macro/src/lib.rs Outdated
Comment threadlibrary/proc_macro/src/lib.rs
Comment threadlibrary/proc_macro/src/lib.rs Outdated
This was referenced Jun 2, 2026
Merged
Closed
@rust-bors

This comment has been minimized.

Sign in to view
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge ofrust-lang#157338- GuillaumeGomez:byte_character_valu…
62c1695
…e, r=traviscross,Mark-Simulacrum
Make `Literal::byte_character_value` work with bytes as well
As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.
r? @traviscross
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge ofrust-lang#157338- GuillaumeGomez:byte_character_valu…
46ce37e
…e, r=traviscross,Mark-Simulacrum
Make `Literal::byte_character_value` work with bytes as well
As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.
r? @traviscross
rust-timer added a commit that referenced this pull request Jun 10, 2026
@rust-timer
Unrolled build for#157338
e602611
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=traviscross,Mark-Simulacrum
Make `Literal::byte_character_value` work with bytes as well
As noted in [this comment](#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.
r? @traviscross
pullBot pushed a commit to Kokoro2336/rust-analyzer that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=trav…
98cb773
…iscross,Mark-Simulacrum
Make `Literal::byte_character_value` work with bytes as well
As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.
r? @traviscross
@GuillaumeGomez
GuillaumeGomezforce-pushed the stabilize-proc_macro_value branch from d96083f to 300da0fCompareJune 15, 2026 13:39
@rustbot

rustbot commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2026

Copy link
Copy Markdown
MemberAuthor

Fixed merge conflict. Are there any concerns remaining or should we start an FCP?

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jun 15, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 18, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157935- GuillaumeGomez:ConversionErrorKind…
12a2d3c
…-non-exhaustive, r=traviscross,Mark-Simulacrum
Make `proc_macro::ConversionErrorKind` non exhaustive
Needed for rust-lang#151973.
r? @traviscross
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 18, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157935- GuillaumeGomez:ConversionErrorKind…
3ecdd65
…-non-exhaustive, r=traviscross,Mark-Simulacrum
Make `proc_macro::ConversionErrorKind` non exhaustive
Needed for rust-lang#151973.
r? @traviscross
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 18, 2026
@GuillaumeGomez
Rollup merge ofrust-lang#157935- GuillaumeGomez:ConversionErrorKind…
97e7f77
…-non-exhaustive, r=traviscross,Mark-Simulacrum
Make `proc_macro::ConversionErrorKind` non exhaustive
Needed for rust-lang#151973.
r? @traviscross
rust-timer added a commit that referenced this pull request Jun 18, 2026
@rust-timer
Unrolled build for#157935
1101773
Rollup merge of #157935 - GuillaumeGomez:ConversionErrorKind-non-exhaustive, r=traviscross,Mark-Simulacrum
Make `proc_macro::ConversionErrorKind` non exhaustive
Needed for #151973.
r? @traviscross
@GuillaumeGomez

GuillaumeGomez commented Jun 19, 2026

Copy link
Copy Markdown
MemberAuthor

All suggestions were implemented. cc @traviscross

@GuillaumeGomez

GuillaumeGomez commented Jul 9, 2026

Copy link
Copy Markdown
MemberAuthor

ping @rust-lang/libs-api

ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
@jhpratt
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=trav…
b3d3e60
…iscross,Mark-Simulacrum
Make `Literal::byte_character_value` work with bytes as well
As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.
r? @traviscross
@clarfontheyclarfonthey added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api [DEPRECATED; DO NOT USE] labels Aug 12, 2026
@clarfonthey

clarfonthey commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@rustbot label:I-libs-nominated

@rustbotrustbot added the I-libs-nominated Nominated for discussion during a libs team meeting. label Aug 24, 2026
@clarfonthey

clarfonthey commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

r? libs

@rustbotrustbot assigned nia-e and unassigned dtolnayAug 24, 2026
@nia-e

nia-e commented Aug 25, 2026

Copy link
Copy Markdown
Member

@rfcbot fcp merge libs

@rust-rfcbot

rust-rfcbot commented Aug 25, 2026•
edited by Amanieu
Loading

Copy link
Copy Markdown
Collaborator

@nia-e has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbotrust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. and removed needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@traviscrosstraviscrosstraviscross left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nia-enia-e

Labels

disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.I-libs-nominatedNominated for discussion during a libs team meeting.proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for proc_macro_value

9 participants

@GuillaumeGomez@Amanieu@rustbot@clarfonthey@nia-e@rust-rfcbot@traviscross@dtolnay@jhpratt