Skip to content

Hard code DEFAULT_LOCALE_RESOURCES in rustc_interface - #152137

Closed
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:driver_fixed_locale_resources
Closed

Hard code DEFAULT_LOCALE_RESOURCES in rustc_interface#152137
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:driver_fixed_locale_resources

Conversation

@bjorn3

@bjorn3bjorn3 commented Feb 4, 2026

Copy link
Copy Markdown
Member

locale_resources will no longer be used at all soon, so no need for custom drivers to have the ability to define their own locale_resources. Also hard code report_ice to not use any locale resources. It only emits diagnostics that have already been ported to inline fluent messages.

Part of #151366, cc @JonathanBrouwer

@rustbot

rustbot commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Feb 4, 2026
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot

rustbot commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 4, 2026
Closed
7 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3force-pushed the driver_fixed_locale_resources branch from 8f3dce7 to dbf46f0CompareFebruary 4, 2026 19:54
bjorn3
bjorn3 commented Feb 4, 2026
View reviewed changes
Comment threadsrc/librustdoc/clean/render_macro_matchers.rs

// Create a Parser.
let psess = ParseSess::new(rustc_driver::DEFAULT_LOCALE_RESOURCES.to_vec());
let psess = ParseSess::new(vec![]);

@bjorn3bjorn3Feb 4, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as we cancel all errors below rather than emit them.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented Feb 4, 2026

Copy link
Copy Markdown
Member

I'd like to wait a few days with merging this until the spam of diagnostics convert PRs has calmed down, as this will conflict with all of them

@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3force-pushed the driver_fixed_locale_resources branch from dbf46f0 to 1090fa4CompareFebruary 5, 2026 11:06
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3force-pushed the driver_fixed_locale_resources branch from 1090fa4 to 4d3c16aCompareFebruary 5, 2026 17:56
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
Hard code DEFAULT_LOCALE_RESOURCES in rustc_interface
ed6914c
locale_resources will no longer be used at all soon, so no need for
custom drivers to have the ability to define their own locale_resources.
Also hard code report_ice to not use any locale resources. It only emits
diagnostics that have already been ported to inline fluent messages.
@bjorn3
bjorn3force-pushed the driver_fixed_locale_resources branch from 4d3c16a to ed6914cCompareFebruary 6, 2026 15:06
@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbotrustbot added the T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. label Feb 6, 2026
@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

rust-log-analyzer commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

The job pr-check-2 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260123.484
Commit: 6bd6555ca37d84114959e1c76d2c01448ff61c5d
Build Date: 2026-01-23T19:41:17Z
Worker ID: {97be7183-ab35-4bee-85c1-3e7e851e22e4}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS
---
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/dependabot/dependabot-updater-core latest b72a662c47e3 6 days ago 790MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:57ef9cc45f72cc4258ee1baa8243bc3cd55c0a0e570b6768c37346247be35f0d
deleted: sha256:b72a662c47e31df2e7bf59368b2b83be239f02a1baa721393717711a1a719df9
deleted: sha256:3e13ccd80f19769f39008cfc6549938e1ea4905f47b028c1df2dd6085191386c
deleted: sha256:842807995a512b2c5a9b241a3aecdbe79af6b0642d96fa5460cfcf0c9d8be295
deleted: sha256:0f9074b9f46f4570eb7cb4b65fcb3c3d909f9b1d14ca66b30508117b6deda303
deleted: sha256:2ca99cb9251d19157c56b5d91c8961bb4b35196a5ca9b4ffdccbf24abbfe2a5f

@rust-bors

rust-borsBot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #152239) made this pull request unmergeable. Please resolve the merge conflicts.

@JonathanBrouwer

JonathanBrouwer commented Feb 7, 2026•
edited
Loading

Copy link
Copy Markdown
Member

r=me if you rebase and fix CI
Alternatively there's only 2 crates left atm (which are both waiting for review), and after that #152250 removes the entire DEFAULT_LOCALE_RESOURCES list

@JonathanBrouwer

JonathanBrouwer commented Feb 8, 2026

Copy link
Copy Markdown
Member

This is now superseded by #152250
Thanks for the PR, but the conversion happened way faster than I was expecting, so I couldn't really find the right time to merge this, sorry

@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2026
@bjorn3bjorn3 mentioned this pull request Feb 8, 2026
Merged
@bjorn3
bjorn3 deleted the driver_fixed_locale_resources branch February 8, 2026 19:32
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 8, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-rustc-dev-guideArea: rustc-dev-guideT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3@rustbot@rust-log-analyzer@JonathanBrouwer@jdonszelmann