Skip to content

Convert to inline diagnostics in rustc_passes - #152189

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:convert_passes
Feb 6, 2026
Merged

Convert to inline diagnostics in rustc_passes#152189
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:convert_passes

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Feb 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@rustbot

rustbot commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 5, 2026
Closed
7 tasks
@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lqd

lqd commented Feb 6, 2026

Copy link
Copy Markdown
Member

I'll also take this one, we're so close

r? me

@rustbotrustbot assigned lqd and unassigned jdonszelmannFeb 6, 2026
@lqd

lqd commented Feb 6, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ea43035 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 6, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Feb 6, 2026
@bors
Auto merge of#152239- JonathanBrouwer:rollup-2BolGX5, r=JonathanBro…
efc9e1b
…uwer
Rollup of 3 pull requests
Successful merges:
- #152129 (MGCA: require #[type_const] on free consts too)
- #152139 (mGCA: Support directly represented negated literals)
- #152189 (Convert to inline diagnostics in `rustc_passes`)
@rust-bors
rust-borsBot merged commit ce8d09b into rust-lang:mainFeb 6, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 6, 2026
@rust-timer
Unrolled build for#152189
202ae33
Rollup merge of #152189 - JonathanBrouwer:convert_passes, r=lqd
Convert to inline diagnostics in `rustc_passes`
For #151366
r? @jdonszelmann
@rustbotrustbot added this to the 1.95.0 milestone Feb 6, 2026
@github-actionsgithub-actionsBot mentioned this pull request Feb 10, 2026
Closed
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #152239 - JonathanBrouwer:rollup-2BolGX5, r=JonathanBro…
f85d428
…uwer
Rollup of 3 pull requests
Successful merges:
- rust-lang/rust#152129 (MGCA: require #[type_const] on free consts too)
- rust-lang/rust#152139 (mGCA: Support directly represented negated literals)
- rust-lang/rust#152189 (Convert to inline diagnostics in `rustc_passes`)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqdlqd

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer@rustbot@lqd@jdonszelmann