Uh oh!
There was an error while loading. Please reload this page.
Fix LegacyKeyValueFormat report from docker build - #152305
Conversation
rustbot
commented
Feb 7, 2026
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Uh oh!
There was an error while loading. Please reload this page.
| @@ -76,7 +76,7 @@ ENV HOSTS=aarch64-unknown-linux-gnu | |||
| ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH | |||
There was a problem hiding this comment.
Note that here docker reports:
WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$CPATH' (did you mean $PATH?)
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile:77
--------------------
75 | ENV HOSTS=aarch64-unknown-linux-gnu
76 |
77 | >>> ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
78 |
79 | ENV RUST_CONFIGURE_ARGS=" \
I'm not sure if this warning should be fixed or if there is an error regarding this.
(That is the sole remaining warning after this commit)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
| @@ -1,5 +1,5 @@ | |||
| # Runs `distcheck`, which is a collection of smoke tests: | |||
| # | |||
| # | |||
There was a problem hiding this comment.
My IDE probably did that, should I revert?
Uh oh!
There was an error while loading. Please reload this page.
e408c33 to
23a41c9Compare
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
23a41c9 to
baef5fdCompare
This comment has been minimized.
This comment has been minimized.
baef5fd to
2ecbcb8Compare
This comment has been minimized.
This comment has been minimized.
2ecbcb8 to
20f7242CompareUh oh!
There was an error while loading. Please reload this page.
20f7242 to
ad71a75Compare
This comment was marked as outdated.
This comment was marked as outdated.
Rollup merge of #153533 - homersimpsons:chore/fix-LegacyKeyValueFormat-miscellaneous, r=marcoieni Fix LegacyKeyValueFormat report from docker build: miscellaneous Part of #152305 Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others. r? @marcoieni
…alueFormat-pr, r=marcoieni Fix LegacyKeyValueFormat report from docker build: pr Part of rust-lang#152305 r? @marcoieni
…alueFormat-pr, r=marcoieni Fix LegacyKeyValueFormat report from docker build: pr Part of rust-lang#152305 r? @marcoieni
…alueFormat-pr, r=marcoieni Fix LegacyKeyValueFormat report from docker build: pr Part of rust-lang#152305 r? @marcoieni
…t-miscellaneous, r=marcoieni Fix LegacyKeyValueFormat report from docker build: miscellaneous Part of rust-lang/rust#152305 Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others. r? @marcoieni
…t-pr, r=marcoieni Fix LegacyKeyValueFormat report from docker build: pr Part of rust-lang/rust#152305 r? @marcoieni
…alueFormat-x86_64-gnu, r=marcoieni Fix LegacyKeyValueFormat report from docker build: x86_64-gnu Part of rust-lang#152305 r? @marcoieni
…alueFormat-x86_64-gnu, r=marcoieni Fix LegacyKeyValueFormat report from docker build: x86_64-gnu Part of rust-lang#152305 r? @marcoieni
…alueFormat-x86_64-gnu, r=marcoieni Fix LegacyKeyValueFormat report from docker build: x86_64-gnu Part of rust-lang#152305 r? @marcoieni
…alueFormat-various, r=marcoieni Fix LegacyKeyValueFormat report from docker build: various Part of rust-lang#152305 r? @marcoieni
…alueFormat-various, r=marcoieni Fix LegacyKeyValueFormat report from docker build: various Part of rust-lang#152305 r? @marcoieni
…t-various, r=marcoieni Fix LegacyKeyValueFormat report from docker build: various Part of rust-lang/rust#152305 r? @marcoieni
…t-various, r=marcoieni Fix LegacyKeyValueFormat report from docker build: various Part of rust-lang/rust#152305 r? @marcoieni
…t-miscellaneous, r=marcoieni Fix LegacyKeyValueFormat report from docker build: miscellaneous Part of rust-lang/rust#152305 Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others. r? @marcoieni
…t-miscellaneous, r=marcoieni Fix LegacyKeyValueFormat report from docker build: miscellaneous Part of rust-lang/rust#152305 Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others. r? @marcoieni
…t-various, r=marcoieni Fix LegacyKeyValueFormat report from docker build: various Part of rust-lang/rust#152305 r? @marcoieni
…t-miscellaneous, r=marcoieni Fix LegacyKeyValueFormat report from docker build: miscellaneous Part of rust-lang/rust#152305 Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others. r? @marcoieni
…alueFormat-mips, r=marcoieni Fix LegacyKeyValueFormat report from docker build: mips Part of rust-lang#152305 r? @marcoieni
Rollup merge of #153528 - homersimpsons:chore/fix-LegacyKeyValueFormat-mips, r=marcoieni Fix LegacyKeyValueFormat report from docker build: mips Part of #152305 r? @marcoieni
…alueFormat-i686, r=marcoieni Fix LegacyKeyValueFormat report from docker build: i686 Part of rust-lang#152305 r? @marcoieni
Rollup merge of #153526 - homersimpsons:chore/fix-LegacyKeyValueFormat-i686, r=marcoieni Fix LegacyKeyValueFormat report from docker build: i686 Part of #152305 r? @marcoieni
…alueFormat-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of rust-lang#152305 r? @marcoieni
…alueFormat-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of rust-lang#152305 r? @marcoieni
…alueFormat-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of rust-lang#152305 r? @marcoieni
Rollup merge of #153374 - homersimpsons:chore/fix-LegacyKeyValueFormat-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of #152305 r? @marcoieni
…t-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of rust-lang/rust#152305 r? @marcoieni
…alueFormat-powerpc, r=marcoieni Fix LegacyKeyValueFormat report from docker build: powerpc Part of rust-lang#152305 r? @marcoieni
Rollup merge of #153373 - homersimpsons:chore/fix-LegacyKeyValueFormat-powerpc, r=marcoieni Fix LegacyKeyValueFormat report from docker build: powerpc Part of #152305 r? @marcoieni
…t-dist-x86_64, r=marcoieni Fix LegacyKeyValueFormat report from docker build: dist-x86_64 Part of rust-lang/rust#152305 r? @marcoieni
…t-powerpc, r=marcoieni Fix LegacyKeyValueFormat report from docker build: powerpc Part of rust-lang/rust#152305 r? @marcoieni
Merge split (requested in #152305 (comment)):
aarch64-gnu-debug(1): Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug #153109aarch64(3): Fix LegacyKeyValueFormat report from docker build: host-aarch64 #153223disabled/(11): Fix LegacyKeyValueFormat report from docker build: disabled #153224arm(7): Fix LegacyKeyValueFormat report from docker build: arm #153371x86_64-gnu(10): Fix LegacyKeyValueFormat report from docker build: x86_64-gnu #153372dist-x86_64(6): Fix LegacyKeyValueFormat report from docker build: dist-x86_64 #153374powerpc(5): Fix LegacyKeyValueFormat report from docker build: powerpc #153373i686(4): Fix LegacyKeyValueFormat report from docker build: i686 #153526ohos(2): Fix LegacyKeyValueFormat report from docker build: ohos #153527mips(4): Fix LegacyKeyValueFormat report from docker build: mips #153528pr-check-1,pr-check-2,tidy(3): Fix LegacyKeyValueFormat report from docker build: pr #153529dist-various-1,dist-various-2,test-various(3): Fix LegacyKeyValueFormat report from docker build: various #153531dist-android,dist-loongarch64-linux,dist-loongarch64-musl,dist-riscv64-linux,dist-s390x-linux,dist-sparcv9-solaris,x86_64-fuchsia,x86_64-rust-for-linux(8): Fix LegacyKeyValueFormat report from docker build: miscellaneous #153533While checking job logs (https://github.com/rust-lang/rust/actions/runs/21779827147/job/62842068357#step:28:217) I noticed:
I identified warnings with:
I went with
ENV ENVVAR="quoted"because it is the most working solution I found. Note that I did not touch lines that did not report a warning but that were written asENV ENVVAR=unquotedorENV ENVVAR=multi \\n line.