Disable debug_assert_not_in_new_nodes for multiple threads - #152655

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged

Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zetanumbers:disable_debug_assert_151509

Conversation

@zetanumbers

@zetanumberszetanumbers commented Feb 15, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes#152654

This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2026
@rustbot

rustbot commented Feb 15, 2026

Copy link
Copy Markdown
Collaborator

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates

@nnethercote

nnethercote commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.

@nnethercotennethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2026
@Zoxc

Zoxc commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

@Zoxc

Zoxc commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

We could probably consider removing it too. I don't think it has much value anymore.

@zetanumbers

zetanumbers commented Feb 27, 2026

Copy link
Copy Markdown
ContributorAuthor

Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.

Updated the top comment. Is this good?

@nnethercote

nnethercote commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Updated the top comment. Is this good?

Yes, thank you.

I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
We could probably consider removing it too. I don't think it has much value anymore.

This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9fb9225 has been approved by nnethercote

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))
This was referenced Mar 1, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot pushed a commit that referenced this pull request Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot merged commit fbbb35d into rust-lang:mainMar 1, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 1, 2026
rust-timer added a commit that referenced this pull request Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers deleted the disable_debug_assert_151509 branch March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection

4 participants

@zetanumbers@rustbot@nnethercote@Zoxc
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Disable debug_assert_not_in_new_nodes for multiple threads - #152655
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Mar 1, 2026
Merged
Disable debug_assert_not_in_new_nodes for multiple threads#152655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
zetanumbers:disable_debug_assert_151509
Conversation
@zetanumbers
@zetanumberszetanumbers
commented
Feb 15, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 15, 2026
@rustbot
rustbot
commented
Feb 15, 2026

Copy link


Copy Markdown

Collaborator
r? @nnethercote
rustbot has assigned @nnethercote.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 68 candidates
  • Random selection from 14 candidates
@nnethercote
nnethercote
commented
Feb 16, 2026

Copy link


Copy Markdown

Contributor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
@nnethercotennethercote
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2026
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.
@Zoxc
Zoxc
commented
Feb 18, 2026

Copy link


Copy Markdown

Contributor
We could probably consider removing it too. I don't think it has much value anymore.
@zetanumbers
zetanumbers
commented
Feb 27, 2026

Copy link


Copy Markdown

ContributorAuthor
Please give some explanation of what this change is doing, and why. Even though it's a small change, just writing "Fixes #152654" isn't enough.
Updated the top comment. Is this good?
@nnethercote
nnethercote
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Updated the top comment. Is this good?
Yes, thank you.
I think assert_dep_node_not_yet_allocated_in_current_session can race too. I'd just disable these by not setting the nodes_in_current_session field on multiple threads.

We could probably consider removing it too. I don't think it has much value anymore.
This PR is enough to fix a known bug. To keep things moving I will approve it as is. Please open a follow-up PR implementing either of these suggestions if you like. The second option is more expansive -- there are multiple checks involving nodes_in_current_session -- so if you do that please make sure to explain clearly why removing it is valid. Thanks!
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 9fb9225 has been approved by nnethercote
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 1, 2026
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
@matthiaskrgr
Rollup merge ofrust-lang#152655- zetanumbers:disable_debug_assert_1…
358ae92
…51509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixesrust-lang#152654
This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))

This was referenced Mar 1, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
9c41836
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 1, 2026
@bors
Auto merge of#153252- matthiaskrgr:rollup-uYxeyaV, r=matthiaskrgr
024757f
Rollup of 5 pull requests
Successful merges:
- #152042 (Suggest async block instead of async closure when possible)
- #152949 (Introduce --ci flag in tidy)
- #152655 (Disable debug_assert_not_in_new_nodes for multiple threads)
- #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`)
- #153229 (rustfmt: add test for field representing type builtin syntax)
@rust-bors
rust-borsBot
merged commit fbbb35d
into
rust-lang:mainMar 1, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 1, 2026
rust-timer added a commit
that referenced
this pull request
Mar 1, 2026
@rust-timer
Unrolled build for#152655
541933d
Rollup merge of #152655 - zetanumbers:disable_debug_assert_151509, r=nnethercote
Disable debug_assert_not_in_new_nodes for multiple threads
Fixes#152654
This debug assertion is no longer intended to succeed for the parallel compiler since #151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (#151509 (comment))
@zetanumbers
zetanumbers
deleted the

disable_debug_assert_151509

branch
March 2, 2026 06:43
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: node from previous graph present in new node collection


4 participants

@zetanumbers@rustbot@nnethercote@Zoxc