Tidy: disallow TODO in other in-tree projects - #153166

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged

Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
reddevilmidzy:codegen-tidy

Conversation

@reddevilmidzy

@reddevilmidzyreddevilmidzy commented Feb 27, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2026
reddevilmidzy
reddevilmidzy commented Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs Outdated
Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py Outdated
Comment threadsrc/tools/tidy/src/unit_tests.rs Outdated
@reddevilmidzy
reddevilmidzy marked this pull request as ready for review February 27, 2026 06:21
@rustbot

rustbot commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2026
@bjorn3

bjorn3 commented Feb 27, 2026

Copy link
Copy Markdown
Member

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

@jieyouxu

jieyouxu commented Feb 27, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

I would suggest not running full tidy against the cg_* subtrees yeah.

Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.

@reddevilmidzy

reddevilmidzy commented Feb 27, 2026

Copy link
Copy Markdown
MemberAuthor

Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.

@reddevilmidzy
reddevilmidzy marked this pull request as draft February 27, 2026 10:58
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view
This was referenced Mar 7, 2026
Merged
Merged
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed the codegen-tidy branch 2 times, most recently from 89a1cb9 to 2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy changed the title Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy commented Mar 7, 2026
View reviewed changes

@reddevilmidzyreddevilmidzy left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).

View changes since this review

Comment threadsrc/tools/tidy/src/codegen.rs

@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.

Comment threadcompiler/rustc_session/src/parse.rs
}
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated

@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀

@reddevilmidzy
reddevilmidzy marked this pull request as ready for review March 7, 2026 12:50
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
.enumerate()
.map(|(index, field)| {
self.context.new_field(None, *field, format!("field{}_TODO", index))
self.context.new_field(None, *field, format!("field{}_FIXME", index))

@lcnrlcnrMar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?

@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you

@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.

rust-lang/rustc_codegen_gcc@d82d242

cc: @antoyo

@antoyoantoyoMar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.

Comment threadsrc/tools/tidy/src/style.rs Outdated
let is_codegen_tidy_file = file.ends_with(codegen_file);
if is_codegen_tidy_file {
return;
}

@lcnrlcnrMar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53

I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check

@lcnrlcnrMar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?

after that r=me

@reddevilmidzy

reddevilmidzy commented Mar 13, 2026

Copy link
Copy Markdown
MemberAuthor

thank you for the review
@bors r=lcnr

@rust-bors

rust-borsBot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

@reddevilmidzy: 🔑 Insufficient privileges: not in review users

@reddevilmidzy

reddevilmidzy commented Mar 13, 2026

Copy link
Copy Markdown
MemberAuthor

@lcnr It's not working because I don't have permission... haha, Please roll it up.

@ShoyuVanilla

ShoyuVanilla commented Mar 15, 2026

Copy link
Copy Markdown
Member

Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅

after that r=me

@bors r=lcnr

@rust-bors

rust-borsBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e09936e has been approved by lcnr

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2026
@rust-bors

rust-borsBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: lcnr
Duration: 3h 13m 55s
Pushing 1e21831 to main...

@rust-bors
rust-borsBot merged commit 1e21831 into rust-lang:mainMar 15, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 15, 2026
@github-actions

github-actionsBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-borsrust-borsBot mentioned this pull request Mar 16, 2026
Merged
@rust-timer

rust-timer commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (1e21831): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary -3.5%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅
(secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0

Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)

@reddevilmidzy
reddevilmidzy deleted the codegen-tidy branch March 16, 2026 00:36
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot pushed a commit that referenced this pull request Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the x.py policy for TODO and FIXME to other in-tree projects

9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Tidy: disallow TODO in other in-tree projects - #153166
Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Mar 15, 2026
Merged
Tidy: disallow TODO in other in-tree projects#153166
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom 
reddevilmidzy:codegen-tidy
Conversation
@reddevilmidzy
@reddevilmidzyreddevilmidzy
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 27, 2026
reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/alphabetical.rs
Outdated

Comment threadcompiler/rustc_codegen_gcc/tools/generate_intrinsics.py
Outdated

Comment threadsrc/tools/tidy/src/unit_tests.rs
Outdated

@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
February 27, 2026 06:21
@rustbot
rustbot
commented
Feb 27, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
Some changes occurred in compiler/rustc_codegen_gcc
cc @antoyo, @GuillaumeGomez
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 27, 2026
@bjorn3
bjorn3
commented
Feb 27, 2026

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
@jieyouxu
jieyouxu
commented
Feb 27, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.
I would suggest not running full tidy against the cg_* subtrees yeah.
Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not othertidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.
@reddevilmidzy
reddevilmidzy
commented
Feb 27, 2026

Copy link


Copy Markdown

MemberAuthor
Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.
@reddevilmidzy
reddevilmidzy
marked this pull request as draft
February 27, 2026 10:58
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2026
@rust-bors

This comment has been minimized.

Sign in to view

This was referenced Mar 7, 2026
 Merged

 Merged

@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
codegen-tidy
branch
2 times, most recently
from
89a1cb9 to
2617d54CompareMarch 7, 2026 12:39
@reddevilmidzyreddevilmidzy
changed the title
Allow tidy check in codegenTidy: disallow TODO in other in-tree projectsMar 7, 2026
reddevilmidzy
reddevilmidzy
commented
Mar 7, 2026
View reviewed changes
@reddevilmidzyreddevilmidzy
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).
View changes since this review
Comment threadsrc/tools/tidy/src/codegen.rs
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.
Comment threadcompiler/rustc_session/src/parse.rs
 }
}

// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated
@reddevilmidzyreddevilmidzyMar 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase 👀
@reddevilmidzy
reddevilmidzy
marked this pull request as ready for review
March 7, 2026 12:50
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr
reviewed
Mar 9, 2026
View reviewed changes
Comment threadcompiler/rustc_codegen_gcc/src/type_.rs
 .enumerate()
 .map(|(index, field)| {
 self.context.new_field(None, *field, format!("field{}_TODO", index))
 self.context.new_field(None, *field, format!("field{}_FIXME", index))
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that fine?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'll check this again. Thank you
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed TODO to FIXME and tested it and it worked.
rust-lang/rustc_codegen_gcc@d82d242
cc: @antoyo
@antoyoantoyoMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be OK.
Comment threadsrc/tools/tidy/src/style.rs
Outdated

 let is_codegen_tidy_file = file.ends_with(codegen_file);
 if is_codegen_tidy_file {
 return;
 }
@lcnrlcnrMar 9, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?
@reddevilmidzyreddevilmidzyMar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53
I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check
@lcnrlcnrMar 13, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do it for this_file separately, can you the checks for these two?
after that r=me
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
thank you for the review
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 13, 2026

Copy link


Copy Markdown

Contributor
@reddevilmidzy: 🔑 Insufficient privileges: not in review users
@reddevilmidzy
reddevilmidzy
commented
Mar 13, 2026

Copy link


Copy Markdown

MemberAuthor
@lcnr It's not working because I don't have permission... haha, Please roll it up.
@ShoyuVanilla
ShoyuVanilla
commented
Mar 15, 2026

Copy link


Copy Markdown

Member
Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅
after that r=me
@bors r=lcnr
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit e09936e has been approved by lcnr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 15, 2026
@rust-bors
rust-borsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: lcnr

Duration: 3h 13m 55s

Pushing 1e21831 to main...
@rust-bors
rust-borsBot
merged commit 1e21831
into
rust-lang:mainMar 15, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 15, 2026
@github-actions
github-actionsBot
commented
Mar 15, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
  2. aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
  3. dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
  4. x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
  5. x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
  6. dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
  7. x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
  8. dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
  9. dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
  10. aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 16, 2026
 Merged

@rust-timer
rust-timer
commented
Mar 16, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (1e21831): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.9%[0.1%, 1.8%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -3.5%, secondary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-3.5%[-3.5%, -3.5%]1
Improvements ✅ 
 (secondary)		-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-3.5%[-3.5%, -3.5%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)--0
Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)
@reddevilmidzy
reddevilmidzy
deleted the

codegen-tidy

branch
March 16, 2026 00:36
bjorn3 pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 25, 2026
@bors
Auto merge ofrust-lang#153166- reddevilmidzy:codegen-tidy, r=lcnr
6b8bdc9
Tidy: disallow TODO in other in-tree projects
Fixes: rust-lang#152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of#153166- reddevilmidzy:codegen-tidy, r=lcnr
f2aa873
Tidy: disallow TODO in other in-tree projects
Fixes: #152280
MCP: rust-lang/compiler-team#963
TODO
* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861
r? lcnr
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoyoantoyoantoyo left review comments
@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 963: Extend the  x.py policy for TODO and FIXME to other in-tree projects


9 participants

@reddevilmidzy@rustbot@bjorn3@jieyouxu@rust-log-analyzer@ShoyuVanilla@rust-timer@antoyo@lcnr