Rollup of 5 pull requests - #153284

Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-oug6DDR
Closed

Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-oug6DDR

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

WaffleLapkinand others added 19 commits February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Mar 2, 2026
@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Mar 2, 2026
@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 299e863 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors cancel
Spurious failure, retry

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Auto build cancelled. Cancelled workflows:

The next pull request likely to be tested is #153284.

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors treeclosed=1000
Github is having a moment

Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
Error: Process completed with exit code 1.

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Tree closed for PRs with priority less than 1000.

@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2026
@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c915789 failed: CI. Failed job:

@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors p=1000
@bors retry
One more try, maybe we're just getting unlucky

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer

rust-log-analyzer commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot mentioned this pull request Mar 2, 2026
Merged
@rust-log-analyzer

rust-log-analyzer commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors treeopen
Seems to be fixed

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Tree is now open for merging.

@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2026
@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 3b50732 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 2, 2026
Merged
@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

PR #152164, which is a member of this rollup, was unapproved.
This rollup was thus also unapproved.

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer deleted the rollup-oug6DDR branch August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rollup of 5 pull requests - #153284
Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Closed
Rollup of 5 pull requests#153284
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-oug6DDR
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
WaffleLapkinand others
added 19 commits
February 27, 2026 17:16
@WaffleLapkin
add more tests for unused_results lints
d351448
@WaffleLapkin
don't emit unused_results lint for tuples of trivial types
8958cb9
@mu001999
Report unused features
7f3bbe3
@mu001999
Add tests for unused-features
28b6bcb
@mu001999
Remove unused features in compiler
d0a182f
@mu001999
Allow unused features in tools
60f457a
@nnethercote
Make non-queries available to rustc_with_all_queries.
253c696
`rustc_with_all_queries` currently provides information about all
queries. Also, a caller can provide an ad hoc list of extra non-queries.
This is used by `define_queries` for non-query dep kinds: `Null`, `Red`,
etc. This is pretty hacky.
This commit changes `rustc_with_all_queries` so that the non-queries
information is available to all callers. (Some callers ignore the
non-query information.) This is done by adding `non_query` entries to
the primary list of queries in `rustc_queries!`.
@nnethercote
Change how query vtables are constructed.
40b2274
Currently `define_dep_nodes` produces a macro `make_dep_kind_array` that
encodes the names of non-queries followed by queries. This macro is used
by `make_dep_kind_vtables` to make the full array of vtables, by
referring to vtable constructor functions that are put into `mod
_dep_kind_vtable_ctors`. Pretty weird!
This commit takes advantage of the previous commit's changes to
`rustc_with_all_queries`, which makes both query and non-query
information available. A new call to `rustc_with_all_queries` is used to
construct the vtable array. (This moves some dep_kind_vtable code from
`plumbing.rs` to `dep_kind_vtables.rs`, which is good.) It's
straightforward now with iterator chaining, and `mod
_dep_kind_vtable_ctors` is no longer needed.
@DanielEScherzer
vec/mod.rs: add missing period in "ie." in docs
f538526
"i.e." is short for the Latin "id est" and thus both letters should be followed
by periods.
@mu001999
Remove unused features in library tests
2672810
@mu001999
Remove unused features in tests
b4b3057
@TaKO8Ki
fix next-solver ICE on PointeeSized goals
66786fc
@TaKO8Ki
replace issue number with link
6cda9bf
@TaKO8Ki
simplify test case and add revisions for both solvers
ca74063
remove *
@JonathanBrouwer
Rollup merge ofrust-lang#151962- TaKO8Ki:pointee-sized-next-solver-…
3d91c3e
…ice, r=lcnr
Fix next-solver ICE on PointeeSized goals
Fixesrust-lang#151957
@JonathanBrouwer
Rollup merge ofrust-lang#153161- nnethercote:rejig-rustc_with_all_q…
41d8026
…ueries, r=Zalathar
Rejig `rustc_with_all_queries!`
There are three things relating to `rustc_with_all_queries!` that have been bugging me.
- `rustc_with_all_queries!`'s ability to receive `extra_fake_queries` lines like `[] fn Null(()) -> (),` where the only real thing is the `Null`, and everything is just pretending to be a normal query, ugh.
- `make_dep_kind_array!`: a macro produced by one macro (`define_dep_nodes!`) and used by another macro (`define_queries!`) in another crate, ugh.
- The `_dep_kind_vtable_ctors` module, which is a special module with no actual code that serves just a way of collecting vtable constructors from two different places so they can be referred to by `make_dep_kind_array!`, ugh.
By making some adjustments to how `rustc_with_all_queries!` works, all three of these things are eliminated.
r? @Zalathar
@JonathanBrouwer
Rollup merge ofrust-lang#152164- mu001999-contrib:lint/unused_featu…
0972842
…res, r=JonathanBrouwer
Lint unused features
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152164)*Fixesrust-lang#44232Fixesrust-lang#151752
---
This PR records used features through query side effect, then reports unsued features finally.
@JonathanBrouwer
Rollup merge ofrust-lang#153191- WaffleLapkin:shouldnt_use_trivial_…
7268260
…tuples, r=jdonszelmann
don't emit `unused_results` lint for tuples of "trivial" types
r? @jdonszelmannFixesrust-lang#153144.
So it turns out rust-lang#153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
```rust
((), ());
((), 1);
```
Neither of them is `must_use`, so they are potential candidates for `unused_results`. So the question is whatever said tuples are considered "trivial" and thus if they end up emitting `unused_results` or not.
Here is a comparison table between PRs:
<table>
<tr><td>stable</td><td>After rust-lang#153018</td><td>After this PR</td></tr><tr><td>
```rust
((), ()); // trivial
((), 1); // trivial
```
</td>
<td>
```rust
((), ()); //~ warn: unused_results
((), 1); //~ warn: unused_results
```
</td>
<td>
```rust
((), ()); // trivial
((), 1); //~ warn: unused_results
```
</td>
</tr>
<tr>
<td>
tuples are trivial if **any** of their fields are trivial
</td>
<td>
tuples are never trivial
</td>
<td>
tuples are trivial if **all** of their fields are trivial
</td>
</tr>
</table>
@JonathanBrouwer
Rollup merge ofrust-lang#153273- DanielEScherzer:patch-2, r=joboet
299e863
vec/mod.rs: add missing period in "ie." in docs
"i.e." is short for the Latin "id est" and thus both letters should be followed by periods.
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rust-analyzer
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 299e863 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors cancel

Spurious failure, retry
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Auto build cancelled. Cancelled workflows:
The next pull request likely to be tested is #153284.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
c915789
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeclosed=1000

Github is having a moment
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

Error: Process completed with exit code 1.
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for c915789 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors p=1000
@bors retry

One more try, maybe we're just getting unlucky
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153284- JonathanBrouwer:rollup-oug6DDR, r=JonathanBro…
3b50732
…uwer
Rollup of 5 pull requests
Successful merges:
- #151962 (Fix next-solver ICE on PointeeSized goals)
- #153161 (Rejig `rustc_with_all_queries!`)
- #152164 (Lint unused features)
- #153191 ( don't emit `unused_results` lint for tuples of "trivial" types )
- #153273 (vec/mod.rs: add missing period in "ie." in docs)
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917476KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-borsrust-borsBot
mentioned this pull request
Mar 2, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917436KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 203092c6aebed82e775aff2ebe82065eeffb2ea349cafdefe7de70e1a10904ca2435e0408efee278c4ea17bbde3b9fd48626e2faf711a570da6a45dacbbce890
##[group]Building docker image for armhf-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors treeopen

Seems to be fixed
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 3b50732 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
The job arm-android failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (94917440KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
test [ui] tests/ui/abi/abi-sysv64-arg-passing.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is arm
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/array-slice-vec/vector-no-ann-2.rs ... ok
test [ui] tests/ui/asm/aarch64/arm64ec-sve.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/array-slice-vec/vector-slice-matching-8498.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/binary_asm_labels_allowed.rs ... ignored, only executed when the architecture is aarch64
test [ui] tests/ui/asm/cfg-parse-error.rs ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-qualified-paths.rs ... ok
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle-2.rs ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/null-pointer-optimization-sizes.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
---
To only update this specific test, also pass `--test-args threads-sendsync/thread-local-extern-static.rs`
error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-linux-androideabi" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/arm-linux-androideabi/native/rust-test-helpers" "-Clinker=/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/threads-sendsync/thread-local-extern-static/auxiliary"
stdout: none
--- stderr -------------------------------
warning: feature `thread_local` is declared but not used
##[warning] --> /checkout/tests/ui/threads-sendsync/thread-local-extern-static.rs:5:37
|

@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Mar 2, 2026
 Merged

@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
PR #152164, which is a member of this rollup, was unapproved.

This rollup was thus also unapproved.
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-oug6DDR

branch
August 21, 2026 08:27
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)PG-exploit-mitigationsProject group: Exploit mitigationsrollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@WaffleLapkin@mu001999@nnethercote@DanielEScherzer@TaKO8Ki