Skip to content

Update call-llvm-intrinsics test for Rust 1.94.0 IR - #153285

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
DeepeshWR:codegen-llvm-sqrt-call-1.94
Mar 3, 2026
Merged

Update call-llvm-intrinsics test for Rust 1.94.0 IR#153285
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
DeepeshWR:codegen-llvm-sqrt-call-1.94

Conversation

@DeepeshWR

@DeepeshWRDeepeshWR commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Rust 1.94 now passes constants directly to llvm.sqrt.f32 instead of
storing/loading via the stack.

  • Updated the FileCheck pattern to match the new IR:
    // CHECK: call float @llvm.sqrt.f32(float 4.000000e+00)
    The test intent is unchanged: it still ensures the intrinsic is
    emitted as a 'call' (not 'invoke').

  • Removed unnecessary local variables and Drop usage to work in
    #![no_core] mode with minicore.

  • Added required crate attributes:
    #![feature(no_core, lang_items)]
    #![no_std]
    #![no_core]

  • Replaced //@ only-riscv64 (host-based execution) with explicit
    revisions for:
    riscv32gc-unknown-linux-gnu
    riscv64gc-unknown-linux-gnu
    This ensures deterministic multi-target coverage in CI without
    relying on the host architecture.

  • Added //@ needs-llvm-components: riscv and
    //@ min-llvm-version: 21 for CI compatibility.

Fixes#153271

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot

rustbot commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@rustbot

This comment has been minimized.

Sign in to view
folkertdev
folkertdev reviewed Mar 2, 2026
View reviewed changes
Comment threadtests/codegen-llvm/riscv-abi/call-llvm-intrinsics.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@DeepeshWR
DeepeshWRforce-pushed the codegen-llvm-sqrt-call-1.94 branch from f51e581 to dee56f5CompareMarch 2, 2026 12:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@DeepeshWR
DeepeshWRforce-pushed the codegen-llvm-sqrt-call-1.94 branch from dee56f5 to 5bb4a0aCompareMarch 2, 2026 13:22
folkertdev
folkertdev reviewed Mar 2, 2026
View reviewed changes
Comment threadtests/codegen-llvm/riscv-abi/call-llvm-intrinsics.rs
@jieyouxu

jieyouxu commented Mar 2, 2026

Copy link
Copy Markdown
Member

r? folkertdev

@rustbotrustbot assigned folkertdev and unassigned jieyouxuMar 2, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@DeepeshWR
DeepeshWRforce-pushed the codegen-llvm-sqrt-call-1.94 branch from 5bb4a0a to 04715b7CompareMarch 2, 2026 14:43
nikic
nikic reviewed Mar 2, 2026
View reviewed changes
Comment threadtests/codegen-llvm/riscv-abi/call-llvm-intrinsics.rs Outdated
@DeepeshWR
Update call-llvm-intrinsics test for Rust 1.94.0 IR and multi-target CI
1d678f6
Rust 1.94 now passes constants directly to llvm.sqrt.f32 instead of
storing/loading via the stack.
- Updated the FileCheck pattern to match the new IR:
// CHECK: call float @llvm.sqrt.f32(float 4.000000e+00)
The test intent is unchanged: it still ensures the intrinsic is
emitted as a 'call' (not 'invoke').
- Removed unnecessary local variables and Drop usage to work in
`#![no_core]` mode with minicore.
- Added required crate attributes:
#![feature(no_core, lang_items)]
#![no_std]
#![no_core]
- Replaced `//@ only-riscv64` (host-based execution) with explicit
revisions for:
riscv32gc-unknown-linux-gnu
riscv64gc-unknown-linux-gnu
This ensures deterministic multi-target coverage in CI without
relying on the host architecture.
- Added `//@ needs-llvm-components: riscv` and
`//@ min-llvm-version: 21` for CI compatibility.
Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com>
@DeepeshWR
DeepeshWRforce-pushed the codegen-llvm-sqrt-call-1.94 branch from 04715b7 to 1d678f6CompareMarch 3, 2026 02:55
@folkertdev

folkertdev commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Great, thanks!

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1d678f6 has been approved by folkertdev

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153285- DeepeshWR:codegen-llvm-sqrt-call-1…
05be901
….94, r=folkertdev
Update call-llvm-intrinsics test for Rust 1.94.0 IR
Rust 1.94 now passes constants directly to llvm.sqrt.f32 instead of
storing/loading via the stack.
- Updated the FileCheck pattern to match the new IR:
// CHECK: call float @llvm.sqrt.f32(float 4.000000e+00)
The test intent is unchanged: it still ensures the intrinsic is
emitted as a 'call' (not 'invoke').
- Removed unnecessary local variables and Drop usage to work in
`#![no_core]` mode with minicore.
- Added required crate attributes:
#![feature(no_core, lang_items)]
#![no_std]
#![no_core]
- Replaced `//@ only-riscv64` (host-based execution) with explicit
revisions for:
riscv32gc-unknown-linux-gnu
riscv64gc-unknown-linux-gnu
This ensures deterministic multi-target coverage in CI without
relying on the host architecture.
- Added `//@ needs-llvm-components: riscv` and
`//@ min-llvm-version: 21` for CI compatibility.
Fixesrust-lang#153271
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 3, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153285- DeepeshWR:codegen-llvm-sqrt-call-1…
b67a704
….94, r=folkertdev
Update call-llvm-intrinsics test for Rust 1.94.0 IR
Rust 1.94 now passes constants directly to llvm.sqrt.f32 instead of
storing/loading via the stack.
- Updated the FileCheck pattern to match the new IR:
// CHECK: call float @llvm.sqrt.f32(float 4.000000e+00)
The test intent is unchanged: it still ensures the intrinsic is
emitted as a 'call' (not 'invoke').
- Removed unnecessary local variables and Drop usage to work in
`#![no_core]` mode with minicore.
- Added required crate attributes:
#![feature(no_core, lang_items)]
#![no_std]
#![no_core]
- Replaced `//@ only-riscv64` (host-based execution) with explicit
revisions for:
riscv32gc-unknown-linux-gnu
riscv64gc-unknown-linux-gnu
This ensures deterministic multi-target coverage in CI without
relying on the host architecture.
- Added `//@ needs-llvm-components: riscv` and
`//@ min-llvm-version: 21` for CI compatibility.
Fixesrust-lang#153271
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 3, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of#153342- JonathanBrouwer:rollup-cP1DV54, r=JonathanBro…
e1e7038
…uwer
Rollup of 3 pull requests
Successful merges:
- #153336 (stdarch subtree update)
- #153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- #153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 3, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of#153344- JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
d2218f5
…uwer
Rollup of 6 pull requests
Successful merges:
- #153336 (stdarch subtree update)
- #152943 (Parse `impl` restrictions)
- #153184 (Replace CodegenResults with CompiledModules)
- #153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- #153319 (Comments and docs: add missing periods to "ie.")
- #153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
@rust-bors
rust-borsBot merged commit 0ce5963 into rust-lang:mainMar 3, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 3, 2026
rust-timer added a commit that referenced this pull request Mar 3, 2026
@rust-timer
Unrolled build for#153285
ce441a3
Rollup merge of #153285 - DeepeshWR:codegen-llvm-sqrt-call-1.94, r=folkertdev
Update call-llvm-intrinsics test for Rust 1.94.0 IR
Rust 1.94 now passes constants directly to llvm.sqrt.f32 instead of
storing/loading via the stack.
- Updated the FileCheck pattern to match the new IR:
// CHECK: call float @llvm.sqrt.f32(float 4.000000e+00)
The test intent is unchanged: it still ensures the intrinsic is
emitted as a 'call' (not 'invoke').
- Removed unnecessary local variables and Drop usage to work in
`#![no_core]` mode with minicore.
- Added required crate attributes:
#![feature(no_core, lang_items)]
#![no_std]
#![no_core]
- Replaced `//@ only-riscv64` (host-based execution) with explicit
revisions for:
riscv32gc-unknown-linux-gnu
riscv64gc-unknown-linux-gnu
This ensures deterministic multi-target coverage in CI without
relying on the host architecture.
- Added `//@ needs-llvm-components: riscv` and
`//@ min-llvm-version: 21` for CI compatibility.
Fixes#153271
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 4, 2026
@bors
Auto merge of #153344 - JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
2989eb7
…uwer
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#153336 (stdarch subtree update)
- rust-lang/rust#152943 (Parse `impl` restrictions)
- rust-lang/rust#153184 (Replace CodegenResults with CompiledModules)
- rust-lang/rust#153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- rust-lang/rust#153319 (Comments and docs: add missing periods to "ie.")
- rust-lang/rust#153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Mar 5, 2026
@bors
Auto merge of #153344 - JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
4a58b1e
…uwer
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#153336 (stdarch subtree update)
- rust-lang/rust#152943 (Parse `impl` restrictions)
- rust-lang/rust#153184 (Replace CodegenResults with CompiledModules)
- rust-lang/rust#153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- rust-lang/rust#153319 (Comments and docs: add missing periods to "ie.")
- rust-lang/rust#153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
github-actionsBot pushed a commit to rust-lang/stdarch that referenced this pull request Mar 9, 2026
@bors
Auto merge of #153344 - JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
d49f762
…uwer
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#153336 (stdarch subtree update)
- rust-lang/rust#152943 (Parse `impl` restrictions)
- rust-lang/rust#153184 (Replace CodegenResults with CompiledModules)
- rust-lang/rust#153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- rust-lang/rust#153319 (Comments and docs: add missing periods to "ie.")
- rust-lang/rust#153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
@bors
Auto merge of #153344 - JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
38b480e
…uwer
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#153336 (stdarch subtree update)
- rust-lang/rust#152943 (Parse `impl` restrictions)
- rust-lang/rust#153184 (Replace CodegenResults with CompiledModules)
- rust-lang/rust#153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- rust-lang/rust#153319 (Comments and docs: add missing periods to "ie.")
- rust-lang/rust#153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #153344 - JonathanBrouwer:rollup-uL4XlqI, r=JonathanBro…
b89e4ce
…uwer
Rollup of 6 pull requests
Successful merges:
- rust-lang/rust#153336 (stdarch subtree update)
- rust-lang/rust#152943 (Parse `impl` restrictions)
- rust-lang/rust#153184 (Replace CodegenResults with CompiledModules)
- rust-lang/rust#153285 (Update call-llvm-intrinsics test for Rust 1.94.0 IR)
- rust-lang/rust#153319 (Comments and docs: add missing periods to "ie.")
- rust-lang/rust#153326 (Make `rustc_with_all_queries!` pass query modifiers as named values)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikicnikicnikic left review comments
@folkertdevfolkertdevfolkertdev left review comments

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Regression in codegen-llvm test riscv-abi/call-llvm-intrinsics.rs on riscv64 since 1.94-beta

6 participants

@DeepeshWR@rustbot@rust-log-analyzer@jieyouxu@folkertdev@nikic