Fix bootstrap rust build failure for vxworks by gautam899 · Pull Request #153333 · rust-lang/rust

gautam899 · 2026-03-03T07:44:53Z

Starting with VxWorks 25.09, struct stat was updated to use struct timespec instead of time_t for timestamp fields.

The following changes were made in libc in the commit libc.

As a result, when performing a bootstrap build with VxWorks ≥ 25.09, libc no longer exposes the fields st_mtime, st_atime, and st_ctime, as they are conditionally compiled in src/vxworks/mod.rs here libc. This causes the build to fail.

For VxWorks versions earlier than 25.09, the build completes successfully without errors.

This PR resolves the issue by detecting the WIND_RELEASE_ID environment variable (which is set in the VxWorks build environment) and conditionally guarding the affected functions in the two additional files where the errors originate.

rustbot · 2026-03-03T07:44:58Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, joboet

gautam899 · 2026-03-03T08:02:50Z

ping @biabbas

Mark-Simulacrum · 2026-03-09T00:05:30Z

Can you add documentation for the environment variable to https://doc.rust-lang.org/nightly/rustc/platform-support/vxworks.html?

cc rust-lang/rfcs#3750 as well, which seems like the long term solution here

gautam899 · 2026-03-10T07:43:02Z

Can you add documentation for the environment variable to https://doc.rust-lang.org/nightly/rustc/platform-support/vxworks.html?
cc rust-lang/rfcs#3750 as well, which seems like the long term solution here

Hi @Mark-Simulacrum, I don't think there is a need to add documentation about the environment variable since this is set by vxworks workbench itself. The user is not required to set this environment variable from their end.

gautam899 · 2026-03-10T07:50:22Z

@rustbot ready

tgross35 · 2026-03-13T20:22:29Z

Hi @Mark-Simulacrum, I don't think there is a need to add documentation about the environment variable since this is set by vxworks workbench itself. The user is not required to set this environment variable from their end.

It would be useful to have documented that it reads this env, even if it isn't meant to be set, since this is pretty uncommon.

gautam899 · 2026-03-14T08:02:10Z

Hi @Mark-Simulacrum, I don't think there is a need to add documentation about the environment variable since this is set by vxworks workbench itself. The user is not required to set this environment variable from their end.
It would be useful to have documented that it reads this env, even if it isn't meant to be set, since this is pretty uncommon.

Cool. I'll go ahead and add some info about the environment variable.

rustbot · 2026-03-14T12:25:13Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

rustbot · 2026-03-14T12:25:16Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

gautam899 · 2026-03-14T12:28:33Z

Hi @Mark-Simulacrum @tgross35 , I have added the documentation for the environment variable WIND_RELEASE_ID. Pls let me know if it would suffice.

gautam899 · 2026-03-18T04:27:53Z

ping @Mark-Simulacrum @Noratrieb

Mark-Simulacrum · 2026-03-19T02:35:32Z

@bors r+

There's generally speaking no need to re-ping folks so aggressively. Reviews can and do take a week+ normally; this PR hasn't been open for that long, and the latest changes were made less than a week ago. Please be patient in the future :)

rust-bors · 2026-03-19T02:35:36Z

📌 Commit 24d86b5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

gautam899 · 2026-03-19T05:07:33Z

@bors r+
There's generally speaking no need to re-ping folks so aggressively. Reviews can and do take a week+ normally; this PR hasn't been open for that long, and the latest changes were made less than a week ago. Please be patient in the future :)

Apologies. I'll take care of that in the future.

Fix bootstrap rust build failure for vxworks Fixesrust-lang#153332 Starting with VxWorks 25.09, struct stat was updated to use struct timespec instead of time_t for timestamp fields. The following changes were made in libc in the commit [libc](rust-lang/libc#4781). As a result, when performing a bootstrap build with VxWorks ≥ 25.09, libc no longer exposes the fields st_mtime, st_atime, and st_ctime, as they are conditionally compiled in src/vxworks/mod.rs here [libc](https://github.com/rust-lang/libc/blob/56caa81b6b433c49c5704bf0400a02d428cfacda/src/vxworks/mod.rs#L229). This causes the build to fail. For VxWorks versions earlier than 25.09, the build completes successfully without errors. This PR resolves the issue by detecting the WIND_RELEASE_ID environment variable (which is set in the VxWorks build environment) and conditionally guarding the affected functions in the two additional files where the errors originate.

…uwer Rollup of 12 pull requests Successful merges: - #152870 (Do not enable split debuginfo for windows-gnu) - #153333 (Fix bootstrap rust build failure for vxworks) - #153681 (ci: add runners for vanilla LLVM 22) - #153824 (Add `Wake` diagnostic item for `alloc::task::Wake`) - #154077 (Optimize 128-bit integer formatting) - #154078 (`define_callbacks` tweaks) - #151905 (Split the `dec2flt::RawFloat` trait for easier reuse) - #153170 (Add is_disconnected functions to mpsc and mpmc channels) - #153804 (Derive Macro Eq: link to more detailed documentation) - #153974 (Point at return type when it is the source of the type expectation) - #154018 (simplify and remove `tests/ui/kindck` and related tests) - #154041 (bootstrap: Allow `--bless`ing changes to editor settings files)

Fix bootstrap rust build failure for vxworks Fixesrust-lang#153332 Starting with VxWorks 25.09, struct stat was updated to use struct timespec instead of time_t for timestamp fields. The following changes were made in libc in the commit [libc](rust-lang/libc#4781). As a result, when performing a bootstrap build with VxWorks ≥ 25.09, libc no longer exposes the fields st_mtime, st_atime, and st_ctime, as they are conditionally compiled in src/vxworks/mod.rs here [libc](https://github.com/rust-lang/libc/blob/56caa81b6b433c49c5704bf0400a02d428cfacda/src/vxworks/mod.rs#L229). This causes the build to fail. For VxWorks versions earlier than 25.09, the build completes successfully without errors. This PR resolves the issue by detecting the WIND_RELEASE_ID environment variable (which is set in the VxWorks build environment) and conditionally guarding the affected functions in the two additional files where the errors originate.

…uwer Rollup of 19 pull requests Successful merges: - #152870 (Do not enable split debuginfo for windows-gnu) - #153333 (Fix bootstrap rust build failure for vxworks) - #153681 (ci: add runners for vanilla LLVM 22) - #153727 (When single impl can satisfy inference error, suggest type) - #153824 (Add `Wake` diagnostic item for `alloc::task::Wake`) - #154077 (Optimize 128-bit integer formatting) - #154078 (`define_callbacks` tweaks) - #151905 (Split the `dec2flt::RawFloat` trait for easier reuse) - #153170 (Add is_disconnected functions to mpsc and mpmc channels) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153804 (Derive Macro Eq: link to more detailed documentation) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153974 (Point at return type when it is the source of the type expectation) - #153987 (mGCA: Lower const generic args to infer when needed) - #154018 (simplify and remove `tests/ui/kindck` and related tests) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file) - #154041 (bootstrap: Allow `--bless`ing changes to editor settings files)

rustbot assigned Mark-Simulacrum Mar 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2026

This comment has been minimized.
Sign in to view

gautam899 force-pushed the main branch from cd1ab2f to 0ecb8fbCompare March 3, 2026 08:08

This comment has been minimized.
Sign in to view

gautam899 force-pushed the main branch from 0ecb8fb to e21d000Compare March 3, 2026 08:34

biabbas approved these changes Mar 5, 2026
View reviewed changes

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026

gautam899 force-pushed the main branch from e21d000 to de5eb79Compare March 9, 2026 04:27

This comment has been minimized.
Sign in to view

gautam899 force-pushed the main branch from de5eb79 to 181bc6fCompare March 10, 2026 07:40

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2026

Fix rust build failure for vxworks
24d86b5

gautam899 force-pushed the main branch from 181bc6f to 24d86b5Compare March 14, 2026 12:25

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026

Zalathar mentioned this pull request Mar 19, 2026
Rollup of 20 pull requests #154079
Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026
Rollup of 20 pull requests #154080
Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026
Rollup of 12 pull requests #154083
Closed

This was referenced Mar 19, 2026
Rollup of 20 pull requests #154091
Closed
Rollup of 19 pull requests #154092
Merged

rust-borsBot merged commit 2c49023 into rust-lang:mainMar 19, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 19, 2026

Uh oh!

Uh oh!

Conversation

gautam899 commented Mar 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 3, 2026

Uh oh!

This comment has been minimized.

gautam899 commented Mar 3, 2026

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Mar 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

gautam899 commented Mar 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gautam899 commented Mar 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Mar 13, 2026

Uh oh!

gautam899 commented Mar 14, 2026

Uh oh!

rustbot commented Mar 14, 2026

Uh oh!

rustbot commented Mar 14, 2026

Uh oh!

gautam899 commented Mar 14, 2026

Uh oh!

gautam899 commented Mar 18, 2026

Uh oh!

Mark-Simulacrum commented Mar 19, 2026

Uh oh!

rust-borsBot commented Mar 19, 2026

Uh oh!

gautam899 commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gautam899 commented Mar 3, 2026•
edited
Loading

gautam899 commented Mar 10, 2026•
edited
Loading

gautam899 commented Mar 10, 2026•
edited
Loading