Skip to content

move never type tests to subdirectories and add some comments - #153346

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
WaffleLapkin:sometimes-test
Mar 7, 2026
Merged

move never type tests to subdirectories and add some comments#153346
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
WaffleLapkin:sometimes-test

Conversation

@WaffleLapkin

@WaffleLapkinWaffleLapkin commented Mar 3, 2026

Copy link
Copy Markdown
Member

This hopefully makes things a little bit clearer

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2026
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 3, 2026
@rustbot

rustbot commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu

jieyouxu commented Mar 4, 2026

Copy link
Copy Markdown
Member

r? me

@rustbotrustbot assigned jieyouxu and unassigned petrochenkovMar 4, 2026
jieyouxu
jieyouxu reviewed Mar 4, 2026
View reviewed changes

@jieyouxujieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good, though you'll need to rebless the issues.txt list or give the regress/issue-*.rs ones more descriptive test names.

@rustbot author

View changes since this review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2026
@rustbotrustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 4, 2026
WaffleLapkin
WaffleLapkin commented Mar 4, 2026
View reviewed changes
Comment threadtests/ui/never_type/regress/issue-44402.rs Outdated

@WaffleLapkinWaffleLapkinMar 4, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no way to make this test actually test something interesting. it used to test the cycle detection in inhabitedness check, but since we no longer follow references for it, there is no way to get a cycle without causing the type to be infinitely sized.

@jieyouxujieyouxuMar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backlink to original issue: #44402

@WaffleLapkin

WaffleLapkin commented Mar 4, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026
jieyouxu
jieyouxu approved these changes Mar 4, 2026
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@bors r+ rollup

View changes since this review

@rust-bors

This comment was marked as outdated.

Sign in to view
@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2026
@jieyouxu

jieyouxu commented Mar 4, 2026

Copy link
Copy Markdown
Member

Actually just to avoid easy oopsie, r=me after PR CI is green :D
@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Mar 6, 2026
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this one problem, you can r=me after
@rustbot author

View changes since this review

Comment threadtests/ui/parser/return-without-semicolon-in-match.rs Outdated
Comment threadtests/ui/parser/return-without-semicolon-in-match.rs Outdated
@WaffleLapkin

WaffleLapkin commented Mar 6, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 05174fb has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 7, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 7, 2026
@bors
Auto merge of#153519- JonathanBrouwer:rollup-Soq8THm, r=JonathanBro…
ea5573a
…uwer
Rollup of 5 pull requests
Successful merges:
- #149937 (spliit out `linker-info` from `linker-messages`)
- #153503 (Fallback to fat LTO for -Clto=thin in cg_gcc)
- #153346 (move never type tests to subdirectories and add some comments)
- #153371 (Fix LegacyKeyValueFormat report from docker build: arm)
- #153508 (Clean up the eager formatting API)
@rust-bors
rust-borsBot merged commit cecc5e7 into rust-lang:mainMar 7, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 7, 2026
rust-timer added a commit that referenced this pull request Mar 7, 2026
@rust-timer
Unrolled build for#153346
cb9990b
Rollup merge of #153346 - WaffleLapkin:sometimes-test, r=jieyouxu
move never type tests to subdirectories and add some comments
This hopefully makes things a little bit clearer
@WaffleLapkin
WaffleLapkin deleted the sometimes-test branch March 9, 2026 10:35
jyn514 added a commit to ferrocene/ferrocene that referenced this pull request Mar 13, 2026
@jyn514
Fix merge conflicts
ac8f6d7
 ## tests
- 44402 was removed, see rust-lang/rust#153346 (comment)
- 2149 was removed, Waffle said to me "everything is different since the test was written and the test is now nonsensical"
- other test annotations are moved to their proper replacement test
## compiler
- adapt to new lint API
## libcore
- fix `subset` cfgs
## bootstrap
- merge new flags and ferrocene flags
- apply Johann's patch for the `--no-doc` change
## upstream-pull-basic-checks
- adapt `--no-doc` to `--tests`
- move tests into "normal" test instead of "extended"
jyn514 added a commit to ferrocene/ferrocene that referenced this pull request Mar 13, 2026
@jyn514
Fix merge conflicts
c66a8a3
 ## tests
- 44402 was removed, see rust-lang/rust#153346 (comment)
- 2149 was removed, Waffle said to me "everything is different since the test was written and the test is now nonsensical"
- other test annotations are moved to their proper replacement test
## compiler
- adapt to new lint API
## libcore
- fix `subset` cfgs
## bootstrap
- merge new flags and ferrocene flags
- apply Johann's patch for the `--no-doc` change
## upstream-pull-basic-checks
- adapt `--no-doc` to `--tests`
- move tests into "normal" test instead of "extended"
jyn514 added a commit to ferrocene/ferrocene that referenced this pull request Mar 13, 2026
@jyn514
Fix merge conflicts
d822cf3
 ## tests
- 44402 was removed, see rust-lang/rust#153346 (comment)
- 2149 was removed, Waffle said to me "everything is different since the test was written and the test is now nonsensical"
- other test annotations are moved to their proper replacement test
## compiler
- adapt to new lint API
## libcore
- fix `subset` cfgs
## bootstrap
- merge new flags and ferrocene flags
- apply Johann's patch for the `--no-doc` change
## upstream-pull-basic-checks
- adapt `--no-doc` to `--tests`
- move tests into "normal" test instead of "extended"
jyn514 added a commit to ferrocene/ferrocene that referenced this pull request Mar 13, 2026
@jyn514
Fix merge conflicts
7170f4b
 ## tests
- 44402 was removed, see rust-lang/rust#153346 (comment)
- 2149 was removed, Waffle said to me "everything is different since the test was written and the test is now nonsensical"
- other test annotations are moved to their proper replacement test
## compiler
- adapt to new lint API
## libcore
- fix `subset` cfgs
## bootstrap
- merge new flags and ferrocene flags
- apply Johann's patch for the `--no-doc` change
## upstream-pull-basic-checks
- adapt `--no-doc` to `--tests`
- move tests into "normal" test instead of "extended"
@WaffleLapkinWaffleLapkin added the F-never_type `#![feature(never_type)]` label May 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-tidyArea: The tidy toolF-never_type`#![feature(never_type)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@WaffleLapkin@rustbot@rust-log-analyzer@jieyouxu@petrochenkov