Move `Spanned`. by nnethercote · Pull Request #153641 · rust-lang/rust

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

nnethercote · 2026-03-10T06:09:16Z

It's defined in rustc_span::source_map which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

r? @JonathanBrouwer

rustbot · 2026-03-10T06:09:20Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T07:41:50Z

📌 Commit 1b85b55 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 13 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153471 (Refactor `ActiveJobGuard`) - #153595 (`QueryLatch` cleanups) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153479 (Add rationale for intentional potential_query_instability allows) - #153600 (add test for proc-macros with custom panic payloads) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups) - #153659 (Mark an unreachable match arm as such)

JonathanBrouwer · 2026-03-10T18:45:13Z

@bors r-
#153665 (comment)

rust-bors · 2026-03-10T18:45:20Z

This pull request was unapproved.

This PR was contained in a rollup (#153665), which was unapproved.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

rustbot · 2026-03-10T19:25:35Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

nnethercote · 2026-03-10T19:27:31Z

@rustbot ready

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-10T20:47:53Z

📌 Commit c12ab08 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #153560 (Introduce granular tidy_ctx's check in extra_checks) - #153666 (Add a regression test for #153599) - #153493 (Remove `FromCycleError` trait) - #153549 (tests/ui/binop: add annotations for reference rules) - #153641 (Move `Spanned`.) - #153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - #153664 (Add test for #109804)

@JonathanBrouwer

Rollup merge of #153641 - nnethercote:mv-Spanned, r=JonathanBrouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#153560 (Introduce granular tidy_ctx's check in extra_checks) - rust-lang/rust#153666 (Add a regression test for rust-lang/rust#153599) - rust-lang/rust#153493 (Remove `FromCycleError` trait) - rust-lang/rust#153549 (tests/ui/binop: add annotations for reference rules) - rust-lang/rust#153641 (Move `Spanned`.) - rust-lang/rust#153663 (Remove `TyCtxt::node_lint` method and `rustc_middle::lint_level` function) - rust-lang/rust#153664 (Add test for rust-lang/rust#109804)

rustbot assigned JonathanBrouwer Mar 10, 2026

JonathanBrouwer approved these changes Mar 10, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

JonathanBrouwer mentioned this pull request Mar 10, 2026
Rollup of 4 pull requests #153654
Closed

JonathanBrouwer mentioned this pull request Mar 10, 2026
Rollup of 8 pull requests #153658
Closed

JonathanBrouwer mentioned this pull request Mar 10, 2026
Rollup of 13 pull requests #153665
Closed

JonathanBrouwer reviewed Mar 10, 2026
View reviewed changes

Comment threadcompiler/rustc_middle/src/dep_graph/graph.rs Outdated

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

Move Spanned.
c12ab08
It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

nnethercote force-pushed the mv-Spanned branch from 1b85b55 to c12ab08Compare March 10, 2026 19:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2026

JonathanBrouwer approved these changes Mar 10, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

This was referenced Mar 10, 2026
Rollup of 5 pull requests #153670
Closed
Rollup of 7 pull requests #153673
Merged

rust-borsBot merged commit 4af0d15 into rust-lang:mainMar 11, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 11, 2026

nnethercote deleted the mv-Spanned branch March 11, 2026 09:56