Skip to content

Tweak wording of failed predicate in inference error - #153967

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:infer_must_implement
Mar 17, 2026
Merged

Tweak wording of failed predicate in inference error#153967
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:infer_must_implement

Conversation

@estebank

@estebankestebank commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Special case message talking about Predicate that couldn't be satisfied when in inference errors so that we don't say "cannot satisfy _: Trait" and instead say "type must implement Trait".

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 16, 2026
@rustbot

rustbot commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@estebank
Tweak wording of failed predicate in inference error
9b1eb93
Special case message talking about `Predicate` that couldn't be satisfied when in inference errors so that we don't say "cannot satisfy `_: Trait`" and instead say "type must implement `Trait`".
@estebank
estebankforce-pushed the infer_must_implement branch from ea99501 to 9b1eb93CompareMarch 16, 2026 17:58
@petrochenkov

petrochenkov commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9b1eb93 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 17, 2026
@Zalathar
Rollup merge ofrust-lang#153967- estebank:infer_must_implement, r=p…
a4eefb7
…etrochenkov
Tweak wording of failed predicate in inference error
Special case message talking about `Predicate` that couldn't be satisfied when in inference errors so that we don't say "cannot satisfy `_: Trait`" and instead say "type must implement `Trait`".
@ZalatharZalathar mentioned this pull request Mar 17, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of#154001- Zalathar:rollup-6iruefK, r=Zalathar
984c19d
Rollup of 7 pull requests
Successful merges:
- #153801 (Add the option to run UI tests with the parallel frontend)
- #153967 (Tweak wording of failed predicate in inference error)
- #152968 (Flip "region lattice" in RegionKind doc comment)
- #153531 (Fix LegacyKeyValueFormat report from docker build: various)
- #153709 (Fix hypothetical ICE in `variances_of`)
- #153884 (test `classify-runtime-const` for `f16`)
- #153946 (dissolve `tests/ui/cross`)
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 17, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of#154008- JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
85e19b8
…uwer
Rollup of 14 pull requests
Successful merges:
- #153972 (stdarch subtree update)
- #153801 (Add the option to run UI tests with the parallel frontend)
- #153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
- #153967 (Tweak wording of failed predicate in inference error)
- #152968 (Flip "region lattice" in RegionKind doc comment)
- #153531 (Fix LegacyKeyValueFormat report from docker build: various)
- #153622 (remove concept of soft-unstable features)
- #153709 (Fix hypothetical ICE in `variances_of`)
- #153884 (test `classify-runtime-const` for `f16`)
- #153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
- #153920 (improve `#[track_caller]` invalid ABI error)
- #153946 (dissolve `tests/ui/cross`)
- #153965 (Fix minor kasan bugs)
- #153991 (Small report_cycle refactor)
@rust-bors
rust-borsBot merged commit 888990b into rust-lang:mainMar 17, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 17, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
bac802d
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153972 (stdarch subtree update)
- rust-lang/rust#153801 (Add the option to run UI tests with the parallel frontend)
- rust-lang/rust#153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
- rust-lang/rust#153967 (Tweak wording of failed predicate in inference error)
- rust-lang/rust#152968 (Flip "region lattice" in RegionKind doc comment)
- rust-lang/rust#153531 (Fix LegacyKeyValueFormat report from docker build: various)
- rust-lang/rust#153622 (remove concept of soft-unstable features)
- rust-lang/rust#153709 (Fix hypothetical ICE in `variances_of`)
- rust-lang/rust#153884 (test `classify-runtime-const` for `f16`)
- rust-lang/rust#153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
- rust-lang/rust#153920 (improve `#[track_caller]` invalid ABI error)
- rust-lang/rust#153946 (dissolve `tests/ui/cross`)
- rust-lang/rust#153965 (Fix minor kasan bugs)
- rust-lang/rust#153991 (Small report_cycle refactor)
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
6201d57
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153972 (stdarch subtree update)
- rust-lang/rust#153801 (Add the option to run UI tests with the parallel frontend)
- rust-lang/rust#153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
- rust-lang/rust#153967 (Tweak wording of failed predicate in inference error)
- rust-lang/rust#152968 (Flip "region lattice" in RegionKind doc comment)
- rust-lang/rust#153531 (Fix LegacyKeyValueFormat report from docker build: various)
- rust-lang/rust#153622 (remove concept of soft-unstable features)
- rust-lang/rust#153709 (Fix hypothetical ICE in `variances_of`)
- rust-lang/rust#153884 (test `classify-runtime-const` for `f16`)
- rust-lang/rust#153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
- rust-lang/rust#153920 (improve `#[track_caller]` invalid ABI error)
- rust-lang/rust#153946 (dissolve `tests/ui/cross`)
- rust-lang/rust#153965 (Fix minor kasan bugs)
- rust-lang/rust#153991 (Small report_cycle refactor)
github-actionsBot pushed a commit to rust-lang/stdarch that referenced this pull request Mar 26, 2026
@bors
Auto merge of #154008 - JonathanBrouwer:rollup-tfGnRi2, r=JonathanBro…
36502a6
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153972 (stdarch subtree update)
- rust-lang/rust#153801 (Add the option to run UI tests with the parallel frontend)
- rust-lang/rust#153959 (Fix non-module `parent_module` in stripped cfg diagnostics)
- rust-lang/rust#153967 (Tweak wording of failed predicate in inference error)
- rust-lang/rust#152968 (Flip "region lattice" in RegionKind doc comment)
- rust-lang/rust#153531 (Fix LegacyKeyValueFormat report from docker build: various)
- rust-lang/rust#153622 (remove concept of soft-unstable features)
- rust-lang/rust#153709 (Fix hypothetical ICE in `variances_of`)
- rust-lang/rust#153884 (test `classify-runtime-const` for `f16`)
- rust-lang/rust#153894 (Point at unit structs on foreign crates in type errors when they are the pattern of a binding)
- rust-lang/rust#153920 (improve `#[track_caller]` invalid ABI error)
- rust-lang/rust#153946 (dissolve `tests/ui/cross`)
- rust-lang/rust#153965 (Fix minor kasan bugs)
- rust-lang/rust#153991 (Small report_cycle refactor)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@estebank@rustbot@rust-log-analyzer@petrochenkov