Skip to content

resolve : mark repr_simd as internal - #154248

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lms0806:issue_154034
Apr 20, 2026
Merged

resolve : mark repr_simd as internal#154248
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lms0806:issue_154034

Conversation

@lms0806

@lms0806lms0806 commented Mar 23, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

I changed repr_simd to internal and changed the position to feature-group-start: internal feature gates.

close#154034

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2026
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2026
@rustbot

rustbot commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 13 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 23, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2026
@rustbot

rustbot commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbotrustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 24, 2026
@lms0806
resolve : issue 154034
ac5e448
resolve : mark repr_simd as internal
resolve : move repr_simd
resolve : move repr_simd
under linkage
resolve : move repr_simd
under pattern_types
resolve : mark repr_simd as internal
resolve : move repr_simd
resolve : move repr_simd
under linkage
resolve : move repr_simd
under pattern_types
@lms0806

lms0806 commented Apr 11, 2026

Copy link
Copy Markdown
ContributorAuthor

r?

@rustbot

rustbot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@lms0806

lms0806 commented Apr 11, 2026

Copy link
Copy Markdown
ContributorAuthor

r? @new-reviewer

@rustbot

rustbot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

Failed to set assignee to new-reviewer: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@lms0806

lms0806 commented Apr 11, 2026

Copy link
Copy Markdown
ContributorAuthor

@dingxiangfei2009 Are you there?

@lms0806

lms0806 commented Apr 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot reroll

@TaKO8Ki

TaKO8Ki commented Apr 20, 2026

Copy link
Copy Markdown
Member

Thanks. @bors r+ rollup

@rust-bors

rust-borsBot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ac5e448 has been approved by TaKO8Ki

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Apr 20, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Apr 20, 2026
@bors
Auto merge of#155552- JonathanBrouwer:rollup-JKIpTuW, r=JonathanBro…
c28e303
…uwer
Rollup of 11 pull requests
Successful merges:
- #154654 (Move `std::io::ErrorKind` to `core::io`)
- #145270 (Fix an ICE observed with an explicit tail-call in a default trait method)
- #154895 (borrowck: Apply `user_arg_index` nomenclature more broadly)
- #155213 (resolve: Make sure visibilities of import declarations make sense)
- #155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`)
- #155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM)
- #155549 (Remove some unnecessary lifetimes.)
- #154248 (resolve : mark repr_simd as internal)
- #154772 (slightly optimize the `non-camel-case-types` lint)
- #155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`)
- #155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
@rust-bors
rust-borsBot merged commit 7162558 into rust-lang:mainApr 20, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 20, 2026
rust-timer added a commit that referenced this pull request Apr 20, 2026
@rust-timer
Unrolled build for#154248
5ea6dbc
Rollup merge of #154248 - lms0806:issue_154034, r=TaKO8Ki
resolve : mark repr_simd as internal
I changed ```repr_simd``` to ```internal``` and changed the position to ```feature-group-start: internal feature gates```.
close#154034
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 21, 2026
@bors
Auto merge of #155552 - JonathanBrouwer:rollup-JKIpTuW, r=JonathanBro…
4c48adb
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#154654 (Move `std::io::ErrorKind` to `core::io`)
- rust-lang/rust#145270 (Fix an ICE observed with an explicit tail-call in a default trait method)
- rust-lang/rust#154895 (borrowck: Apply `user_arg_index` nomenclature more broadly)
- rust-lang/rust#155213 (resolve: Make sure visibilities of import declarations make sense)
- rust-lang/rust#155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`)
- rust-lang/rust#155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM)
- rust-lang/rust#155549 (Remove some unnecessary lifetimes.)
- rust-lang/rust#154248 (resolve : mark repr_simd as internal)
- rust-lang/rust#154772 (slightly optimize the `non-camel-case-types` lint)
- rust-lang/rust#155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`)
- rust-lang/rust#155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaKO8KiTaKO8KiTaKO8Ki approved these changes

Assignees

@TaKO8KiTaKO8Ki

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

Using feature(repr_simd) should trigger the internal_features lint

5 participants

@lms0806@rustbot@rust-log-analyzer@TaKO8Ki@dingxiangfei2009