Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #154273
Merged
Merged
Conversation
… with current import
The test began passing in `nightly-2025-10-16`. Probably by c50aebb because it fixed two "does not live long enough" errors. The test fails to compile with `nightly-2025-10-15` with such an error: $ rustc +nightly-2025-10-15 --edition 2018 tests/ui/async-await/gat-is-send-across-await.rs error: `impl G` does not live long enough --> tests/ui/async-await/gat-is-send-across-await.rs:16:24 | 16 | let _: &dyn Send = &async move { | ________________________^ 17 | | let _gat = g.as_gat(); 18 | | async{}.await 19 | | }; | |_____^
- `char::is_cased` - `char::is_titlecase` - `char::case` - `char::to_titlecase`
It will use enzyme to generate a default derivative implementation, which can be overwritten by the user.
This reverts commit d665c0b.
This reverts commit 9aa065b.
This reverts commit 6edf58f.
This reverts commit 2d411a0.
This reverts commit e8e3544.
This reverts commit f50591f.
This reverts commit 7a123e8.
This reverts commit 917713b.
This reverts commit 5d0863b.
This reverts commit 244b6d5.
…Simulacrum Add APIs for dealing with titlecase ACP: rust-lang/libs-team#354 Tracking issue: rust-lang#153892 r? libs-api @rustbot label T-libs -T-libs-api A-unicode ~~The last commit has some insta-stable `PartialEq` impls, therefore: @rustbot label -needs-fcp Alternatively, I could split those out into a follow-up PR.~~ (Edit: will do in follow-up)
…=jdonszelmann Remove `ATTRIBUTE_ORDER` r? @jdonszelmann There's only a few attributes that use `KeepInnermost` and I think I like the consistency of just making them all `KeepOutermost`
…rochenkov Avoid prematurely choosing a glob import Fixesrust-lang#153842 Use the following without introducing trait to explain: ```rust mod a { pub use crate::x::y as x; // single import rust-lang#1 } mod b { pub mod x { pub mod y {} } } use a::x; // single import rust-lang#2 use b::*; // glob import rust-lang#3 fn main() {} ``` In current implementation, when `rust-lang#1` is first resolved, `crate::x` is temporarily taken from glob import `rust-lang#3` as `crate::b::x`. This happens because `single_import_can_define_name` will see that `rust-lang#2` cannot define `x` (because it depends on `rust-lang#1` and `rust-lang#1` is ignored) and then return `false`. Later, during finalization, `crate::x` in `rust-lang#1` resolves through single import `rust-lang#2` instead, which no longer matches the initially cached module `crate::b::x` and triggers the ICE. I think the resolver should keep this unresolved because `rust-lang#2` may still define `x` to avoid prematurely choosing a glob import. r? petrochenkov
…=WaffleLapkin
const validity checking: do not recurse to references inside MaybeDangling
This arguably should be allowed, but we currently reject it:
```rust
#![feature(maybe_dangling)]
use std::mem::MaybeDangling;
const X: MaybeDangling<&bool> = unsafe { std::mem::transmute(&5u8) };
```
r? @WaffleLapkin…ize-in-generalize, r=lcnr Revert eagerly normalize in generalize r? @lcnr Reverts rust-lang#151746 We'll likely pull eager normalization out of generalization Fixesrust-lang#154173Fixesrust-lang#154244
…r=petrochenkov tests/ui/async-await/gat-is-send-across-await.rs: New regression test The test began passing in `nightly-2025-10-16`. Probably by c50aebb (rust-lang#144064) because it fixed two "does not live long enough" errors. The test fails to compile with `nightly-2025-10-15` with such an error: $ rustc +nightly-2025-10-15 --edition 2018 tests/ui/async-await/gat-is-send-across-await.rs error: `impl G` does not live long enough --> tests/ui/async-await/gat-is-send-across-await.rs:16:24 | 16 | let _: &dyn Send = &async move { | ________________________^ 17 | | let _gat = g.as_gat(); 18 | | async{}.await 19 | | }; | |_____^ Closesrust-lang#111852 since that's where the test comes from.
…athanBrouwer Remove more `BuiltinLintDiag` variants Part of rust-lang#153099. r? @JonathanBrouwer
…onathanBrouwer,jdonszelmann Allow applying autodiff macros to trait functions. It will use enzyme to generate a default derivative implementation, which can be overwritten by the user. closes: rust-lang#153329 r? @JonathanBrouwer
JonathanBrouwer
commented
Mar 23, 2026
MemberAuthor
@bors r+ rollup=never p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
Uh oh!
There was an error while loading. Please reload this page.
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing f66622c (parent) -> 6f22f61 (this PR) Test differencesShow 193 test diffsStage 1
Stage 2
Additionally, 166 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6f22f61305478df09f9a4523743f85d9f558c3d7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Mar 24, 2026
rust-timer
commented
Mar 24, 2026
Collaborator
Finished benchmarking commit (6f22f61): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.0%, secondary 7.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 4.3%, secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 484.979s -> 485.277s (0.06%) |
JonathanBrouwer
commented
Mar 24, 2026
MemberAuthor
The regression is noise, the improvements are not :) |
MemberAuthor
@rustbot label: +perf-regression-triaged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ATTRIBUTE_ORDER#153041 (RemoveATTRIBUTE_ORDER)BuiltinLintDiagvariants #154224 (Remove moreBuiltinLintDiagvariants)r? @ghost
Create a similar rollup