Exposing Float Masks - #154372

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Apersoma:float_masks
Apr 25, 2026
Merged

Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Apersoma:float_masks

Conversation

@Apersoma

@ApersomaApersoma commented Mar 25, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev

folkertdev commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

This seems useful, do ask if you need help here

@Apersoma
Apersoma marked this pull request as ready for review April 22, 2026 22:01
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2026
@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 22, 2026
@rustbot

rustbot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@rustbot

rustbot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@Apersoma

Apersoma commented Apr 22, 2026

Copy link
Copy Markdown
ContributorAuthor

@folkertdev would you be interested in reviewing this?

folkertdev
folkertdev requested changes Apr 22, 2026
View reviewed changes

@folkertdevfolkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.

r? folkertdev

View changes since this review

Comment threadcompiler/rustc_feature/src/unstable.rs Outdated
Comment threadlibrary/core/src/num/f128.rs Outdated
Comment threadlibrary/core/src/num/f16.rs Outdated
Comment threadlibrary/core/src/num/f16.rs Outdated
Comment threadlibrary/core/src/num/f16.rs Outdated
@rustbotrustbot assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026
@rustbot

rustbot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Apersoma

Apersoma commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

i'll squash it at the end

@Apersoma

Apersoma commented Apr 23, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2026
tgross35
tgross35 reviewed Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs Outdated
Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs Outdated
Comment threadlibrary/core/src/num/f16.rs Outdated
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs Outdated
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs Outdated
@tgross35

tgross35 commented Apr 23, 2026

Copy link
Copy Markdown
Member

When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)

Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.

@Apersoma

Apersoma commented Apr 24, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

tgross35
tgross35 approved these changes Apr 24, 2026
View reviewed changes

@tgross35tgross35 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bors r+ rollup

View changes since this review

@rust-bors

rust-borsBot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d5b941d has been approved by tgross35

It is now in the queue for this repository.

@rust-borsrust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 24, 2026
@rust-borsrust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026
@Apersoma

Apersoma commented Apr 24, 2026

Copy link
Copy Markdown
ContributorAuthor

@tgross35
how long should I wait on a stability pr and is the FCP before or after that pr?

@ApersomaApersoma mentioned this pull request Apr 24, 2026
Open
4 tasks
@tgross35

tgross35 commented Apr 25, 2026

Copy link
Copy Markdown
Member

@tgross35 how long should I wait on a stability pr

These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.

and is the FCP before or after that pr?

I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.

jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753
This was referenced Apr 25, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot merged commit b3ccc96 into rust-lang:mainApr 25, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 25, 2026
rust-timer added a commit that referenced this pull request Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma deleted the float_masks branch April 25, 2026 21:42
@ApersomaApersoma mentioned this pull request Apr 30, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Exposing Float Masks - #154372
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Apr 25, 2026
Merged
Exposing Float Masks#154372
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
Apersoma:float_masks
Conversation
@Apersoma
@ApersomaApersoma
commented
Mar 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
This seems useful, do ask if you need help here
@Apersoma
Apersoma
marked this pull request as ready for review
April 22, 2026 22:01
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 22, 2026
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
r? @scottmcm
rustbot has assigned @scottmcm.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Apersoma
Apersoma
commented
Apr 22, 2026

Copy link


Copy Markdown

ContributorAuthor
@folkertdev would you be interested in reviewing this?
folkertdev
folkertdev
requested changes
Apr 22, 2026
View reviewed changes
@folkertdevfolkertdev
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.
r? folkertdev
View changes since this review
Comment threadcompiler/rustc_feature/src/unstable.rs
Outdated

Comment threadlibrary/core/src/num/f128.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

@rustbotrustbot
assigned folkertdev and unassigned scottmcmApr 22, 2026
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 22, 2026
@rustbot
rustbot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Apersoma
Apersoma
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
i'll squash it at the end
@Apersoma
Apersoma
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 23, 2026
tgross35
tgross35
reviewed
Apr 23, 2026
View reviewed changes
Comment threadcompiler/rustc_span/src/symbol.rs
Outdated

Comment threadtests/ui/feature-gates/feature-gate-float-masks.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

Comment threadlibrary/core/src/num/f16.rs
Comment threadlibrary/core/src/num/f16.rs
Outdated

@tgross35
tgross35
commented
Apr 23, 2026

Copy link


Copy Markdown

Member
When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)
Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
tgross35
tgross35
approved these changes
Apr 24, 2026
View reviewed changes
@tgross35tgross35
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@bors r+ rollup
View changes since this review
@rust-bors
rust-borsBot
commented
Apr 24, 2026

Copy link


Copy Markdown

Contributor
📌 Commit d5b941d has been approved by tgross35
It is now in the queue for this repository.
@rust-borsrust-borsBot
added
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Apr 24, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 24, 2026
@Apersoma
Apersoma
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@tgross35

how long should I wait on a stability pr and is the FCP before or after that pr?
@ApersomaApersoma
mentioned this pull request
Apr 24, 2026

Open

4 tasks
@tgross35
tgross35
commented
Apr 25, 2026

Copy link


Copy Markdown

Member
@tgross35 how long should I wait on a stability pr
These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.
and is the FCP before or after that pr?
I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 25, 2026
@jhpratt
Rollup merge ofrust-lang#154372- Apersoma:float_masks, r=tgross35
e9d170c
Exposing Float Masks
Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753

This was referenced Apr 25, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 25, 2026
@bors
Auto merge of#155766- jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f
Rollup of 7 pull requests
Successful merges:
- #155643 (Improve suggestion for $-prefixed fragment specifiers)
- #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
- #154372 (Exposing Float Masks)
- #155680 (Handle index projections in call destinations in DSE)
- #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
- #155737 (Account for `GetSyntheticValue` failures)
- #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors
rust-borsBot
merged commit b3ccc96
into
rust-lang:mainApr 25, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 25, 2026
rust-timer added a commit
that referenced
this pull request
Apr 25, 2026
@rust-timer
Unrolled build for#154372
863518e
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35
Exposing Float Masks
Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma
Apersoma
deleted the

float_masks

branch
April 25, 2026 21:42
@ApersomaApersoma
mentioned this pull request
Apr 30, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev requested changes
@tgross35tgross35tgross35 approved these changes

Assignees

@folkertdevfolkertdev

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma@rust-log-analyzer@folkertdev@rustbot@tgross35@scottmcm