Skip to content

misc test cleanups - #154606

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
cyrgani:misc-test-cleanups
Mar 31, 2026
Merged

misc test cleanups#154606
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
cyrgani:misc-test-cleanups

Conversation

@cyrgani

@cyrganicyrgani commented Mar 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

These are some mixed cleanups to tests/ui that individually seemed too small for a PR of their own. Some duplicated tests are removed, issues-* tests are renamed and more FIXMEs are added to ui/README.md.
Reasoning for the deleted tests:

r? @Kivooeo

@rustbot

rustbot commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 30, 2026
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 30, 2026
@Kivooeo

Kivooeo commented Mar 31, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6cd2656 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 31, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154606- cyrgani:misc-test-cleanups, r=Kivooeo
2a93359
misc test cleanups
These are some mixed cleanups to `tests/ui` that individually seemed too small for a PR of their own. Some duplicated tests are removed, `issues-*` tests are renamed and more FIXMEs are added to `ui/README.md`.
Reasoning for the deleted tests:
* `tests/ui/associated-types/issue-47814.rs`: duplicate of `tests/ui/associated-consts/issue-47814.rs`
* rename `tests/ui/closures/2229_closure_analysis/migrations/issue-78720.rs` to `.../nested-copy-drops-83176.rs` since rust-lang#78720 was not the correct issue, rust-lang#83176 was.
* `tests/ui/specialization/defaultimpl/specialization-feature-gate-default.rs`: duplicate of `tests/ui/specialization/specialization-feature-gate-default.rs`
* `fn/issue-1900.rs`: duplicate of `error-codes/E0131.rs`
r? @Kivooeo
This was referenced Mar 31, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of#154637- JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
0e95a0f
…uwer
Rollup of 12 pull requests
Successful merges:
- #154419 (Take first task group for further execution)
- #154569 (Fix type alias where clause suggestion spacing issue)
- #154617 (Update flate2 users to use zlib-rs)
- #154618 (Fix AtomicPtr::update's cfg gate)
- #154620 (stabilize new Range type and iterator)
- #151932 (refactor: remove `Adjust::ReborrowPin`)
- #153980 (refactor: move doc(rust_logo) check to parser)
- #154134 (fix: guard paren-sugar pretty-printing on short trait args)
- #154270 (Create `Ty` type alias in `rustc_type_ir`)
- #154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
- #154606 (misc test cleanups)
- #154612 (Add a test for a now fixed ICE with `offset_of!()`)
@rust-bors
rust-borsBot merged commit e9f6a77 into rust-lang:mainMar 31, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 31, 2026
rust-timer added a commit that referenced this pull request Mar 31, 2026
@rust-timer
Unrolled build for#154606
8549410
Rollup merge of #154606 - cyrgani:misc-test-cleanups, r=Kivooeo
misc test cleanups
These are some mixed cleanups to `tests/ui` that individually seemed too small for a PR of their own. Some duplicated tests are removed, `issues-*` tests are renamed and more FIXMEs are added to `ui/README.md`.
Reasoning for the deleted tests:
* `tests/ui/associated-types/issue-47814.rs`: duplicate of `tests/ui/associated-consts/issue-47814.rs`
* rename `tests/ui/closures/2229_closure_analysis/migrations/issue-78720.rs` to `.../nested-copy-drops-83176.rs` since #78720 was not the correct issue, #83176 was.
* `tests/ui/specialization/defaultimpl/specialization-feature-gate-default.rs`: duplicate of `tests/ui/specialization/specialization-feature-gate-default.rs`
* `fn/issue-1900.rs`: duplicate of `error-codes/E0131.rs`
r? @Kivooeo
@cyrgani
cyrgani deleted the misc-test-cleanups branch March 31, 2026 20:25
github-actionsBot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
84dcb0e
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#154419 (Take first task group for further execution)
- rust-lang/rust#154569 (Fix type alias where clause suggestion spacing issue)
- rust-lang/rust#154617 (Update flate2 users to use zlib-rs)
- rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate)
- rust-lang/rust#154620 (stabilize new Range type and iterator)
- rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`)
- rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser)
- rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args)
- rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`)
- rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
- rust-lang/rust#154606 (misc test cleanups)
- rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Apr 1, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
fd5759d
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#154419 (Take first task group for further execution)
- rust-lang/rust#154569 (Fix type alias where clause suggestion spacing issue)
- rust-lang/rust#154617 (Update flate2 users to use zlib-rs)
- rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate)
- rust-lang/rust#154620 (stabilize new Range type and iterator)
- rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`)
- rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser)
- rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args)
- rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`)
- rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
- rust-lang/rust#154606 (misc test cleanups)
- rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
@fmease

fmease commented Apr 1, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • tests/ui/specialization/defaultimpl/specialization-feature-gate-default.rs: duplicate of tests/ui/specialization/specialization-feature-gate-default.rs

This is incorrect. The defaultimpl one exercises the feature gate for default impl $Trait for $Type {} while the other one exercises the feature gate for default associated items. They exercise different code paths in fact.

Noticed when my PR #154527 became unmergeable. I'm either gonna readd the test or move the test case into the main feature gate test file.

github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 6, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
06b1db4
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#154419 (Take first task group for further execution)
- rust-lang/rust#154569 (Fix type alias where clause suggestion spacing issue)
- rust-lang/rust#154617 (Update flate2 users to use zlib-rs)
- rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate)
- rust-lang/rust#154620 (stabilize new Range type and iterator)
- rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`)
- rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser)
- rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args)
- rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`)
- rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
- rust-lang/rust#154606 (misc test cleanups)
- rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KivooeoKivooeo

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrgani@rustbot@Kivooeo@fmease