Skip to content

./x run miri: default to edition 2021 - #154635

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:miri-run-edition
Mar 31, 2026
Merged

./x run miri: default to edition 2021#154635
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:miri-run-edition

Conversation

@RalfJung

@RalfJungRalfJung commented Mar 31, 2026

Copy link
Copy Markdown
Member

Fixes#154630

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 31, 2026
@rustbot

rustbot commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@Mark-Simulacrum

Mark-Simulacrum commented Mar 31, 2026

Copy link
Copy Markdown
Member

@bors r+

Not sure if 2021 makes the most sense, but happy to leave that up to miri maintainers. Note that UI tests default to 2015 I believe.

@rust-bors

rust-borsBot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3c0059 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2026
@RalfJung

RalfJung commented Mar 31, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Miri ui tests currently default to 2021.

@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 31, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of#154638- JonathanBrouwer:rollup-oLBZ6Tr, r=JonathanBro…
48cc71e
…uwer
Rollup of 4 pull requests
Successful merges:
- #150752 (Update libc to v0.2.183)
- #152432 (add rustc option -Zpacked-stack)
- #154634 (Use `Hcx`/`hcx` consistently for `StableHashingContext`.)
- #154635 (./x run miri: default to edition 2021)
rust-timer added a commit that referenced this pull request Mar 31, 2026
@rust-timer
Unrolled build for#154635
b276107
Rollup merge of #154635 - RalfJung:miri-run-edition, r=Mark-Simulacrum
./x run miri: default to edition 2021
Fixes#154630
@rust-bors
rust-borsBot merged commit c13822a into rust-lang:mainMar 31, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 31, 2026
@RalfJung
RalfJung deleted the miri-run-edition branch April 4, 2026 20:49
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 6, 2026
@bors
Auto merge of #154638 - JonathanBrouwer:rollup-oLBZ6Tr, r=JonathanBro…
711fc9a
…uwer
Rollup of 4 pull requests
Successful merges:
- rust-lang/rust#150752 (Update libc to v0.2.183)
- rust-lang/rust#152432 (add rustc option -Zpacked-stack)
- rust-lang/rust#154634 (Use `Hcx`/`hcx` consistently for `StableHashingContext`.)
- rust-lang/rust#154635 (./x run miri: default to edition 2021)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

"./x run miri" somehow cannot use "core" imports?

3 participants

@RalfJung@rustbot@Mark-Simulacrum