Uh oh!
There was an error while loading. Please reload this page.
Migrate rest of std::io to alloc - #154684
Closed
a1phyr wants to merge 9 commits into
Closed
Conversation
rustbot
commented
Apr 1, 2026
Collaborator
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
commented
Apr 1, 2026
Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
a1phyr
marked this pull request as draft
April 1, 2026 15:42
4 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is a separated commit to be easy to reverse later.
This reverts commit 6a30319.
rust-log-analyzer
commented
Apr 3, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
☔ The latest upstream changes (presumably #154832) made this pull request unmergeable. Please resolve the merge conflicts. |
Comment on lines
+294
to
+359
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<R> Read for Arc<R> | ||
| where | ||
| R: Read, | ||
| for<'a> &'a R: Read, | ||
| { | ||
| fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> { | ||
| (&**self).read(buf) | ||
| } | ||
| fn read_vectored(&mut self, bufs: &mut [IoSliceMut<'_>]) -> io::Result<usize> { | ||
| (&**self).read_vectored(bufs) | ||
| } | ||
| fn read_buf(&mut self, cursor: BorrowedCursor<'_>) -> io::Result<()> { | ||
| (&**self).read_buf(cursor) | ||
| } | ||
| #[inline] | ||
| fn is_read_vectored(&self) -> bool { | ||
| (&**self).is_read_vectored() | ||
| } | ||
| fn read_to_end(&mut self, buf: &mut Vec<u8>) -> io::Result<usize> { | ||
| (&**self).read_to_end(buf) | ||
| } | ||
| fn read_to_string(&mut self, buf: &mut String) -> io::Result<usize> { | ||
| (&**self).read_to_string(buf) | ||
| } | ||
| } | ||
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<W> Write for Arc<W> | ||
| where | ||
| W: Write, | ||
| for<'a> &'a W: Write, | ||
| { | ||
| fn write(&mut self, buf: &[u8]) -> io::Result<usize> { | ||
| (&**self).write(buf) | ||
| } | ||
| fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> io::Result<usize> { | ||
| (&**self).write_vectored(bufs) | ||
| } | ||
| #[inline] | ||
| fn is_write_vectored(&self) -> bool { | ||
| (&**self).is_write_vectored() | ||
| } | ||
| #[inline] | ||
| fn flush(&mut self) -> io::Result<()> { | ||
| (&**self).flush() | ||
| } | ||
| } | ||
| #[stable(feature = "arc_io_traits", since = "CURRENT_RUSTC_VERSION")] | ||
| #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))] | ||
| impl<S> Seek for Arc<S> | ||
| where | ||
| S: Seek, | ||
| for<'a> &'a S: Seek, | ||
| { | ||
| fn seek(&mut self, pos: SeekFrom) -> io::Result<u64> { | ||
| (&**self).seek(pos) | ||
| } | ||
| fn stream_len(&mut self) -> io::Result<u64> { | ||
| (&**self).stream_len() | ||
| } | ||
| fn stream_position(&mut self) -> io::Result<u64> { | ||
| (&**self).stream_position() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These implementations have some potential issues. See #155684 for just this problem split out into its own PR.
This was referenced May 11, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 12, 2026
Move `std::io::Cursor` to `core::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Subset of: rust-lang#154684 ## Description Moves `std::io::Cursor` to `core::io`, leaving the IO trait implementations behind. They will be moved along with the traits themselves. Certain documentation links had to be amended, and a private/unstable `into_parts_mut` method was added to allow the internals to remain private. --- ## Notes * This can be reviewed independently of the other PRs tracked in rust-lang#154046. * No AI tooling of any kind was used during the creation of this PR.
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 12, 2026
Move `std::io::util` to `core::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Subset of: rust-lang#154684 ## Description Moves utility types and functions from `std::io::util` and `std::io` to `core::io`, leaving any IO trait implementations behind. They will be moved along with the traits themselves. Certain documentation links had to be amended. - `Chain` - `Empty` - `Repeat` - `Sink` - `Take` - `empty` - `repeat` - `sink` --- ## Notes * This can be reviewed independently of the other PRs tracked in rust-lang#154046. * `Chain` and `Take` were previously in the main `mod.rs` file for `std::io`, but I've chosen to move them into the `util.rs` file in `core::io` instead. I think they make more sense in that file, but I'm happy to move them into `mod.rs` if that's a controversial decision. * No AI tooling of any kind was used during the creation of this PR.
rust-timer added a commit
that referenced
this pull request
May 12, 2026
Rollup merge of #156428 - bushrat011899:core_io_cursor, r=nia-e Move `std::io::Cursor` to `core::io` ACP: rust-lang/libs-team#755 Tracking issue: #154046 Subset of: #154684 ## Description Moves `std::io::Cursor` to `core::io`, leaving the IO trait implementations behind. They will be moved along with the traits themselves. Certain documentation links had to be amended, and a private/unstable `into_parts_mut` method was added to allow the internals to remain private. --- ## Notes * This can be reviewed independently of the other PRs tracked in #154046. * No AI tooling of any kind was used during the creation of this PR.
a1phyr
commented
Aug 1, 2026
ContributorAuthor
This was superseded by @bushrat011899's excellent work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #152918
Tracking issue: #154046
Special things to note:
allocdoc testsArc. Unlike Generalize io for Arc #130675, this PR restricts the implementation more to avoid bad implementations such asArc<[u8]>.Another way to do this would be to bypass orphan rule. Is it possible in
std?