Fix ICE from cfg_attr_trace by chenyukang · Pull Request #154803 · rust-lang/rust

chenyukang · 2026-04-04T09:17:22Z

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

chenyukang · 2026-04-04T09:17:22Z

Fixes#154801
Fixes#143094

r? @JonathanBrouwer

The root cause is we recovery from parsing attribute error here:

rust/compiler/rustc_attr_parsing/src/parser.rs

Line 550 in ed6f9af

err.cancel();

while the later suggestion code from type checking try to inspect the attr span of the expr in the second error, keep the span seems reasonable.

rustbot · 2026-04-04T09:17:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-04T09:17:28Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T09:44:57Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

JonathanBrouwer · 2026-04-04T12:31:50Z


 /// Represents the trace attribute of `#[cfg_attr]`
- CfgAttrTrace,
+ CfgAttrTrace(Span),


How does this behave with multiple cfg_attr attributes? Since this attribute can exist multiple times, ideally we should have a ThinVec here?

rustbot · 2026-04-25T03:17:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup
While the is_prefix_attr_for_suggestions is far from correct, this solution is better than ICE'ing and it's only for diagnostics anyways, so doesn't need to be perfect

View changes since this review

rust-bors · 2026-04-25T11:03:35Z

📌 Commit 45b4e3c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

@JonathanBrouwer

…ttr-span, r=JonathanBrouwer Fix ICE from cfg_attr_trace Fixesrust-lang#154801Fixesrust-lang#143094 r? @JonathanBrouwer The root cause is we recovery from parsing attribute error here: https://github.com/rust-lang/rust/blob/ed6f9af7d47f5a5eda2a4a1925d1e250b51a37f2/compiler/rustc_attr_parsing/src/parser.rs#L550 while the later suggestion code from type checking try to inspect the attr span of the `expr` in the second error, keep the span seems reasonable.

…uwer Rollup of 5 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

…uwer Rollup of 9 pull requests Successful merges: - #146181 (Add intrinsic for launch-sized workgroup memory on GPUs) - #154803 (Fix ICE from cfg_attr_trace ) - #155065 (Error on invalid macho section specifier) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155676 ( Reject implementing const Drop for types that are not const `Destruct` already) - #155696 (Add a higher-level API for parsing attributes) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes) - #155783 (Do not suggest internal cfg trace attributes)

rustbot assigned JonathanBrouwer Apr 4, 2026

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2026

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-154801-cfg-attr-span branch from ed6f9af to 952c5baCompare April 4, 2026 09:44

rustbot added the T-clippy Relevant to the Clippy team. label Apr 4, 2026

JonathanBrouwer reviewed Apr 4, 2026
View reviewed changes

Comment threadtests/ui/conditional-compilation/cfg-attr-parsed-span-issue-154801.rs

JonathanBrouwer requested changes Apr 4, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2026

chenyukang changed the title ~~Fix ICE from cfg_attr_trace by storing span~~Fix ICE from cfg_attr_trace Apr 4, 2026

chenyukang force-pushed the yukang-fix-154801-cfg-attr-span branch from 952c5ba to 46e2396Compare April 4, 2026 22:20

This comment has been minimized.
Sign in to view

JonathanBrouwer self-requested a review April 12, 2026 15:40

Fix ICE of trying to get span from all attrs
45b4e3c

chenyukang force-pushed the yukang-fix-154801-cfg-attr-span branch from 46e2396 to 45b4e3cCompare April 25, 2026 03:17

JonathanBrouwer approved these changes Apr 25, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2026

JonathanBrouwer mentioned this pull request Apr 25, 2026
Rollup of 6 pull requests #155773
Closed

JonathanBrouwer mentioned this pull request Apr 25, 2026
Rollup of 5 pull requests #155786
Closed

JonathanBrouwer mentioned this pull request Apr 25, 2026
Rollup of 9 pull requests #155796
Merged

rust-borsBot merged commit 76a3655 into rust-lang:mainApr 26, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 26, 2026