Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); cg_llvm: scalable vectors with `simd_cast` and `simd_select` by davidtwco · Pull Request #155106 · rust-lang/rust · GitHub
Skip to content

cg_llvm: scalable vectors with simd_cast and simd_select - #155106

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics
Apr 13, 2026
Merged

cg_llvm: scalable vectors with simd_cast and simd_select#155106
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
davidtwco:scalable-vector-more-simd-intrinsics

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Previously sve_cast's implementation was abstracted to power both sve_cast and simd_cast which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another simd_* intrinsic, sve_cast is removed and simd_cast is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.

Building on the previous change, support scalable vectors with simd_select. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 10, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

Previously `sve_cast`'s implementation was abstracted to power both
`sve_cast` and `simd_cast` which supported scalable and non-scalable
vectors respectively. In anticipation of having to do this for another
`simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to
accept both scalable and non-scalable intrinsics, an approach that will
scale better to the other intrinsics.
Building on the previous change, support scalable vectors with
`simd_select`. Previous patches already landed the necessary changes in
the implementation of this intrinsic, but didn't allow scalable vector
arguments to be passed in.
@davidtwco
davidtwcoforce-pushed the scalable-vector-more-simd-intrinsics branch from 0c89d6d to 62ffc89CompareApril 13, 2026 11:25
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Amanieu

Copy link
Copy Markdown
Member

LGTM. I particularly like this since simd_cast is now also usable for RVV in the future.

@bors r+

@rust-bors

rust-borsBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62ffc89 has been approved by Amanieu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #155227 (`rust-analyzer` subtree update)
- #153335 (Add #![unstable_removed(..)] attribute to track removed features)
- #154932 (Handle RTN projections in assoc type restriction diagnostics)
- #155096 (delegation: support proper interaction of user-specified args and impl Traits)
- #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- #155140 (add regression test for OpenOptionsExt downstream compat)
- #155182 (Make the expansion of guard metavars begin guard non-terminals)
- #155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- #153997 (Use closures more consistently in `dep_graph.rs`.)
- #155003 (update thin-vec)
@rust-bors
rust-borsBot merged commit 83a57ca into rust-lang:mainApr 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
Rollup merge of #155106 - davidtwco:scalable-vector-more-simd-intrinsics, r=Amanieu
cg_llvm: scalable vectors with `simd_cast` and `simd_select`
Previously `sve_cast`'s implementation was abstracted to power both `sve_cast` and `simd_cast` which supported scalable and non-scalable vectors respectively. In anticipation of having to do this for another `simd_*` intrinsic, `sve_cast` is removed and `simd_cast` is changed to accept both scalable and non-scalable intrinsics, an approach that will scale better to the other intrinsics.
Building on the previous change, support scalable vectors with `simd_select`. Previous patches already landed the necessary changes in the implementation of this intrinsic, but didn't allow scalable vector arguments to be passed in.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
@davidtwco
davidtwco deleted the scalable-vector-more-simd-intrinsics branch April 13, 2026 23:23
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Apr 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#155227 (`rust-analyzer` subtree update)
- rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features)
- rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics)
- rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits)
- rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`)
- rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat)
- rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals)
- rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering)
- rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.)
- rust-lang/rust#155003 (update thin-vec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@rustbot@rust-log-analyzer@Amanieu@dingxiangfei2009