Skip to content

Rollup of 3 pull requests - #155160

Closed
JonathanBrouwer wants to merge 6 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-7hxXCKQ
Closed

Rollup of 3 pull requests#155160
JonathanBrouwer wants to merge 6 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-7hxXCKQ

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

Folkert de Vriesand others added 6 commits April 11, 2026 14:12
* remove time assertion on SystemTime
* skip test only if when a time change occurs
* Extend `core::char`'s documentation of casing issues
* Fix typos
* Fix typo
Co-authored-by: GrigorenkoPV <GrigorenkoPV+github@yandex.ru>
* Document maximum 3x character expansion
This is guaranteed by Unicode.
* Fix error in `str` casing method docs
…Simulacrum
Extend `core::char`'s documentation of casing issues
@rustbot label A-unicode A-docs
…=Urgau
add `cfg(target_object_format = "...")`
tracking issue: rust-lang#152586
I'm implementing the predicate as `target_object_format`, because that's what is useful to me (for testing `#[link_section = "..."]` where `mach-o` has some extra restrictions) and maps cleanly to the `BinaryFormat` enum that is used internally. There is still room for a future `target_executable_format` when there is a use case.
cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal.
r? JonathanBrouwer a sidequest from the sidequest that is rust-lang#155065
…-Simulacrum
fix spurious test failure in `metadata_access_times`
Fixesrust-lang#148408
The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Apr 11, 2026
@rustbotrustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 11, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@rust-bors

rust-borsBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6a0c8fd has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Apr 11, 2026
…uwer
Rollup of 3 pull requests
Successful merges:
- #154491 (Extend `core::char`'s documentation of casing issues)
- #155126 (add `cfg(target_object_format = "...")`)
- #153871 (fix spurious test failure in `metadata_access_times`)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-apple failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
[TIMING:end] tool::ToolBuild { build_compiler: Compiler { stage: 0, host: aarch64-apple-darwin, forced_compiler: false }, target: aarch64-apple-darwin, tool: "html-checker", path: "src/tools/html-checker", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [], artifact_kind: Binary } -- 2.925
[TIMING:end] tool::HtmlChecker { compiler: Compiler { stage: 0, host: aarch64-apple-darwin, forced_compiler: false }, target: aarch64-apple-darwin } -- 0.000
Running HTML checker...
=> Errors for `/Users/runner/work/rust/rust/build/aarch64-apple-darwin/doc/core/primitive.char.html` (error code: 1) <=
line 643 column 486 - Warning: <a> escaping malformed URI reference (ESCAPED_ILLEGAL_URI)
=> Errors for `/Users/runner/work/rust/rust/build/aarch64-apple-darwin/doc/std/primitive.char.html` (error code: 1) <=
line 642 column 486 - Warning: <a> escaping malformed URI reference (ESCAPED_ILLEGAL_URI)
Done! Read 45147 files...
Error: "HTML check failed: 2 errors"
Command `/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-tools-bin/html-checker /Users/runner/work/rust/rust/build/aarch64-apple-darwin/doc` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1618:23
---
1: std::backtrace_rs::backtrace::trace_unsynchronized::<<std::backtrace::Backtrace>::create::{closure#0}>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14
2: <std::backtrace::Backtrace>::create
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/backtrace.rs:331:13
3: <bootstrap::utils::exec::DeferredCommand>::finish_process
at ./src/bootstrap/src/utils/exec.rs:939:17
4: <bootstrap::utils::exec::DeferredCommand>::wait_for_output::<&bootstrap::utils::exec::ExecutionContext>
at ./src/bootstrap/src/utils/exec.rs:831:21
5: <bootstrap::utils::exec::ExecutionContext>::run
at ./src/bootstrap/src/utils/exec.rs:741:45
6: <bootstrap::utils::exec::BootstrapCommand>::run::<&bootstrap::core::builder::Builder>
at ./src/bootstrap/src/utils/exec.rs:339:27
7: <bootstrap::core::build_steps::test::HtmlCheck as bootstrap::core::builder::Step>::run
at ./src/bootstrap/src/core/build_steps/test.rs:250:14
8: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::test::HtmlCheck>
at ./src/bootstrap/src/core/builder/mod.rs:1579:36
9: <bootstrap::core::build_steps::test::HtmlCheck as bootstrap::core::builder::Step>::make_run
at ./src/bootstrap/src/core/build_steps/test.rs:227:21
10: <bootstrap::core::builder::StepDescription>::maybe_run
at ./src/bootstrap/src/core/builder/mod.rs:476:13
11: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
at ./src/bootstrap/src/core/builder/cli_paths.rs:141:22
12: <bootstrap::core::builder::Builder>::run_step_descriptions
at ./src/bootstrap/src/core/builder/mod.rs:1122:9
13: <bootstrap::core::builder::Builder>::execute_cli
at ./src/bootstrap/src/core/builder/mod.rs:1101:14
14: <bootstrap::Build>::build
at ./src/bootstrap/src/lib.rs:799:25
15: bootstrap::main
at ./src/bootstrap/src/bin/main.rs:130:11
16: <fn() as core::ops::function::FnOnce<()>>::call_once
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/core/src/ops/function.rs:250:5
17: std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/sys/backtrace.rs:166:18
18: std::rt::lang_start::<()>::{closure#0}
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:206:18
19: <&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync as core::ops::function::FnOnce<()>>::call_once
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/core/src/ops/function.rs:287:21
20: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
21: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:544:19
22: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panic.rs:359:14
23: std::rt::lang_start_internal::{closure#0}
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:175:24
24: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
---
at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:205:5
29: _main
Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `--stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin`
Build completed unsuccessfully in 2:11:19
local time: Sat Apr 11 19:06:43 UTC 2026
network time: Sat, 11 Apr 2026 19:06:43 GMT
##[error]Process completed with exit code 1.

@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2026
@rust-bors

rust-borsBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 9a81e54 failed: CI. Failed job:

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026
@rust-bors

rust-borsBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

PR #154491, which is a member of this rollup, was unapproved.

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer deleted the rollup-7hxXCKQ branch August 21, 2026 08:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-infra-minicoreArea: `minicore` test auxiliary and `//@ add-core-stubs`rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@mattiapitossi@Jules-Bertholet