Rollup of 6 pull requests - #155166

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged

Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-YH2oUIz

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Apr 11, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

zachs18and others added 13 commits April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Apr 11, 2026
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 11, 2026
@JonathanBrouwer

JonathanBrouwer commented Apr 11, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

@rust-bors

rust-borsBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 58ca4df has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors

rust-borsBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)

@scottmcm

scottmcm commented Apr 12, 2026

Copy link
Copy Markdown
Member

Over 5 hours? That's not good...

@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2026
@rust-bors

rust-borsBot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

💥 Test timed out after 21600s

@jhpratt

jhpratt commented Apr 12, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-linux

Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors

rust-borsBot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)

@jhpratt

jhpratt commented Apr 12, 2026

Copy link
Copy Markdown
Member

Seems spurious then?

@bors retry

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2026
@rust-bors

rust-borsBot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 8m 25s
Pushing d32e620 to main...

@rust-bors
rust-borsBot merged commit d32e620 into rust-lang:mainApr 12, 2026
13 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 12, 2026
@rust-timer

rust-timer commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)

previous master: 6ad4d1b0e7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actionsBot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)

Test differences

Show 9570 test diffs

Stage 1

  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)

Stage 2

  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)

Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d32e620): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary -2.2%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅
(primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅
(secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1

Cycles

Results (primary -5.0%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.9%[3.9%, 3.9%]1
Regressions ❌
(secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅
(primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅
(secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)

@JonathanBrouwer
JonathanBrouwer deleted the rollup-YH2oUIz branch August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rollup of 6 pull requests - #155166
Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Apr 12, 2026
Merged
Rollup of 6 pull requests#155166
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-YH2oUIz
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
zachs18and others
added 13 commits
April 6, 2026 23:41
@zachs18
Make Box/Rc/Arc::into_array allocator-aware
938c5b5
@zachs18
Add doctest for Box/Rc/Arc::into_array
7d35719
@PaulDance
Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7
962e9e2
The recently-added test currently systematically deadlocks when running
it under i686 Windows 7, but not x86_64 that passes it fine. This
therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`:
removing the `- 1` re-introduces the deadlock, at least under our
testing environment. This fix thus uses this value. However, I have no
real justification to support that, because I find myself a bit at a
loss when comparing the implementation details, the comment added above
the test and what the current value is; some help would therefore be
nice in this aspect. Also, the value change is restricted to 32-bit Win7
as there is no evidence to support it should be done for other targets.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@dianne
don't leak internal temporaries from dbg!
35be9f2
@surban
Update libc to v0.2.184
1209a86
@okaneco
Stabilize feature isolate_most_least_significant_one
a69f989
@josetorrs
replace def_id: did with def_id
ec582d5
@JonathanBrouwer
Rollup merge ofrust-lang#155057- rust-wasi-web:update-libc-0.2.184,…
81578ef
… r=Mark-Simulacrum
Update libc to v0.2.184
This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
@JonathanBrouwer
Rollup merge ofrust-lang#154967- PaulDance:patches/fix-x86-win7-rwl…
197eb8c
…ock-max-test, r=Mark-Simulacrum
Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7
The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target.
Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets.
cc @roblabla@rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
@JonathanBrouwer
Rollup merge ofrust-lang#154994- dianne:no-dbg-temp, r=Mark-Simulacrum
59b36a5
don't leak internal temporaries from `dbg!`
Fixesrust-lang#154988
r? @Mark-Simulacrum as the reviewer of rust-lang#154074
@JonathanBrouwer
Rollup merge ofrust-lang#155130- okaneco:stabilize_iso_high_one, r=…
73a3824
…Mark-Simulacrum
Stabilize feature `isolate_most_least_significant_one`
FCP completed rust-lang#136909 (comment)Closesrust-lang#136909
@JonathanBrouwer
Rollup merge ofrust-lang#154925- zachs18:heap-into-array-with-alloc…
9a24dbf
…, r=Mark-Simulacrum
Make Box/Rc/Arc::into_array allocator-aware (and add doctest)
Tracking issue for `alloc_slice_into_array`: rust-lang#148082
Tracking issue for `allocator_api`: rust-lang#32838
Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware.
I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`.
@rustbot label T-libs-api
@JonathanBrouwer
Rollup merge ofrust-lang#155063- josetorrs:refactor-alias-free, r=W…
58ca4df
…affleLapkin
`ty::Alias`: replace `def_id: did` with `def_id`
related issue: rust-lang#154941
tackling this task:
- [x] replace def_id: did with def_id where possible
r? @WaffleLapkin
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Apr 11, 2026
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 11, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Apr 11, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 58ca4df has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
592c36f
Rollup of 6 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 11, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=JonathanBro…
10d7e55
…uwer
Rollup of 6 pull requests
Successful merges:
- #155057 (Update libc to v0.2.184)
- #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
- #154994 (don't leak internal temporaries from `dbg!`)
- #155130 (Stabilize feature `isolate_most_least_significant_one`)
- #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
- #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-borsBot
commented
Apr 11, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 592c36f (592c36fe3d8c8acbfd33859bb83ffb6348f5420a, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@scottmcm
scottmcm
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Over 5 hours? That's not good...
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
💥 Test timed out after 21600s
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
@bors try jobs=dist-x86_64-linux
Let's see if it'll pass a try job; this is the only job that didn't succeed. We've got plenty of time as a new rollup is now running followed by a rollup=never.
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 12, 2026
@bors
Auto merge of#155166- JonathanBrouwer:rollup-YH2oUIz, r=<try>
8599522
Rollup of 6 pull requests
try-job: dist-x86_64-linux
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8599522 (85995229c13981e0afc2f0d4ff6252d1ecd36342, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)
@jhpratt
jhpratt
commented
Apr 12, 2026

Copy link


Copy Markdown

Member
Seems spurious then?
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 12, 2026
@rust-bors
rust-borsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 8m 25s

Pushing d32e620 to main...
@rust-bors
rust-borsBot
merged commit d32e620
into
rust-lang:mainApr 12, 2026

13 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 12, 2026
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#154925Make Box/Rc/Arc::into_array allocator-aware (and add doctes…9f43c6eceee2993ae2f6e55dbb33d1dad33fc768 (link)
#154967Test(lib/sync): Fix test_rwlock_max_readers for x86 Win7c3bbeb06c46d642f6b3223b1eea57f9f3053a323 (link)
#154994don't leak internal temporaries from dbg!e4b56c72170221d32f3118003a3fc4ee7f27fbcb (link)
#155057Update libc to v0.2.184ff49784ae51b8bebb9055453d84cc8d85c985e0e (link)
#155063ty::Alias: replace def_id: did with def_idd5877f92b2d19fb01bbec2ebed270ae02b6527c6 (link)
#155130Stabilize feature isolate_most_least_significant_onea924f8e9854a709e9390b2567ac43602295590c6 (link)
previous master: 6ad4d1b0e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Apr 12, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6ad4d1b (parent) -> d32e620 (this PR)
Test differences
Show 9570 test diffs

Stage 1
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J0)
Stage 2
  • macros::tests::no_leaking_internal_temps_from_dbg: [missing] -> pass (J1)
Additionally, 9568 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d32e620a107b5b3dccd9ddb53fa124956a92b589 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-msvc-2: 1h 54m -> 2h 28m (+29.5%)
  2. x86_64-msvc-ext1: 1h 38m -> 2h 6m (+28.6%)
  3. dist-aarch64-apple: 1h 44m -> 2h 5m (+20.6%)
  4. pr-check-1: 33m 6s -> 26m 30s (-19.9%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 2h 19m (-14.6%)
  6. x86_64-gnu-aux: 2h 23m -> 2h 3m (-13.8%)
  7. dist-aarch64-llvm-mingw: 1h 58m -> 1h 42m (-13.8%)
  8. x86_64-gnu-llvm-22-2: 1h 37m -> 1h 24m (-13.7%)
  9. x86_64-gnu-gcc: 1h 7m -> 58m 34s (-13.3%)
  10. aarch64-gnu-llvm-21-1: 1h 4m -> 56m 58s (-12.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 12, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (d32e620): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		0.1%[0.0%, 0.2%]4
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary -2.2%, secondary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.7%[3.4%, 6.0%]2
Improvements ✅ 
 (primary)		-2.2%[-2.2%, -2.2%]1
Improvements ✅ 
 (secondary)		-2.6%[-2.6%, -2.6%]1
All ❌✅ (primary)-2.2%[-2.2%, -2.2%]1
Cycles
Results (primary -5.0%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		3.9%[3.9%, 3.9%]1
Regressions ❌ 
 (secondary)		10.4%[2.1%, 27.0%]3
Improvements ✅ 
 (primary)		-7.2%[-12.2%, -2.6%]4
Improvements ✅ 
 (secondary)		-4.0%[-5.8%, -2.3%]2
All ❌✅ (primary)-5.0%[-12.2%, 3.9%]5
Binary size
This perf run didn't have relevant results for this metric.
Bootstrap: 488.442s -> 489.526s (0.22%)
Artifact size: 394.16 MiB -> 394.19 MiB (0.01%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-YH2oUIz

branch
August 21, 2026 08:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

11 participants

@JonathanBrouwer@scottmcm@jhpratt@rust-timer@rustbot@zachs18@PaulDance@dianne@surban@okaneco@josetorrs