Uh oh!
There was an error while loading. Please reload this page.
remove gate macros from BUILTIN_ATTRIBUTES - #155302
Draft
Bryntet wants to merge 3 commits into
Draft
Conversation
Bryntet
commented
Apr 14, 2026
Comment on lines
-158
to
-166
| let attr_info = attr.name().and_then(|name| BUILTIN_ATTRIBUTE_MAP.get(&name)); | ||
| // Check feature gates for built-in attributes. | ||
| if let Some(BuiltinAttribute { | ||
| gate: AttributeGate::Gated { feature, message, check, notes, .. }, | ||
| .. | ||
| }) = attr_info | ||
| { | ||
| gate_alt!(self, check(self.features), *feature, attr.span, *message, *notes); | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
this logic is moved to rustc_attr_parsing/src/feature_gate.rs which gets called from rustc_attr_parsing/src/interface.rs
rust-log-analyzer
commented
Apr 14, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
mejrs
reviewed
Apr 15, 2026
Member
There was a problem hiding this comment.
I don't have time to fully parse everything rn, just a question. If the gate is Gated::Ignore, is the attribute parser still called? i.e. is this code
rust/compiler/rustc_attr_parsing/src/attributes/diagnostic/on_move.rs
Lines 26 to 28 in 57cb10a
Comment on lines
+496
to
+502
| pub fn is_stable_diagnostic_attribute(sym: Symbol, features: &Features) -> bool { | ||
| match sym { | ||
| sym::on_unimplemented | sym::do_not_recommend => true, | ||
| sym::on_const => features.diagnostic_on_const(), | ||
| sym::on_move => features.diagnostic_on_move(), | ||
| _ => false, | ||
| } |
Member
There was a problem hiding this comment.
This was removed in #155209, this looks like you accidentally resurrected it.
| #[derive(Clone, Debug, Copy)] | ||
| pub enum GateKind { | ||
| Error, | ||
| Ignore, |
Member
There was a problem hiding this comment.
Is Ignore only used for diagnostic attr feature gates? (Please add a comment).
Contributor
☔ The latest upstream changes (presumably #155207) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft for removing
gated!,ungated!andrustc_attr!macros fromBUILTIN_ATTRIBUTES