Skip to content

Bump bootstrap to 1.96 beta - #155335

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Mark-Simulacrum:bootstrap-bump
Apr 17, 2026
Merged

Bump bootstrap to 1.96 beta#155335
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Mark-Simulacrum:bootstrap-bump

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Apr 15, 2026

Copy link
Copy Markdown
Member

See https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday

I think this will wind up needing another PR in a week or so when we pick up assert_matches getting destabilized in beta? But that seems like it can be split into its own PR.

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Apr 15, 2026
@Mark-Simulacrum
Mark-Simulacrum marked this pull request as ready for review April 16, 2026 01:40
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2026
@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2026
@rustbot

rustbot commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from jhpratt, scottmcm

@jieyouxujieyouxu self-assigned this Apr 16, 2026
jieyouxu
jieyouxu reviewed Apr 16, 2026
View reviewed changes

@jieyouxujieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 2 more places and a tiny nit, r=me after

@rustbot author

View changes since this review

Comment threadcompiler/rustc_feature/src/unstable.rs
Comment threadcompiler/rustc_feature/src/unstable.rs
Comment threadcompiler/rustc_lint_defs/src/builtin.rs Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2026
@jieyouxu

jieyouxu commented Apr 16, 2026

Copy link
Copy Markdown
Member

Thanks. One thing #155335 (comment), r=me otherwise

@leon-xdleon-xd mentioned this pull request Apr 16, 2026
Merged
@Mark-Simulacrum

Mark-Simulacrum commented Apr 16, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a64c420 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026
@ZalatharZalathar mentioned this pull request Apr 17, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Apr 17, 2026
@bors
Auto merge of#155416- Zalathar:rollup-D1EWnrR, r=Zalathar
27dbdb5
Rollup of 19 pull requests
Successful merges:
- #141633 (Suggest to bind `self.x` to `x` when field `x` may be in format string)
- #152980 (c-variadic: fix implementation on `avr`)
- #154491 (Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug))
- #155318 (Use mutable pointers for Unix path buffers)
- #155335 (Bump bootstrap to 1.96 beta)
- #155354 (Remove AttributeSafety from BUILTIN_ATTRIBUTES)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155095 (changed the information provided by (mut x) to mut x (Fix 155030))
- #155305 (Make `convert_while_ascii` unsafe)
- #155358 (ImproperCTypes: Move erasing_region_normalisation into helper function)
- #155377 (tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs)
- #155383 (Rearrange `rustc_ast_pretty`)
- #155384 (triagebot: notify on diagnostic attribute changes)
- #155386 (Use `box_new` diagnostic item for Box::new suggestions)
- #155391 (Small refactor of `QueryJob::latch` method)
- #155395 (Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc)
- #155396 (`as_ref_unchecked` docs link fix)
- #155411 (compiletest: Remove the `//@ should-ice` directive)
- #155413 (fix: typo in `std::fs::hard_link` documentation)
@rust-bors
rust-borsBot merged commit 6951f83 into rust-lang:mainApr 17, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Apr 17, 2026
@rust-timer
Unrolled build for#155335
d9ff513
Rollup merge of #155335 - Mark-Simulacrum:bootstrap-bump, r=jieyouxu
Bump bootstrap to 1.96 beta
See https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday
I think this will wind up needing another PR in a week or so when we pick up assert_matches getting destabilized in beta? But that seems like it can be split into its own PR.
@Mark-Simulacrum
Mark-Simulacrum deleted the bootstrap-bump branch April 17, 2026 22:58
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 20, 2026
@bors
Auto merge of #155416 - Zalathar:rollup-D1EWnrR, r=Zalathar
b0abb4d
Rollup of 19 pull requests
Successful merges:
- rust-lang/rust#141633 (Suggest to bind `self.x` to `x` when field `x` may be in format string)
- rust-lang/rust#152980 (c-variadic: fix implementation on `avr`)
- rust-lang/rust#154491 (Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug))
- rust-lang/rust#155318 (Use mutable pointers for Unix path buffers)
- rust-lang/rust#155335 (Bump bootstrap to 1.96 beta)
- rust-lang/rust#155354 (Remove AttributeSafety from BUILTIN_ATTRIBUTES)
- rust-lang/rust#154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- rust-lang/rust#155095 (changed the information provided by (mut x) to mut x (Fix 155030))
- rust-lang/rust#155305 (Make `convert_while_ascii` unsafe)
- rust-lang/rust#155358 (ImproperCTypes: Move erasing_region_normalisation into helper function)
- rust-lang/rust#155377 (tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs)
- rust-lang/rust#155383 (Rearrange `rustc_ast_pretty`)
- rust-lang/rust#155384 (triagebot: notify on diagnostic attribute changes)
- rust-lang/rust#155386 (Use `box_new` diagnostic item for Box::new suggestions)
- rust-lang/rust#155391 (Small refactor of `QueryJob::latch` method)
- rust-lang/rust#155395 (Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc)
- rust-lang/rust#155396 (`as_ref_unchecked` docs link fix)
- rust-lang/rust#155411 (compiletest: Remove the `//@ should-ice` directive)
- rust-lang/rust#155413 (fix: typo in `std::fs::hard_link` documentation)
@cuvipercuviper added this to the 1.97.0 milestone Apr 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxuAwaiting requested review from jieyouxu

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Mark-Simulacrum@rustbot@jieyouxu@cuviper@jhpratt