Skip to content

Use singular wording for single _ placeholders in type suggestions - #155561

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cijiugechu:fix/need-type-info-underscore-wording
Apr 23, 2026
Merged

Use singular wording for single _ placeholders in type suggestions#155561
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cijiugechu:fix/need-type-info-underscore-wording

Conversation

@cijiugechu

Copy link
Copy Markdown
Member

While looking this part of code, I noticed this FIXME and fixed it :)

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in need_type_info.rs

cc @lcnr

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@adwinwhite

Copy link
Copy Markdown
Contributor

Thanks!
@bors r+ rollup

@rust-bors

rust-borsBot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ffcbfc1 has been approved by adwinwhite

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 23, 2026
Rollup of 7 pull requests
Successful merges:
- #155469 (Account for titlecase in casing lints)
- #155644 (delegation: support self ty propagation for functions in free to trait reuse)
- #154957 (Fix ICE when const closure appears inside a non-const trait method)
- #155442 (Change keyword order for `impl` restrictions)
- #155561 (Use singular wording for single _ placeholders in type suggestions)
- #155637 (Fix E0191 suggestion for empty dyn trait args)
- #155661 (Remove `AttributeLintKind` variants - part 6)
@rust-bors
rust-borsBot merged commit 8c3864b into rust-lang:mainApr 23, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 23, 2026
rust-timer added a commit that referenced this pull request Apr 23, 2026
Rollup merge of #155561 - cijiugechu:fix/need-type-info-underscore-wording, r=adwinwhite
Use singular wording for single _ placeholders in type suggestions
While looking this part of code, I noticed this FIXME and fixed it :)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#155469 (Account for titlecase in casing lints)
- rust-lang/rust#155644 (delegation: support self ty propagation for functions in free to trait reuse)
- rust-lang/rust#154957 (Fix ICE when const closure appears inside a non-const trait method)
- rust-lang/rust#155442 (Change keyword order for `impl` restrictions)
- rust-lang/rust#155561 (Use singular wording for single _ placeholders in type suggestions)
- rust-lang/rust#155637 (Fix E0191 suggestion for empty dyn trait args)
- rust-lang/rust#155661 (Remove `AttributeLintKind` variants - part 6)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cijiugechu@rustbot@adwinwhite