[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache by fmease · Pull Request #156355 · rust-lang/rust

fmease · 2026-05-09T09:40:20Z

fmease · 2026-05-09T09:40:49Z

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

fmease · 2026-05-09T09:45:20Z

+ //FIXME: Allegedly, we might actually typeck code here that's cfg'ed out
+ // which could lead to errors getting reported which would be wild.
+ // Re-audit this! Do we have any tests demonstrating this?


(it doesn't affect cfg'ed out code, it just means we're type-checking bodies which we usually don't do; it means we can't document std)
View changes since the review

rust-bors · 2026-05-09T11:49:41Z

☀️ Try build successful (CI)
Build commit: 69577e4 (69577e4cf0bb04efb4088734375caed2632e4c70, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

rust-timer · 2026-05-09T12:31:30Z

Finished benchmarking commit (69577e4): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	15.8%	[2.1%, 43.6%]	19
Regressions ❌ (secondary)	13.1%	[0.3%, 120.7%]	19
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	15.8%	[2.1%, 43.6%]	19

Max RSS (memory usage)

Results (primary 5.4%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.4%	[1.5%, 14.9%]	16
Regressions ❌ (secondary)	4.2%	[1.4%, 8.7%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.4%	[1.5%, 14.9%]	16

Cycles

Results (primary 20.6%, secondary 15.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	20.6%	[2.9%, 55.9%]	19
Regressions ❌ (secondary)	15.8%	[2.2%, 102.7%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	20.6%	[2.9%, 55.9%]	19

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 498.488s (0.11%)
Artifact size: 397.14 MiB -> 397.08 MiB (-0.01%)

fmease · 2026-05-10T10:00:37Z

This one is a real perf improvement over baseline PR #156348 (of course overall, this feature is extremely costly). See for example:

Benchmark	Profile	Scenario	Backend	Target	% Change	Significance Threshold	Significance Factor
nalgebra-0.33.0	doc	full	llvm	x64	-5.69%	0.20%	28.44x
diesel-2.2.10	doc	full	llvm	x64	-3.13%	0.20%	15.65x
stm32f4-0.15.1	doc	full	llvm	x64	-0.49%	0.20%	2.43x
typenum-1.18.0	doc	full	llvm	x64	-0.41%	0.20%	2.03x
hyper-1.6.0	doc	full	llvm	x64	-0.34%	0.20%	1.71x
cranelift-codegen-0.119.0	doc	full	llvm	x64	-0.34%	0.20%	1.68x

nalgebra-0.33.0:

Query/Function	Time (%)	Time (s)	Time delta	Executions	Executions delta	Hits	Hits delta
Totals	109.93%	2.198	-0.125 (-5.4%)	1614385	-5363 (-0.3%)	17019283	-1401012 (-7.6%)
typeck_root	16.23%	0.357	-0.092 (-20.5%)	1764	-894 (-33.6%)	397	-6754 (-94.4%)
...	...	...	...	...	...	...	...

…e it always is `rustc_resolve` doesn't resolve type-relative paths since that's the job of HIR ty lowering and HIR typeck. `segment.res` comes from `rustc_resolve` and is thus always `Res::Err`. So just try to obtain the `TypeckResults` immediately since they contain the actual resolution as deduced by HIR typeck.

fmease · 2026-05-10T19:06:24Z

NEW: We no longer special-case ExprKind::Call meaning we no longer needlessly obtain the type-dependent definition of callees that are Resolved paths which allows us to skip typecking the body entirely if the body doesn't contain any type-relative paths.

fmease · 2026-05-10T19:06:37Z

@bors try parent=last @rust-timer queue

fmease · 2026-05-11T12:11:41Z

@bors try parent=last @rust-timer queue

[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

rust-bors · 2026-05-11T14:19:45Z

☀️ Try build successful (CI)
Build commit: 78d15de (78d15de5525370011388c8f63847e873c4de14ed, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

rust-timer · 2026-05-11T15:03:30Z

Finished benchmarking commit (78d15de): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	14.9%	[1.7%, 41.9%]	19
Regressions ❌ (secondary)	11.8%	[0.2%, 120.0%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	14.9%	[1.7%, 41.9%]	19

Max RSS (memory usage)

Results (primary 5.3%, secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.3%	[1.2%, 15.4%]	16
Regressions ❌ (secondary)	4.8%	[1.4%, 9.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.3%	[1.2%, 15.4%]	16

Cycles

Results (primary 18.7%, secondary 16.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	18.7%	[2.3%, 52.6%]	20
Regressions ❌ (secondary)	16.6%	[2.1%, 101.2%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	18.7%	[2.3%, 52.6%]	20

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 500.833s (0.58%)
Artifact size: 397.14 MiB -> 397.12 MiB (-0.00%)

fmease · 2026-05-11T15:41:05Z

It's getting even better:

Compared to baseline PR #156348: https://perf.rust-lang.org/compare.html?start=68c2bff6cb08a87e59246064a6a9f37098e22c3f&end=78d15de5525370011388c8f63847e873c4de14ed&stat=instructions%3Au
Compared to previous version of this PR: https://perf.rust-lang.org/compare.html?start=69577e4cf0bb04efb4088734375caed2632e4c70&end=78d15de5525370011388c8f63847e873c4de14ed&stat=instructions%3Au

fmease · 2026-05-11T15:49:42Z

Compared to baseline:

Primary:

Benchmark	Profile	Scenario	Backend	Target	% Change	Significance Threshold	Significance Factor
nalgebra-0.33.0	doc	full	llvm	x64	-5.82%	0.20%	29.09x
diesel-2.2.10	doc	full	llvm	x64	-3.41%	0.20%	17.05x
image-0.25.6	doc	full	llvm	x64	-2.03%	0.20%	10.16x
regex-automata-0.4.8	doc	full	llvm	x64	-1.94%	0.20%	9.71x
cargo-0.87.1	doc	full	llvm	x64	-1.64%	0.20%	8.21x
clap_derive-4.5.32	doc	full	llvm	x64	-1.63%	0.20%	8.14x
cranelift-codegen-0.119.0	doc	full	llvm	x64	-1.48%	0.20%	7.41x
syn-2.0.101	doc	full	llvm	x64	-1.07%	0.20%	5.35x
ripgrep-14.1.1	doc	full	llvm	x64	-0.96%	0.20%	4.78x
stm32f4-0.15.1	doc	full	llvm	x64	-0.80%	0.20%	4.01x
serde-1.0.219	doc	full	llvm	x64	-0.67%	0.20%	3.33x
hyper-1.6.0	doc	full	llvm	x64	-0.66%	0.20%	3.30x
eza-0.21.2	doc	full	llvm	x64	-0.55%	0.20%	2.74x
unicode-normalization-0.1.24	doc	full	llvm	x64	-0.49%	0.20%	2.45x
serde_derive-1.0.219	doc	full	llvm	x64	-0.45%	0.20%	2.26x
typenum-1.18.0	doc	full	llvm	x64	-0.42%	0.20%	2.08x
bitmaps-3.2.1	doc	full	llvm	x64	-0.32%	0.20%	1.61x

Secondary:

Benchmark	Profile	Scenario	Backend	Target	% Change	Significance Threshold	Significance Factor
deep-vector	doc	full	llvm	x64	-23.96%	0.20%	119.78x
large-workspace	doc	full	llvm	x64	-2.16%	0.20%	10.81x
deeply-nested-multi	doc	full	llvm	x64	-1.35%	0.20%	6.75x
serde-1.0.219-threads4	doc	full	llvm	x64	-0.67%	0.20%	3.33x
wg-grammar	doc	full	llvm	x64	-0.32%	0.20%	1.62x
tt-muncher	opt	full	llvm	x64	-0.31%	0.20%	1.56x

nalgebra-0.33.0:

Query/Function	Time (%)	Time (s)	Time delta	Executions	Executions delta	Hits	Hits delta
Totals	109.57%	2.185	-0.138 (-5.9%)	1614146	-5602 (-0.3%)	16983840	-1436455 (-7.8%)
typeck_root	15.75%	0.344	-0.105 (-23.4%)	1704	-954 (-35.9%)	393	-6758 (-94.5%)
...	...	...	...	...	...	...	...

fmease · 2026-05-11T16:31:15Z

Hopefully final perf run...

@bors try parent=last @rust-timer queue

[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

rust-bors · 2026-05-11T18:41:20Z

☀️ Try build successful (CI)
Build commit: 1a5dfbb (1a5dfbb3f6a9ff1e5aec8eca78eadaa8c830014d, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

rust-timer · 2026-05-11T19:25:39Z

Finished benchmarking commit (1a5dfbb): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	14.9%	[1.7%, 42.0%]	19
Regressions ❌ (secondary)	11.8%	[0.2%, 120.0%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	14.9%	[1.7%, 42.0%]	19

Max RSS (memory usage)

Results (primary 5.4%, secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.4%	[1.5%, 14.9%]	15
Regressions ❌ (secondary)	4.1%	[1.2%, 8.6%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.4%	[1.5%, 14.9%]	15

Cycles

Results (primary 19.3%, secondary 18.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	19.3%	[2.0%, 52.2%]	19
Regressions ❌ (secondary)	18.1%	[2.0%, 101.5%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	19.3%	[2.0%, 52.2%]	19

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 497.528s (-0.08%)
Artifact size: 397.14 MiB -> 397.14 MiB (0.00%)

…laumeGomez rustdoc: Correctness & perf improvements to link-to-definition Rewrite the way we resolve type-dependent paths (incl. method calls) in `SpanMapVisitor`. Instead of trying to (re)find the enclosing body owner each time we encounter such a node, potentially calling `typeck_body` several times per body, keep track of the "active" `BodyId` in the visitor and cache the corresponding `TypeckResults`. The "active" `BodyId` is updated in `visit_nested_body` (add) and in `visit_item` (remove). This fixes a class of ICEs where we tried to look up the definition of type-relative paths located in non-body items nested in bodies, in the overarching body which is never correct. rustdoc@main has a hack to fix this issue for paths specifically found in assoc types in impls. Fixesrust-lang#147882. Fixesrust-lang#147057. Fixesrust-lang#155327. Fixesrust-lang#149089. Fixesrust-lang#150153. Supersedes rust-lang#147911. --- `--generate-link-to-definition` is not enabled by default, so we can't perf this as is. Instead, I'm benching them against PR rust-lang#156348 in PR rust-lang#156355 using the same parent commit for the try-builds. For context, LTD is *extremely* costly as the perf run for the baseline PR shows: rust-lang#156348 (comment). "Absolute results": rust-lang#156355 (comment). "Relative results": [https://perf.rust-lang.org/compare.html?...](https://perf.rust-lang.org/compare.html?start=68c2bff6cb08a87e59246064a6a9f37098e22c3f&end=78d15de5525370011388c8f63847e873c4de14ed&stat=instructions%3Au). Excerpt of the relative results: Primary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- nalgebra-0.33.0 | doc | full | llvm | x64 | -5.82% | 0.20% | 29.09x diesel-2.2.10 | doc | full | llvm | x64 | -3.41% | 0.20% | 17.05x image-0.25.6 | doc | full | llvm | x64 | -2.03% | 0.20% | 10.16x regex-automata-0.4.8 | doc | full | llvm | x64 | -1.94% | 0.20% | 9.71x cargo-0.87.1 | doc | full | llvm | x64 | -1.64% | 0.20% | 8.21x clap_derive-4.5.32 | doc | full | llvm | x64 | -1.63% | 0.20% | 8.14x cranelift-codegen-0.119.0 | doc | full | llvm | x64 | -1.48% | 0.20% | 7.41x syn-2.0.101 | doc | full | llvm | x64 | -1.07% | 0.20% | 5.35x ripgrep-14.1.1 | doc | full | llvm | x64 | -0.96% | 0.20% | 4.78x stm32f4-0.15.1 | doc | full | llvm | x64 | -0.80% | 0.20% | 4.01x serde-1.0.219 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x hyper-1.6.0 | doc | full | llvm | x64 | -0.66% | 0.20% | 3.30x eza-0.21.2 | doc | full | llvm | x64 | -0.55% | 0.20% | 2.74x unicode-normalization-0.1.24 | doc | full | llvm | x64 | -0.49% | 0.20% | 2.45x serde_derive-1.0.219 | doc | full | llvm | x64 | -0.45% | 0.20% | 2.26x typenum-1.18.0 | doc | full | llvm | x64 | -0.42% | 0.20% | 2.08x bitmaps-3.2.1 | doc | full | llvm | x64 | -0.32% | 0.20% | 1.61x Secondary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- deep-vector | doc | full | llvm | x64 | -23.96% | 0.20% | 119.78x large-workspace | doc | full | llvm | x64 | -2.16% | 0.20% | 10.81x deeply-nested-multi | doc | full | llvm | x64 | -1.35% | 0.20% | 6.75x serde-1.0.219-threads4 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x wg-grammar | doc | full | llvm | x64 | -0.32% | 0.20% | 1.62x tt-muncher | opt | full | llvm | x64 | -0.31% | 0.20% | 1.56x nalgebra-0.33.0: Query/Function | Time (%) | Time (s) | Time delta | Executions | Executions delta | Hits | Hits delta ---|---|---|---|---|---|---|--- Totals | 109.57% | 2.185 | -0.138 (-5.9%) | 1614146 | -5602 (-0.3%) | 16983840 | -1436455 (-7.8%) typeck_root | 15.75% | 0.344 | -0.105 (-23.4%) | 1704 | -954 (-35.9%) | 393 | -6758 (-94.5%) ...|...|...|...|...|...|...|...

…laumeGomez rustdoc: Correctness & perf improvements to link-to-definition Rewrite the way we resolve type-dependent paths (incl. method calls) in `SpanMapVisitor`. Instead of trying to (re)find the enclosing body owner each time we encounter such a node, potentially calling `typeck_body` several times per body, keep track of the "active" `BodyId` in the visitor and cache the corresponding `TypeckResults`. The "active" `BodyId` is updated in `visit_nested_body` (add) and in `visit_item` (remove). This fixes a class of ICEs where we tried to look up the definition of type-relative paths located in non-body items nested in bodies, in the overarching body which is never correct. rustdoc@main has a hack to fix this issue for paths specifically found in assoc types in impls. Fixesrust-lang#147882. Fixesrust-lang#147057. Fixesrust-lang#155327. Fixesrust-lang#149089. Fixesrust-lang#150153. Fixesrust-lang#156418. Supersedes rust-lang#147911. --- `--generate-link-to-definition` is not enabled by default, so we can't perf this as is. Instead, I'm benching them against PR rust-lang#156348 in PR rust-lang#156355 using the same parent commit for the try-builds. For context, LTD is *extremely* costly as the perf run for the baseline PR shows: rust-lang#156348 (comment). "Absolute results": rust-lang#156355 (comment). "Relative results": [https://perf.rust-lang.org/compare.html?...](https://perf.rust-lang.org/compare.html?start=68c2bff6cb08a87e59246064a6a9f37098e22c3f&end=78d15de5525370011388c8f63847e873c4de14ed&stat=instructions%3Au). Excerpt of the relative results: Primary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- nalgebra-0.33.0 | doc | full | llvm | x64 | -5.82% | 0.20% | 29.09x diesel-2.2.10 | doc | full | llvm | x64 | -3.41% | 0.20% | 17.05x image-0.25.6 | doc | full | llvm | x64 | -2.03% | 0.20% | 10.16x regex-automata-0.4.8 | doc | full | llvm | x64 | -1.94% | 0.20% | 9.71x cargo-0.87.1 | doc | full | llvm | x64 | -1.64% | 0.20% | 8.21x clap_derive-4.5.32 | doc | full | llvm | x64 | -1.63% | 0.20% | 8.14x cranelift-codegen-0.119.0 | doc | full | llvm | x64 | -1.48% | 0.20% | 7.41x syn-2.0.101 | doc | full | llvm | x64 | -1.07% | 0.20% | 5.35x ripgrep-14.1.1 | doc | full | llvm | x64 | -0.96% | 0.20% | 4.78x stm32f4-0.15.1 | doc | full | llvm | x64 | -0.80% | 0.20% | 4.01x serde-1.0.219 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x hyper-1.6.0 | doc | full | llvm | x64 | -0.66% | 0.20% | 3.30x eza-0.21.2 | doc | full | llvm | x64 | -0.55% | 0.20% | 2.74x unicode-normalization-0.1.24 | doc | full | llvm | x64 | -0.49% | 0.20% | 2.45x serde_derive-1.0.219 | doc | full | llvm | x64 | -0.45% | 0.20% | 2.26x typenum-1.18.0 | doc | full | llvm | x64 | -0.42% | 0.20% | 2.08x bitmaps-3.2.1 | doc | full | llvm | x64 | -0.32% | 0.20% | 1.61x Secondary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- deep-vector | doc | full | llvm | x64 | -23.96% | 0.20% | 119.78x large-workspace | doc | full | llvm | x64 | -2.16% | 0.20% | 10.81x deeply-nested-multi | doc | full | llvm | x64 | -1.35% | 0.20% | 6.75x serde-1.0.219-threads4 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x wg-grammar | doc | full | llvm | x64 | -0.32% | 0.20% | 1.62x tt-muncher | opt | full | llvm | x64 | -0.31% | 0.20% | 1.56x nalgebra-0.33.0: Query/Function | Time (%) | Time (s) | Time delta | Executions | Executions delta | Hits | Hits delta ---|---|---|---|---|---|---|--- Totals | 109.57% | 2.185 | -0.138 (-5.9%) | 1614146 | -5602 (-0.3%) | 16983840 | -1436455 (-7.8%) typeck_root | 15.75% | 0.344 | -0.105 (-23.4%) | 1704 | -954 (-35.9%) | 393 | -6758 (-94.5%) ...|...|...|...|...|...|...|...

Rollup merge of #156413 - fmease:rustdoc-ltd-improvs, r=GuillaumeGomez rustdoc: Correctness & perf improvements to link-to-definition Rewrite the way we resolve type-dependent paths (incl. method calls) in `SpanMapVisitor`. Instead of trying to (re)find the enclosing body owner each time we encounter such a node, potentially calling `typeck_body` several times per body, keep track of the "active" `BodyId` in the visitor and cache the corresponding `TypeckResults`. The "active" `BodyId` is updated in `visit_nested_body` (add) and in `visit_item` (remove). This fixes a class of ICEs where we tried to look up the definition of type-relative paths located in non-body items nested in bodies, in the overarching body which is never correct. rustdoc@main has a hack to fix this issue for paths specifically found in assoc types in impls. Fixes#147882. Fixes#147057. Fixes#155327. Fixes#149089. Fixes#150153. Fixes#156418. Supersedes #147911. --- `--generate-link-to-definition` is not enabled by default, so we can't perf this as is. Instead, I'm benching them against PR #156348 in PR #156355 using the same parent commit for the try-builds. For context, LTD is *extremely* costly as the perf run for the baseline PR shows: #156348 (comment). "Absolute results": #156355 (comment). "Relative results": [https://perf.rust-lang.org/compare.html?...](https://perf.rust-lang.org/compare.html?start=68c2bff6cb08a87e59246064a6a9f37098e22c3f&end=78d15de5525370011388c8f63847e873c4de14ed&stat=instructions%3Au). Excerpt of the relative results: Primary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- nalgebra-0.33.0 | doc | full | llvm | x64 | -5.82% | 0.20% | 29.09x diesel-2.2.10 | doc | full | llvm | x64 | -3.41% | 0.20% | 17.05x image-0.25.6 | doc | full | llvm | x64 | -2.03% | 0.20% | 10.16x regex-automata-0.4.8 | doc | full | llvm | x64 | -1.94% | 0.20% | 9.71x cargo-0.87.1 | doc | full | llvm | x64 | -1.64% | 0.20% | 8.21x clap_derive-4.5.32 | doc | full | llvm | x64 | -1.63% | 0.20% | 8.14x cranelift-codegen-0.119.0 | doc | full | llvm | x64 | -1.48% | 0.20% | 7.41x syn-2.0.101 | doc | full | llvm | x64 | -1.07% | 0.20% | 5.35x ripgrep-14.1.1 | doc | full | llvm | x64 | -0.96% | 0.20% | 4.78x stm32f4-0.15.1 | doc | full | llvm | x64 | -0.80% | 0.20% | 4.01x serde-1.0.219 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x hyper-1.6.0 | doc | full | llvm | x64 | -0.66% | 0.20% | 3.30x eza-0.21.2 | doc | full | llvm | x64 | -0.55% | 0.20% | 2.74x unicode-normalization-0.1.24 | doc | full | llvm | x64 | -0.49% | 0.20% | 2.45x serde_derive-1.0.219 | doc | full | llvm | x64 | -0.45% | 0.20% | 2.26x typenum-1.18.0 | doc | full | llvm | x64 | -0.42% | 0.20% | 2.08x bitmaps-3.2.1 | doc | full | llvm | x64 | -0.32% | 0.20% | 1.61x Secondary: Benchmark | Profile | Scenario | Backend | Target | % Change | Significance Threshold | Significance Factor ---|---|---|---|---|---|---|--- deep-vector | doc | full | llvm | x64 | -23.96% | 0.20% | 119.78x large-workspace | doc | full | llvm | x64 | -2.16% | 0.20% | 10.81x deeply-nested-multi | doc | full | llvm | x64 | -1.35% | 0.20% | 6.75x serde-1.0.219-threads4 | doc | full | llvm | x64 | -0.67% | 0.20% | 3.33x wg-grammar | doc | full | llvm | x64 | -0.32% | 0.20% | 1.62x tt-muncher | opt | full | llvm | x64 | -0.31% | 0.20% | 1.56x nalgebra-0.33.0: Query/Function | Time (%) | Time (s) | Time delta | Executions | Executions delta | Hits | Hits delta ---|---|---|---|---|---|---|--- Totals | 109.57% | 2.185 | -0.138 (-5.9%) | 1614146 | -5602 (-0.3%) | 16983840 | -1436455 (-7.8%) typeck_root | 15.75% | 0.344 | -0.105 (-23.4%) | 1704 | -954 (-35.9%) | 393 | -6758 (-94.5%) ...|...|...|...|...|...|...|...

rust-bors · 2026-05-14T05:11:19Z

☔ The latest upstream changes (presumably #156559) made this pull request unmergeable. Please resolve the merge conflicts.

fmease added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 9, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 9, 2026

rust-borsBot pushed a commit that referenced this pull request May 9, 2026
Auto merge of#156355- fmease:rustdoc-ltd-lazy-cached-typck, r=<try>
69577e4
[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

This was referenced May 9, 2026
[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies #156349
Closed
[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition#156348
Closed

fmease commented May 9, 2026
View reviewed changes

fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2026

This comment has been minimized.
Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 9, 2026

fmease mentioned this pull request May 10, 2026
rustdoc: Correctness & perf improvements to link-to-definition #156413
Merged

fmease force-pushed the rustdoc-ltd-lazy-cached-typck branch from 4da0f6c to 78960acCompare May 10, 2026 18:55

fmease added 3 commits May 10, 2026 20:59

rustdoc: SpanMapVisitor: Cache TypeckResults
0a0a0b1

Slightly refactor the way we handle type-dependent defs
330459c

fmease force-pushed the rustdoc-ltd-lazy-cached-typck branch from 78960ac to fc18b43Compare May 10, 2026 19:04

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 11, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request May 11, 2026
Auto merge of#156355- fmease:rustdoc-ltd-lazy-cached-typck, r=<try>
78d15de
[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 11, 2026

fmease added 2 commits May 11, 2026 18:20

Unset cached_typeck_results when crossing item boundary
ddf589a

Introduce type LazyTypeckResults
9694a8d

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 11, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request May 11, 2026
Auto merge of#156355- fmease:rustdoc-ltd-lazy-cached-typck, r=<try>
1a5dfbb
[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 11, 2026

fmease closed this May 14, 2026

fmease deleted the rustdoc-ltd-lazy-cached-typck branch May 14, 2026 06:34

Uh oh!

Uh oh!

Conversation

fmease commented May 9, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented May 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

fmeaseMay 9, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented May 9, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 9, 2026

Overall result: ❌ regressions - please read:

Uh oh!

fmease commented May 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented May 10, 2026

Uh oh!

fmease commented May 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

fmease commented May 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented May 11, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 11, 2026

Overall result: ❌ regressions - please read:

Uh oh!

fmease commented May 11, 2026

Uh oh!

fmease commented May 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented May 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented May 11, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 11, 2026

Overall result: ❌ regressions - please read:

Uh oh!

rust-borsBot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fmease commented May 9, 2026•
edited by rustbot
Loading

fmeaseMay 9, 2026•
edited by rustbot
Loading

fmease commented May 10, 2026•
edited
Loading

fmease commented May 11, 2026•
edited
Loading