suggest hex escapes for C-style escapes by euclio · Pull Request #156376 · rust-lang/rust

euclio · 2026-05-09T21:42:48Z

rustbot · 2026-05-09T21:42:51Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

rustbot · 2026-05-09T21:42:54Z

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

asquared31415 · 2026-05-09T22:57:55Z

I don't think that the "(perhaps transcribing from another language)" part is useful to the diagnostic. It should be clear from context that Rust simply does this differently.

mu001999

Thanks! Just some nits

View changes since this review

mu001999 · 2026-05-10T00:47:47Z

@rustbot author

rustbot · 2026-05-10T00:47:51Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

euclio · 2026-05-10T20:32:35Z

@rustbot ready

mu001999

Thanks!

@bors r+ rollup

View changes since this review

rust-bors · 2026-05-11T02:35:01Z

📌 Commit 08c3cfc has been approved by mu001999

It is now in the queue for this repository.

suggest hex escapes for C-style escapes Fixesrust-lang#148884.

mu001999 · 2026-05-11T05:03:42Z

@bors r-

rust-bors · 2026-05-11T05:03:49Z

This pull request was unapproved.

This PR was contained in a rollup (#156432), which was unapproved.

View changes since this unapproval

mu001999

Just some nits

View changes since this review

rustbot · 2026-05-16T17:50:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

euclio · 2026-05-16T17:51:25Z

@rustbot ready

mu001999

Please check the above comment

@rustbot author

View changes since this review

euclio · 2026-05-17T00:24:39Z

Whoops, fixed!

@rustbot ready

mu001999 · 2026-05-17T00:29:31Z

Thanks!

@bors r+

rust-bors · 2026-05-17T00:29:33Z

📌 Commit e599831 has been approved by mu001999

It is now in the queue for this repository.

suggest hex escapes for C-style escapes Fixesrust-lang#148884.

…uwer Rollup of 14 pull requests Successful merges: - #151742 (Remove redundant information in `rustc_abi::Variants`) - #151362 (Add interior-mutability suggestion to `static_mut_refs`) - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - #156208 (Emit retags in codegen to support BorrowSanitizer (part 1)) - #156596 (Split `LintExpectationId`s) - #156607 (ci: Update FreeBSD version to FreeBSD 14) - #156376 (suggest hex escapes for C-style escapes) - #156577 (Test EII UI tests with prefer-dynamic) - #156585 (explicit tail calls: ignore some tests on unsupported LLVM targets) - #156598 (Avoid rustfix suggestions for macro-expanded unused imports) - #156616 (rustdoc: add test case for `-Drustdoc::` and `--cap-lints`) - #156633 (Add regression test for issue #41261) - #156635 (rename unexpected_try_recover function) - #156636 (minor `rustc_mir_transform` cleanup)

Rollup merge of #156376 - euclio:foreign-escapes, r=mu001999 suggest hex escapes for C-style escapes Fixes#148884.

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#151742 (Remove redundant information in `rustc_abi::Variants`) - rust-lang/rust#151362 (Add interior-mutability suggestion to `static_mut_refs`) - rust-lang/rust#156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - rust-lang/rust#156208 (Emit retags in codegen to support BorrowSanitizer (part 1)) - rust-lang/rust#156596 (Split `LintExpectationId`s) - rust-lang/rust#156607 (ci: Update FreeBSD version to FreeBSD 14) - rust-lang/rust#156376 (suggest hex escapes for C-style escapes) - rust-lang/rust#156577 (Test EII UI tests with prefer-dynamic) - rust-lang/rust#156585 (explicit tail calls: ignore some tests on unsupported LLVM targets) - rust-lang/rust#156598 (Avoid rustfix suggestions for macro-expanded unused imports) - rust-lang/rust#156616 (rustdoc: add test case for `-Drustdoc::` and `--cap-lints`) - rust-lang/rust#156633 (Add regression test for issue rust-lang/rust#41261) - rust-lang/rust#156635 (rename unexpected_try_recover function) - rust-lang/rust#156636 (minor `rustc_mir_transform` cleanup)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2026

rustbot assigned mu001999 May 9, 2026

This comment has been minimized.
Sign in to view

mu001999 reviewed May 10, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

euclio force-pushed the foreign-escapes branch from 774186b to 1ee8da5Compare May 10, 2026 04:15

This comment has been minimized.
Sign in to view

euclio force-pushed the foreign-escapes branch from 1ee8da5 to 08c3cfcCompare May 10, 2026 15:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2026

mu001999 approved these changes May 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 11, 2026
Rollup merge ofrust-lang#156376- euclio:foreign-escapes, r=mu001999
2b01afd
suggest hex escapes for C-style escapes Fixesrust-lang#148884.

JonathanBrouwer mentioned this pull request May 11, 2026
Rollup of 8 pull requests #156432
Closed

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2026

mu001999 reviewed May 11, 2026
View reviewed changes

Comment threadcompiler/rustc_parse/src/lexer/unescape_error_reporting.rs
Comment threadcompiler/rustc_parse/src/lexer/unescape_error_reporting.rs

mu001999 reviewed May 11, 2026
View reviewed changes

Comment threadcompiler/rustc_parse/src/lexer/unescape_error_reporting.rs Outdated

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 15, 2026

euclio force-pushed the foreign-escapes branch from 2c3bd8e to 8338f50Compare May 16, 2026 17:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2026

mu001999 requested changes May 17, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2026

suggest hex escapes for C-style escapes
e599831

euclio force-pushed the foreign-escapes branch from 8338f50 to e599831Compare May 17, 2026 00:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 17, 2026
Rollup merge ofrust-lang#156376- euclio:foreign-escapes, r=mu001999
67d55b1
suggest hex escapes for C-style escapes Fixesrust-lang#148884.

JonathanBrouwer mentioned this pull request May 17, 2026
Rollup of 11 pull requests #156658
Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 17, 2026
Rollup merge ofrust-lang#156376- euclio:foreign-escapes, r=mu001999
5ac3b46
suggest hex escapes for C-style escapes Fixesrust-lang#148884.

This was referenced May 17, 2026
Rollup of 9 pull requests #156663
Closed
Rollup of 14 pull requests #156670
Merged

rust-borsBot merged commit 4bb8551 into rust-lang:mainMay 18, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 18, 2026

rust-timer added a commit that referenced this pull request May 18, 2026
Unrolled build for#156376
79e3c74
Rollup merge of #156376 - euclio:foreign-escapes, r=mu001999 suggest hex escapes for C-style escapes Fixes#148884.

Uh oh!

Uh oh!

Conversation

euclio commented May 9, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 9, 2026

Uh oh!

rustbot commented May 9, 2026

Uh oh!

This comment has been minimized.

asquared31415 commented May 9, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mu001999 commented May 10, 2026

Uh oh!

rustbot commented May 10, 2026

Uh oh!

This comment has been minimized.

euclio commented May 10, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented May 11, 2026

Uh oh!

mu001999 commented May 11, 2026

Uh oh!

rust-borsBot commented May 11, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented May 16, 2026

Uh oh!

euclio commented May 16, 2026

Uh oh!

mu001999 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

euclio commented May 17, 2026

Uh oh!

mu001999 commented May 17, 2026

Uh oh!

rust-borsBot commented May 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

euclio commented May 9, 2026•
edited by rustbot
Loading

mu001999 left a comment •
edited by rustbot
Loading

mu001999 left a comment •
edited by rustbot
Loading

mu001999 left a comment •
edited by rustbot
Loading

mu001999 left a comment •
edited
Loading