Uh oh!
There was an error while loading. Please reload this page.
Add ChildExt::kill_process_group - #156539
Merged
Merged
Conversation
This function wraps POSIX `killpg()`, and on Linux additionally may be implemented by `pidfd_send_signal`.
rustbot
commented
May 13, 2026
Collaborator
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nia-e
requested changes
May 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rustbot
commented
May 13, 2026
Collaborator
Reminder, once the PR becomes ready for a review, use |
This function wraps POSIX `killpg(pid, SIGKILL)`, and on Linux additionally may be implemented by `pidfd_send_signal`.
jmillikinforce-pushed
the
unix-childext-killpg
branch
from
May 13, 2026 13:40
3d3f33e to
7bf5fe7Comparejmillikin
commented
May 13, 2026
ContributorAuthor
@rustbot ready |
nia-e
commented
May 13, 2026
Member
@bors r+ rollup |
Contributor
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 13, 2026
…nia-e Add `ChildExt::kill_process_group` ACP: rust-lang/libs-team#791 Tracking issue: rust-lang#156537
rust-borsBot
pushed a commit
that referenced
this pull request
May 13, 2026
…uwer Rollup of 5 pull requests Successful merges: - #155521 (Add lint againts invalid runtime symbol definitions) - #156500 (Privacy: move macros handling to early stage) - #156413 (rustdoc: Correctness & perf improvements to link-to-definition) - #156539 (Add `ChildExt::kill_process_group`) - #156540 (use `deref_patterns` in `rustdoc` instead of `box_patterns`)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 13, 2026
…nia-e Add `ChildExt::kill_process_group` ACP: rust-lang/libs-team#791 Tracking issue: rust-lang#156537
This was referenced May 13, 2026
rust-borsBot
pushed a commit
that referenced
this pull request
May 13, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156552 (Clippy subtree update) - #156344 (Do not index past end of buffer when checking heuristic in error index syntax highlighter) - #156500 (Privacy: move macros handling to early stage) - #156260 (test: suppress deprecation warning) - #156413 (rustdoc: Correctness & perf improvements to link-to-definition) - #156539 (Add `ChildExt::kill_process_group`) - #156540 (use `deref_patterns` in `rustdoc` instead of `box_patterns`)
rust-borsBot
pushed a commit
that referenced
this pull request
May 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156552 (Clippy subtree update) - #156344 (Do not index past end of buffer when checking heuristic in error index syntax highlighter) - #156500 (Privacy: move macros handling to early stage) - #156260 (test: suppress deprecation warning) - #156413 (rustdoc: Correctness & perf improvements to link-to-definition) - #156539 (Add `ChildExt::kill_process_group`) - #156540 (use `deref_patterns` in `rustdoc` instead of `box_patterns`)
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
May 14, 2026
Rollup merge of #156539 - jmillikin:unix-childext-killpg, r=nia-e Add `ChildExt::kill_process_group` ACP: rust-lang/libs-team#791 Tracking issue: #156537
7 tasks
5 tasks
physwkim added a commit
to physwkim/rust
that referenced
this pull request
Jul 27, 2026
VxWorks has no process groups: the SDK defines no `killpg`, and `getpgrp`/`setpgid` are no-ops in libunix, so `kill(-pgrp, sig)` is no substitute either. libc cannot usefully declare `killpg` for this target, so the call added in rust-lang#156539 leaves the target unable to build std. Return `ErrorKind::Unsupported` instead, as the `unsupported` backend does and as `kill_process_group` already does for espidf.
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 27, 2026
…upported, r=Darksonn std: make send_process_group_signal unsupported on VxWorks `x86_64-wrs-vxworks` doesn't build std: `cargo new` plus `-Zbuild-std` stops with E0425 on `libc::killpg`, which rust-lang#156539 introduced. libc has never declared `killpg` for vxworks, and declaring it wouldn't help. On wrsdk-vxworks7-qemu-1.17.0 there's no `killpg` in the headers, the sysroot archives or the prebuilt kernel, and `getpgrp`/`setpgid` are no-ops in libunix: `getpgrp` returns a constant 0, `setpgid` stores nothing. That rules out `kill(-pgrp, sig)` too. `Command::process_group` is already ignored on this target, since `get_pgroup` is only read by the fork/posix_spawn path while vxworks spawns through `rtpSpawn`. Closesrust-lang#159969.
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 27, 2026
…upported, r=Darksonn std: make send_process_group_signal unsupported on VxWorks `x86_64-wrs-vxworks` doesn't build std: `cargo new` plus `-Zbuild-std` stops with E0425 on `libc::killpg`, which rust-lang#156539 introduced. libc has never declared `killpg` for vxworks, and declaring it wouldn't help. On wrsdk-vxworks7-qemu-1.17.0 there's no `killpg` in the headers, the sysroot archives or the prebuilt kernel, and `getpgrp`/`setpgid` are no-ops in libunix: `getpgrp` returns a constant 0, `setpgid` stores nothing. That rules out `kill(-pgrp, sig)` too. `Command::process_group` is already ignored on this target, since `get_pgroup` is only read by the fork/posix_spawn path while vxworks spawns through `rtpSpawn`. Closesrust-lang#159969.
rust-timer added a commit
that referenced
this pull request
Jul 27, 2026
Rollup merge of #159991 - physwkim:vxworks-process-group-unsupported, r=Darksonn std: make send_process_group_signal unsupported on VxWorks `x86_64-wrs-vxworks` doesn't build std: `cargo new` plus `-Zbuild-std` stops with E0425 on `libc::killpg`, which #156539 introduced. libc has never declared `killpg` for vxworks, and declaring it wouldn't help. On wrsdk-vxworks7-qemu-1.17.0 there's no `killpg` in the headers, the sysroot archives or the prebuilt kernel, and `getpgrp`/`setpgid` are no-ops in libunix: `getpgrp` returns a constant 0, `setpgid` stores nothing. That rules out `kill(-pgrp, sig)` too. `Command::process_group` is already ignored on this target, since `get_pgroup` is only read by the fork/posix_spawn path while vxworks spawns through `rtpSpawn`. Closes#159969.
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 28, 2026
… r=Darksonn std: make send_process_group_signal unsupported on VxWorks `x86_64-wrs-vxworks` doesn't build std: `cargo new` plus `-Zbuild-std` stops with E0425 on `libc::killpg`, which rust-lang/rust#156539 introduced. libc has never declared `killpg` for vxworks, and declaring it wouldn't help. On wrsdk-vxworks7-qemu-1.17.0 there's no `killpg` in the headers, the sysroot archives or the prebuilt kernel, and `getpgrp`/`setpgid` are no-ops in libunix: `getpgrp` returns a constant 0, `setpgid` stores nothing. That rules out `kill(-pgrp, sig)` too. `Command::process_group` is already ignored on this target, since `get_pgroup` is only read by the fork/posix_spawn path while vxworks spawns through `rtpSpawn`. Closesrust-lang/rust#159969.
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#156552 (Clippy subtree update) - rust-lang/rust#156344 (Do not index past end of buffer when checking heuristic in error index syntax highlighter) - rust-lang/rust#156500 (Privacy: move macros handling to early stage) - rust-lang/rust#156260 (test: suppress deprecation warning) - rust-lang/rust#156413 (rustdoc: Correctness & perf improvements to link-to-definition) - rust-lang/rust#156539 (Add `ChildExt::kill_process_group`) - rust-lang/rust#156540 (use `deref_patterns` in `rustdoc` instead of `box_patterns`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#791
Tracking issue: #156537