Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #157114
Closed
JonathanBrouwer wants to merge 36 commits into
Closed
Conversation
… so just encode the fields we need
This makes the proc-macro RPC protocol platform independent as necessary for running proc macros and rustc on different architectures.
This shrinks the proc-macro ABI a bit. Nothing on the client side needs to allocate handles. This will share the counters between proc-macros, which may cause us to run out of handles earlier, but 4 bilion handles per process is still a lot. Rust-analyzer might run out at some point, but it can recover by restarting the proc-macro-server, and it could already run out before this change anyway,
resolve: Partially convert `ambiguous_glob_imports` lint into a hard error I'm tired of this logic interfering with any attempts to fix or refactor glob imports. Change description for lang team: rust-lang#149195 (comment). Part of rust-lang#114095.
Some cleanups around passing extra lifetime params from the resolver to ast lowering No functional changes, mostly removing information that was never used at any step. Possibly interesting to @petrochenkov and @cjgillot I originally thought this was a necessary cleanup to be able to refactor our `extra_lifetime_params_map` handling, but it turns out that I can also just do rust-lang#156508 which removes all the ugly usage of that side table and makes it possible for that side table to be put into `PerOwnerResolverData`. The changes here still were an improvement on its own, thus this PR.
…ochenkov definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex` This PR removes `DefPathTable` and uses `LocalDefId` instead of `DefIndex` where possible. r? @petrochenkov
…, r=petrochenkov Eagerly resolve delegations in late resolution This is necessary for allowing the `partial_res_map` to be split by owners. The current logic follows `NodeId` -> `DefId` -> `NodeId` mappings, but the resulting `NodeId` is then not under the same owner, so we can't look it up in the current owner table. After this PR everything is just a `DefId` -> `DefId` mapping, which always works fine. cc @aerooneqq r? @petrochenkov
…or, r=petrochenkov NVPTX: Remove the unstable ptx linker flavor Remove the ptx linker flavor as specified in [this accepted MCP](rust-lang/compiler-team#990) Fixesrust-lang#156954@rustbot label +O-NVPTX
…r=joboet Stabilize `Path::is_empty` FCP is complete: rust-lang#148494 (comment)
…r=JonathanBrouwer
Improve suggestions for malformed deprecated attribute
When the deprecated attribute is supplied a single string as an argument, suggest using the NameValueStr syntax.
```
error[E0565]: malformed `deprecated` attribute input
--> $DIR/deprecation-sanity.rs:24:5
|
LL | #[deprecated("test")]
| ^^^^^^^^^^^^^------^^
| |
| didn't expect a literal here
|
help: try using `=` instead
|
LL - #[deprecated("test")]
LL + #[deprecated = "test"]
|
```
If the string looked like a version (e.g. `"1.2.3"` or `"TBD"`), suggest using the since field instead.
```
error[E0565]: malformed `deprecated` attribute input
--> $DIR/deprecation-sanity.rs:27:5
|
LL | #[deprecated("1.2.3")]
| ^^^^^^^^^^^^^-------^^
| |
| didn't expect a literal here
|
help: try specifying a deprecated since version
|
LL | #[deprecated(since = "1.2.3")]
| +++++++
```…l_tests_1, r=nnethercote Add reproducibly failing tests for parallel frontend Some tests keep fail with `--parallel-frontend-threads=n`. This PR marks them for tracking and to filter those out for regular tests of the parallel frontend. There are two new similar categories for test failures: `unstable liveness diagnostics` and `pattern matching error message mismatch`. Both of them appear to be just printed diagnostic inconsistencies.
JonathanBrouwer
commented
May 29, 2026
MemberAuthor
Contributor
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
May 29, 2026
Rollup of 11 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
May 29, 2026
…uwer Rollup of 11 pull requests Successful merges: - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error) - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering) - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`) - #157053 (Eagerly resolve delegations in late resolution) - #157068 (NVPTX: Remove the unstable ptx linker flavor) - #157076 (Various proc-macro related code cleanups) - #157106 (add ABI check logic for wasm) - #154835 (std::offload sharedmem) - #157065 (Stabilize `Path::is_empty`) - #157088 (Improve suggestions for malformed deprecated attribute) - #157103 (Add reproducibly failing tests for parallel frontend) Failed merges: - #157100 (Some more per owner things)
Contributor
💔 Test for eb17695 failed: CI. Failed job:
|
rust-log-analyzer
commented
May 29, 2026
Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Contributor
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ambiguous_glob_importslint into a hard error #149195 (resolve: Partially convertambiguous_glob_importslint into a hard error)DefPathTable, useLocalDefIdinstead ofDefIndex#156963 (definitions: removeDefPathTable, useLocalDefIdinstead ofDefIndex)Path::is_empty#157065 (StabilizePath::is_empty)Failed merges:
r? @ghost
Create a similar rollup