Skip to content

Add regression test for issue #144888 - #157131

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
pbkx:issue-144888-ui-test
Jun 2, 2026
Merged

Add regression test for issue #144888#157131
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
pbkx:issue-144888-ui-test

Conversation

@pbkx

@pbkxpbkx commented May 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Issue #144888 is labeled E-needs-test for an ICE involving unhandled node Crate(Mod).

This adds a focused UI regression test for the reduced example. The test is compile-fail, checks the current non-ICE diagnostics, and avoids the unrelated missing-main diagnostic by compiling as a library.

Fixes#144888.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2026
@rustbot

rustbot commented May 30, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pbkx
pbkxforce-pushed the issue-144888-ui-test branch from 27fe31d to 73765b4CompareMay 30, 2026 00:53
@rustbot

This comment has been minimized.

Sign in to view
@pbkx
pbkxforce-pushed the issue-144888-ui-test branch 2 times, most recently from 642b817 to a6df11aCompareMay 30, 2026 16:27
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pbkx
pbkxforce-pushed the issue-144888-ui-test branch from a6df11a to 55cb982CompareMay 30, 2026 17:07
@petrochenkov

petrochenkov commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Could you use the minimized reproduction from the last comment - #144888 (comment)?

avoids the unrelated missing-main diagnostic by compiling as a library

It's simpler to add fn main() {} instead.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2026
@pbkx

pbkx commented Jun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2026
@petrochenkov

petrochenkov commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8845779 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 2, 2026
@jhpratt
Rollup merge ofrust-lang#157131- pbkx:issue-144888-ui-test, r=petro…
2263661
…chenkov
Add regression test for issue rust-lang#144888
Issue rust-lang#144888 is labeled E-needs-test for an ICE involving `unhandled node Crate(Mod)`.
This adds a focused UI regression test for the reduced example. The test is compile-fail, checks the current non-ICE diagnostics, and avoids the unrelated missing-main diagnostic by compiling as a library.
Fixesrust-lang#144888.
@jhprattjhpratt mentioned this pull request Jun 2, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
733b900
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
5cfd336
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
4e95ce7
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
9746b4d
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
06b0db7
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157284- jhpratt:rollup-gMl4bCI, r=jhpratt
bcd39fd
Rollup of 8 pull requests
Successful merges:
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jun 2, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157303- JonathanBrouwer:rollup-EWrtFmY, r=JonathanBro…
cdbc8d6
…uwer
Rollup of 14 pull requests
Successful merges:
- #156467 (mark the 'import linkage' statics as unnamed_addr)
- #156923 (Couple of diagnostics improvements for EII)
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157244 (Privacy: tweak macros + more tests)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157233 (rustdoc: Fix trait impl ordering)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
- #157291 (Clean up attribute target checking diagnostics)
- #157301 (Remove unused import from a test)
rust-borsBot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of#157303- JonathanBrouwer:rollup-EWrtFmY, r=JonathanBro…
48f976c
…uwer
Rollup of 14 pull requests
Successful merges:
- #156467 (mark the 'import linkage' statics as unnamed_addr)
- #156923 (Couple of diagnostics improvements for EII)
- #157240 (Enable Enzyme for aarch64-apple-darwin)
- #157244 (Privacy: tweak macros + more tests)
- #157276 (miri subtree update)
- #157130 (Use a `ArrayVec` in `CastTarget`)
- #157131 (Add regression test for issue #144888)
- #157195 (Move feature gating to the new attr parsing infrastructure)
- #157233 (rustdoc: Fix trait impl ordering)
- #157256 (tests: adapt for LLVM codegen change)
- #157265 (Update books)
- #157277 (triagebot.toml: add LawnGnome to libs reviewers)
- #157291 (Clean up attribute target checking diagnostics)
- #157301 (Remove unused import from a test)
@rust-bors
rust-borsBot merged commit ff4db29 into rust-lang:mainJun 2, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 2, 2026
rust-timer added a commit that referenced this pull request Jun 2, 2026
@rust-timer
Unrolled build for#157131
8a8eb2c
Rollup merge of #157131 - pbkx:issue-144888-ui-test, r=petrochenkov
Add regression test for issue #144888
Issue #144888 is labeled E-needs-test for an ICE involving `unhandled node Crate(Mod)`.
This adds a focused UI regression test for the reduced example. The test is compile-fail, checks the current non-ICE diagnostics, and avoids the unrelated missing-main diagnostic by compiling as a library.
Fixes#144888.
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 4, 2026
@bors
Auto merge of #157303 - JonathanBrouwer:rollup-EWrtFmY, r=JonathanBro…
df1f8ed
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#156467 (mark the 'import linkage' statics as unnamed_addr)
- rust-lang/rust#156923 (Couple of diagnostics improvements for EII)
- rust-lang/rust#157240 (Enable Enzyme for aarch64-apple-darwin)
- rust-lang/rust#157244 (Privacy: tweak macros + more tests)
- rust-lang/rust#157276 (miri subtree update)
- rust-lang/rust#157130 (Use a `ArrayVec` in `CastTarget`)
- rust-lang/rust#157131 (Add regression test for issue rust-lang/rust#144888)
- rust-lang/rust#157195 (Move feature gating to the new attr parsing infrastructure)
- rust-lang/rust#157233 (rustdoc: Fix trait impl ordering)
- rust-lang/rust#157256 (tests: adapt for LLVM codegen change)
- rust-lang/rust#157265 (Update books)
- rust-lang/rust#157277 (triagebot.toml: add LawnGnome to libs reviewers)
- rust-lang/rust#157291 (Clean up attribute target checking diagnostics)
- rust-lang/rust#157301 (Remove unused import from a test)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

ICE: unhandled node Crate(Mod

4 participants

@pbkx@rustbot@rust-log-analyzer@petrochenkov