Skip to content

delegation: split resolution and lowering - #157296

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged

delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-extract-resolve

Conversation

@aerooneqq

@aerooneqqaerooneqq commented Jun 2, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:

Part of #118212.
r? @petrochenkov

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2026
@aerooneqqaerooneqq changed the title delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jun 2, 2026
petrochenkov
petrochenkov reviewed Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_middle/src/hir/map.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026
@aerooneqq

aerooneqq commented Jun 3, 2026

Copy link
Copy Markdown
ContributorAuthor

After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed the delegation-extract-resolve branch from a2ddcb3 to 4c2c364CompareJune 3, 2026 07:59
@aerooneqq

aerooneqq commented Jun 3, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026
@rustbot

rustbot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

petrochenkov
petrochenkov reviewed Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs Outdated
Comment threadcompiler/rustc_interface/src/passes.rs Outdated
Comment threadcompiler/rustc_resolve/src/late.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
@petrochenkovpetrochenkov mentioned this pull request Jun 3, 2026
Merged
@aerooneqq
aerooneqqforce-pushed the delegation-extract-resolve branch from a3b108f to 9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed the delegation-extract-resolve branch from ba00c21 to 9259289CompareJune 4, 2026 06:07
@rustbot

rustbot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@aerooneqq
aerooneqqforce-pushed the delegation-extract-resolve branch from f4ee446 to 421e420CompareJune 4, 2026 06:14
@aerooneqq

aerooneqq commented Jun 4, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2026
petrochenkov
petrochenkov reviewed Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
@petrochenkov

petrochenkov commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author

@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2026
@rustbotrustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed the delegation-extract-resolve branch from dbe7f3e to cf34955CompareJune 4, 2026 12:10
@aerooneqq

aerooneqq commented Jun 4, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2026
@petrochenkov

petrochenkov commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cf34955 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jun 4, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot merged commit 8ae06c8 into rust-lang:mainJun 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 4, 2026
rust-timer added a commit that referenced this pull request Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
delegation: split resolution and lowering by aerooneqq · Pull Request #157296 · rust-lang/rust · GitHub
Skip to content
delegation: split resolution and lowering - #157296
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Jun 4, 2026
Merged
delegation: split resolution and lowering#157296
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
aerooneqq:delegation-extract-resolve
Conversation
@aerooneqq
@aerooneqqaerooneqq
commented
Jun 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
Part of #118212.

r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 2, 2026
@aerooneqqaerooneqq
changed the title
delegation: split delegation resolution and loweringdelegation: split resolution and loweringJun 2, 2026
@petrochenkovpetrochenkov
added
the 
F-fn_delegation
`#![feature(fn_delegation)]`
label
Jun 2, 2026
petrochenkov
petrochenkov
reviewed
Jun 2, 2026
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

Comment threadcompiler/rustc_middle/src/hir/map.rs
Outdated

@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 2, 2026
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
After changing Option<DefId> to Result<...> we started to emit UnresolvedDelegationCallee error during resolve, so new errors are added to tests, they were not added earlier as we had None in delegation_infos and old get_sig_id was not called at all.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a2ddcb3 to
4c2c364CompareJune 3, 2026 07:59
@aerooneqq
aerooneqq
commented
Jun 3, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 3, 2026
@rustbot
rustbot
commented
Jun 3, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
petrochenkov
petrochenkov
reviewed
Jun 3, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/ty/mod.rs
Outdated

Comment threadcompiler/rustc_interface/src/passes.rs
Outdated

Comment threadcompiler/rustc_resolve/src/late.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

Comment threadcompiler/rustc_ast_lowering/src/delegation.rs
Outdated

@petrochenkovpetrochenkov
mentioned this pull request
Jun 3, 2026
 Merged

@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
a3b108f to
9eb8e44CompareJune 3, 2026 13:06
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
ba00c21 to
9259289CompareJune 4, 2026 06:07
@rustbot
rustbot
commented
Jun 4, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
f4ee446 to
421e420CompareJune 4, 2026 06:14
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
petrochenkov
petrochenkov
reviewed
Jun 4, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Outdated

@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
r=me after (maybe) addressing #157296 (comment), and squashing commits.
@rustbot author
@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 4, 2026
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jun 4, 2026
@aerooneqq
aerooneqqforce-pushed
the
delegation-extract-resolve
branch
from
dbe7f3e to
cf34955CompareJune 4, 2026 12:10
@aerooneqq
aerooneqq
commented
Jun 4, 2026

Copy link


Copy Markdown

ContributorAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 4, 2026
@petrochenkov
petrochenkov
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
@bors r+
@rust-bors
rust-borsBot
commented
Jun 4, 2026

Copy link


Copy Markdown

Contributor
📌 Commit cf34955 has been approved by petrochenkov
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 4, 2026
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jun 4, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jun 4, 2026
@bors
Auto merge of#157433- JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
b3f7e32
…uwer
Rollup of 5 pull requests
Successful merges:
- #154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- #157296 (delegation: split resolution and lowering)
- #156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- #157426 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot
merged commit 8ae06c8
into
rust-lang:mainJun 4, 2026

12 checks passed

@rustbotrustbot
added this to the 1.98.0 milestone
Jun 4, 2026
rust-timer added a commit
that referenced
this pull request
Jun 4, 2026
@rust-timer
Unrolled build for#157296
5d52d85
Rollup merge of #157296 - aerooneqq:delegation-extract-resolve, r=petrochenkov
delegation: split resolution and lowering
This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits:
- ~For #156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~
- For #155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering.
Part of #118212.
r? @petrochenkov
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 20, 2026
@bors
Auto merge of #157433 - JonathanBrouwer:rollup-d3I87zR, r=JonathanBro…
f6b910f
…uwer
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang/rust#157296 (delegation: split resolution and lowering)
- rust-lang/rust#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang/rust#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang/rust#157426 (rustc-dev-guide subtree update)
Kobzol pushed a commit
to Kobzol/rust
that referenced
this pull request
Jun 21, 2026
@bors
Auto merge ofrust-lang#157433- JonathanBrouwer:rollup-d3I87zR, r=Jo…
996bf72
…nathanBrouwer
Rollup of 5 pull requests
Successful merges:
- rust-lang#154586 (Record failed tests with `--record`, and rerun them with `--rerun`)
- rust-lang#157296 (delegation: split resolution and lowering)
- rust-lang#156171 (Fix a coroutine UI test which is missing `#[coroutine]`)
- rust-lang#157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
- rust-lang#157426 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@rustbot@petrochenkov