Skip to content

Parse deprecated note links separately in rustc_resolve - #157386

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:rustdoc-deprecated-note-links-separately
Jun 7, 2026
Merged

Parse deprecated note links separately in rustc_resolve#157386
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:rustdoc-deprecated-note-links-separately

Conversation

@TaKO8Ki

@TaKO8KiTaKO8Ki commented Jun 3, 2026

Copy link
Copy Markdown
Member

Fixes#157326

rustc_resolve pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and #[deprecated(note = "...")] text as one Markdown document.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 3, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, camelid, lolbinarycat, notriddle

@notriddle

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit db13562 has been approved by notriddle

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
…nks-separately, r=notriddle
Parse deprecated note links separately in rustc_resolve
Fixesrust-lang#157326
`rustc_resolve` pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and `#[deprecated(note = "...")]` text as one Markdown document.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 6, 2026
…nks-separately, r=notriddle
Parse deprecated note links separately in rustc_resolve
Fixesrust-lang#157326
`rustc_resolve` pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and `#[deprecated(note = "...")]` text as one Markdown document.
rust-borsBot pushed a commit that referenced this pull request Jun 6, 2026
…uwer
Rollup of 17 pull requests
Successful merges:
- #157251 (`rust-analyzer` subtree update)
- #157533 (Subtree sync for rustc_codegen_cranelift)
- #154742 (Add APIs for case folding to the standard library)
- #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- #157016 (add `extern "tail"` calling convention)
- #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- #157386 (Parse deprecated note links separately in rustc_resolve)
- #157483 (fix windows-gnu TLS leak)
- #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- #156136 (Move tests box)
- #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- #157494 (Convert `QueryRegionConstraint` into a struct)
- #157526 (std tests: skip a slow test on Miri)
Failed merges:
- #155527 (Replace printables table with `unicode_data.rs` tables)
rust-borsBot pushed a commit that referenced this pull request Jun 6, 2026
…uwer
Rollup of 17 pull requests
Successful merges:
- #157251 (`rust-analyzer` subtree update)
- #157533 (Subtree sync for rustc_codegen_cranelift)
- #154742 (Add APIs for case folding to the standard library)
- #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- #157016 (add `extern "tail"` calling convention)
- #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- #157386 (Parse deprecated note links separately in rustc_resolve)
- #157483 (fix windows-gnu TLS leak)
- #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- #156136 (Move tests box)
- #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- #157494 (Convert `QueryRegionConstraint` into a struct)
- #157526 (std tests: skip a slow test on Miri)
Failed merges:
- #155527 (Replace printables table with `unicode_data.rs` tables)
rust-borsBot pushed a commit that referenced this pull request Jun 6, 2026
…uwer
Rollup of 17 pull requests
Successful merges:
- #157251 (`rust-analyzer` subtree update)
- #157533 (Subtree sync for rustc_codegen_cranelift)
- #154742 (Add APIs for case folding to the standard library)
- #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- #157016 (add `extern "tail"` calling convention)
- #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- #157386 (Parse deprecated note links separately in rustc_resolve)
- #157483 (fix windows-gnu TLS leak)
- #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- #156136 (Move tests box)
- #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- #157494 (Convert `QueryRegionConstraint` into a struct)
- #157526 (std tests: skip a slow test on Miri)
Failed merges:
- #155527 (Replace printables table with `unicode_data.rs` tables)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2026
…nks-separately, r=notriddle
Parse deprecated note links separately in rustc_resolve
Fixesrust-lang#157326
`rustc_resolve` pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and `#[deprecated(note = "...")]` text as one Markdown document.
@jhprattjhpratt mentioned this pull request Jun 7, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2026
…nks-separately, r=notriddle
Parse deprecated note links separately in rustc_resolve
Fixesrust-lang#157326
`rustc_resolve` pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and `#[deprecated(note = "...")]` text as one Markdown document.
This was referenced Jun 7, 2026
rust-borsBot pushed a commit that referenced this pull request Jun 7, 2026
Rollup of 25 pull requests
Successful merges:
- #157251 (`rust-analyzer` subtree update)
- #157533 (Subtree sync for rustc_codegen_cranelift)
- #154742 (Add APIs for case folding to the standard library)
- #155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- #156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
- #157016 (add `extern "tail"` calling convention)
- #157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- #157386 (Parse deprecated note links separately in rustc_resolve)
- #157483 (fix windows-gnu TLS leak)
- #157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- #157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- #157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- #156136 (Move tests box)
- #156573 (Add unwinder_private_data_size for wasm64 target)
- #156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
- #156840 (Stabilize `PathBuf::into_string`)
- #156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
- #157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- #157380 (clarify compiler_fence (and fence) docs)
- #157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- #157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- #157494 (Convert `QueryRegionConstraint` into a struct)
- #157526 (std tests: skip a slow test on Miri)
- #157531 (ci: bump x86_64-gnu base image to 26.04)
- #157556 (Add `BTree::append()` change to 1.96.0 relnotes)
Failed merges:
- #155527 (Replace printables table with `unicode_data.rs` tables)
@rust-bors
rust-borsBot merged commit b3b3d54 into rust-lang:mainJun 7, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 7, 2026
rust-timer added a commit that referenced this pull request Jun 7, 2026
Rollup merge of #157386 - TaKO8Ki:rustdoc-deprecated-note-links-separately, r=notriddle
Parse deprecated note links separately in rustc_resolve
Fixes#157326
`rustc_resolve` pre-caches intra-doc link resolutions for rustdoc. It previously parsed doc comments and `#[deprecated(note = "...")]` text as one Markdown document.
pullBot pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request Jun 7, 2026
Rollup of 25 pull requests
Successful merges:
- rust-lang/rust#157251 (`rust-analyzer` subtree update)
- rust-lang/rust#157533 (Subtree sync for rustc_codegen_cranelift)
- rust-lang/rust#154742 (Add APIs for case folding to the standard library)
- rust-lang/rust#155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- rust-lang/rust#156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
- rust-lang/rust#157016 (add `extern "tail"` calling convention)
- rust-lang/rust#157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- rust-lang/rust#157386 (Parse deprecated note links separately in rustc_resolve)
- rust-lang/rust#157483 (fix windows-gnu TLS leak)
- rust-lang/rust#157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- rust-lang/rust#157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- rust-lang/rust#157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- rust-lang/rust#156136 (Move tests box)
- rust-lang/rust#156573 (Add unwinder_private_data_size for wasm64 target)
- rust-lang/rust#156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
- rust-lang/rust#156840 (Stabilize `PathBuf::into_string`)
- rust-lang/rust#156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
- rust-lang/rust#157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#157380 (clarify compiler_fence (and fence) docs)
- rust-lang/rust#157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- rust-lang/rust#157494 (Convert `QueryRegionConstraint` into a struct)
- rust-lang/rust#157526 (std tests: skip a slow test on Miri)
- rust-lang/rust#157531 (ci: bump x86_64-gnu base image to 26.04)
- rust-lang/rust#157556 (Add `BTree::append()` change to 1.96.0 relnotes)
Failed merges:
- rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 8, 2026
Rollup of 25 pull requests
Successful merges:
- rust-lang/rust#157251 (`rust-analyzer` subtree update)
- rust-lang/rust#157533 (Subtree sync for rustc_codegen_cranelift)
- rust-lang/rust#154742 (Add APIs for case folding to the standard library)
- rust-lang/rust#155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- rust-lang/rust#156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
- rust-lang/rust#157016 (add `extern "tail"` calling convention)
- rust-lang/rust#157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- rust-lang/rust#157386 (Parse deprecated note links separately in rustc_resolve)
- rust-lang/rust#157483 (fix windows-gnu TLS leak)
- rust-lang/rust#157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- rust-lang/rust#157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- rust-lang/rust#157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- rust-lang/rust#156136 (Move tests box)
- rust-lang/rust#156573 (Add unwinder_private_data_size for wasm64 target)
- rust-lang/rust#156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
- rust-lang/rust#156840 (Stabilize `PathBuf::into_string`)
- rust-lang/rust#156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
- rust-lang/rust#157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#157380 (clarify compiler_fence (and fence) docs)
- rust-lang/rust#157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- rust-lang/rust#157494 (Convert `QueryRegionConstraint` into a struct)
- rust-lang/rust#157526 (std tests: skip a slow test on Miri)
- rust-lang/rust#157531 (ci: bump x86_64-gnu base image to 26.04)
- rust-lang/rust#157556 (Add `BTree::append()` change to 1.96.0 relnotes)
Failed merges:
- rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
Rollup of 25 pull requests
Successful merges:
- rust-lang/rust#157251 (`rust-analyzer` subtree update)
- rust-lang/rust#157533 (Subtree sync for rustc_codegen_cranelift)
- rust-lang/rust#154742 (Add APIs for case folding to the standard library)
- rust-lang/rust#155144 (mir_build: Add an extra intermediate step in MIR building for patterns )
- rust-lang/rust#156222 (Stabilize `Result::map_or_default` and `Option::map_or_default`)
- rust-lang/rust#157016 (add `extern "tail"` calling convention)
- rust-lang/rust#157264 (diagnostics: Fix ICE building a trait ref in method suggestions)
- rust-lang/rust#157386 (Parse deprecated note links separately in rustc_resolve)
- rust-lang/rust#157483 (fix windows-gnu TLS leak)
- rust-lang/rust#157488 (compiletest: inject `#![windows_subsystem = "windows"]` to debuginfo tests on Windows)
- rust-lang/rust#157509 (remove solaris implementation for File::lock, it has the wrong semantics)
- rust-lang/rust#157521 (Rename `SyncView::{as_pin => as_pin_ref}`)
- rust-lang/rust#156136 (Move tests box)
- rust-lang/rust#156573 (Add unwinder_private_data_size for wasm64 target)
- rust-lang/rust#156783 (docs: make `Rc::into_raw` clickable in `Rc::increment_strong_count` doc)
- rust-lang/rust#156840 (Stabilize `PathBuf::into_string`)
- rust-lang/rust#156936 (Remove FIXME about impl PinCoerceUnsized for UnsafePinned<T>)
- rust-lang/rust#157365 (Revert "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#157380 (clarify compiler_fence (and fence) docs)
- rust-lang/rust#157471 (Debug assert that parsed attributes are in the `BUILTIN_ATTRIBUTE_MAP`)
- rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs` (1/N))
- rust-lang/rust#157494 (Convert `QueryRegionConstraint` into a struct)
- rust-lang/rust#157526 (std tests: skip a slow test on Miri)
- rust-lang/rust#157531 (ci: bump x86_64-gnu base image to 26.04)
- rust-lang/rust#157556 (Add `BTree::append()` change to 1.96.0 relnotes)
Failed merges:
- rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: no resolutions for a doc link

3 participants

@TaKO8Ki@rustbot@notriddle