Skip to content

Add @aapoalas to libs review rotation - #157396

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aapoalas:aapoalas-libs-review-rotation
Jun 5, 2026
Merged

Add @aapoalas to libs review rotation#157396
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aapoalas:aapoalas-libs-review-rotation

Conversation

@aapoalas

Copy link
Copy Markdown
Contributor

No description provided.

@rustbotrustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu

@rust-bors

This comment has been minimized.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(You can generally self-approve such changes)

View changes since this review

@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2026
@aapoalas
aapoalasforce-pushed the aapoalas-libs-review-rotation branch from 88360e8 to c34ea95CompareJune 5, 2026 18:10
@rustbotrustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jun 5, 2026
@aapoalas

Copy link
Copy Markdown
ContributorAuthor

@bors r+ rollup

@rust-bors

rust-borsBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c34ea95 has been approved by aapoalas

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 5, 2026
@jhprattjhpratt mentioned this pull request Jun 5, 2026
rust-borsBot pushed a commit that referenced this pull request Jun 5, 2026
Rollup of 12 pull requests
Successful merges:
- #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets)
- #156798 (delegation: do not always generate first argument)
- #157438 (rustdoc: don't link doc(hidden) associated type projections)
- #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`)
- #148183 (rustdoc: Test & document `test_harness` code block attribute)
- #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages)
- #157396 (Add @aapoalas to libs review rotation)
- #157470 (Avoid ICE when emitting TargetMachine config errors)
- #157474 (Forbid optimize(none) with inline(always) or inline.)
- #157475 (Add a smoke test for the optimize attribute.)
- #157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root)
- #157486 (Remove unused attributes from issue-29485.rs.)
Failed merges:
- #157485 (Rename `errors.rs` file to `diagnostics.rs`)
@jhprattjhpratt mentioned this pull request Jun 5, 2026
rust-borsBot pushed a commit that referenced this pull request Jun 5, 2026
Rollup of 12 pull requests
Successful merges:
- #157467 (stdarch subtree update)
- #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets)
- #156798 (delegation: do not always generate first argument)
- #157438 (rustdoc: don't link doc(hidden) associated type projections)
- #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`)
- #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages)
- #157396 (Add @aapoalas to libs review rotation)
- #157470 (Avoid ICE when emitting TargetMachine config errors)
- #157474 (Forbid optimize(none) with inline(always) or inline.)
- #157475 (Add a smoke test for the optimize attribute.)
- #157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root)
- #157486 (Remove unused attributes from issue-29485.rs.)
Failed merges:
- #157485 (Rename `errors.rs` file to `diagnostics.rs`)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2026
@rust-bors
rust-borsBot merged commit 7bdc140 into rust-lang:mainJun 5, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 5, 2026
rust-timer added a commit that referenced this pull request Jun 5, 2026
Rollup merge of #157396 - aapoalas:aapoalas-libs-review-rotation, r=aapoalas
Add @aapoalas to libs review rotation
github-actionsBot pushed a commit to rust-lang/stdarch that referenced this pull request Jun 8, 2026
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#157467 (stdarch subtree update)
- rust-lang/rust#155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets)
- rust-lang/rust#156798 (delegation: do not always generate first argument)
- rust-lang/rust#157438 (rustdoc: don't link doc(hidden) associated type projections)
- rust-lang/rust#157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`)
- rust-lang/rust#157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages)
- rust-lang/rust#157396 (Add @aapoalas to libs review rotation)
- rust-lang/rust#157470 (Avoid ICE when emitting TargetMachine config errors)
- rust-lang/rust#157474 (Forbid optimize(none) with inline(always) or inline.)
- rust-lang/rust#157475 (Add a smoke test for the optimize attribute.)
- rust-lang/rust#157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root)
- rust-lang/rust#157486 (Remove unused attributes from issue-29485.rs.)
Failed merges:
- rust-lang/rust#157485 (Rename `errors.rs` file to `diagnostics.rs`)
@aapoalas
aapoalas deleted the aapoalas-libs-review-rotation branch July 23, 2026 12:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aapoalas@rustbot@jieyouxu@Mark-Simulacrum