Uh oh!
There was an error while loading. Please reload this page.
Require rustc_comptime fns to also be const - #157671
Closed
oli-obk wants to merge 1 commit into
Closed
Conversation
rustbot
commented
Jun 9, 2026
Collaborator
|
| #[rustc_comptime] | ||
| fn conditionally_const<T: [const] Trait>() { | ||
| //~^ ERROR: `[const]` is not allowed here | ||
| const fn conditionally_const<T: [const] Trait>() { |
Member
There was a problem hiding this comment.
We still need this error though.. because comptime isn't conditionally const
ContributorAuthor
There was a problem hiding this comment.
Yea that's not possible, this check happens on ast xD now that you remind me of this, that probably was another reason I did it this way
Member
There was a problem hiding this comment.
Ah, that's a bummer.
Well, it's an unstable feature, so I guess we'll just have to live with this oddity for now.
As a matter of style it'd be good to typically put the attribute directly above the function, to minimize the risk of it being missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
as per #157647 (comment)
I think I only did that because it was easier to produce a diagnostic suggestion for removing
constthan for addingconst😆