Slightly improve diagnostic impl+output for uncovered type parameters by fmease · Pull Request #157677 · rust-lang/rust

fmease · 2026-06-09T18:25:05Z

Split out of PR #135910. No behavioral changes.

See individual commit messages for details.

rustbot · 2026-06-09T18:25:09Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot · 2026-06-09T18:25:12Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

jackh726 · 2026-06-14T00:35:56Z

r=me after rebase

rustbot · 2026-06-14T09:44:03Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Moreover, don't add the error code to the lint warning(!). While helpful, it's quite unconventional.

The diagnostic is generally very noisy. This commit tries to make it slightly less cluttered and more legible by 1. stopping to reuse the lengthy primary message as the primary label. This duplication didn't increase the information content and only turned the diagnostic into a letter and symbol soup. Instead, we now pick a succinct label ("uncovered type parameter") that immediately(!) signals to the users in red what is wrong with the highlighted type parameter. 2. breaking some information-dense notes into multiple lines. Finally, this rephrases the slightly awkward and confusing "type parameter […] must be used as a type parameter for […] type" to "type parameter […] must be used as an argument to […] type".

fmease · 2026-06-14T09:45:10Z

@bors r=jackh726 rollup

rust-bors · 2026-06-14T09:45:12Z

📌 Commit 2fda233 has been approved by jackh726

It is now in the queue for this repository.

…kh726 Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR rust-lang#135910. No behavioral changes. See individual commit messages for details.

Rollup of 2 pull requests Successful merges: - #157677 (Slightly improve diagnostic impl+output for uncovered type parameters) - #157884 (Rename `errors.rs` file to `diagnostics.rs` (9/N))

rust-bors · 2026-06-14T15:21:34Z

⌛ Testing commit 2fda233 with merge 4fa96d0...

Workflow: https://github.com/rust-lang/rust/actions/runs/27503272216

Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR #135910. No behavioral changes. See individual commit messages for details.

…kh726 Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR rust-lang#135910. No behavioral changes. See individual commit messages for details.

JonathanBrouwer · 2026-06-14T15:47:54Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-06-14T15:47:57Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27503272216

The next pull request likely to be tested is #157893.

…uwer Rollup of 3 pull requests Successful merges: - #157677 (Slightly improve diagnostic impl+output for uncovered type parameters) - #157715 (Stop using a fn pointer to normalize_fn_sig inside TypeErrCtxt) - #157884 (Rename `errors.rs` file to `diagnostics.rs` (9/N))

rust-bors · 2026-06-14T16:44:19Z

⌛ Testing commit 2fda233 with merge 735ac6c...

Workflow: https://github.com/rust-lang/rust/actions/runs/27505463383

Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR #135910. No behavioral changes. See individual commit messages for details.

JonathanBrouwer · 2026-06-14T17:01:23Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-06-14T17:01:27Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27505463383

The next pull request likely to be tested is #157894.

…uwer Rollup of 5 pull requests Successful merges: - #157677 (Slightly improve diagnostic impl+output for uncovered type parameters) - #157715 (Stop using a fn pointer to normalize_fn_sig inside TypeErrCtxt) - #157884 (Rename `errors.rs` file to `diagnostics.rs` (9/N)) - #157887 (Rename `diagnostic::on_unmatch_args` to `diagnostic::on_unmatched_args`) - #157888 (Avoid `&raw` call recovery inside nested delimiters)

Rollup merge of #157677 - fmease:orphanck-improv-diag, r=jackh726 Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR #135910. No behavioral changes. See individual commit messages for details.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2026

rustbot assigned jackh726 Jun 9, 2026

This comment was marked as outdated.
Sign in to view

fmease commented Jun 9, 2026
View reviewed changes

Comment threadcompiler/rustc_hir_analysis/src/errors.rs Outdated

fmease force-pushed the orphanck-improv-diag branch from 8e9e9c8 to 4726555Compare June 10, 2026 07:43

This comment has been minimized.
Sign in to view

fmease force-pushed the orphanck-improv-diag branch from 4726555 to 2fda233Compare June 14, 2026 09:44

fmease added 2 commits June 14, 2026 11:44

Deduplicate diagnostic impl of an orphanck error+lint
5c850e6
Moreover, don't add the error code to the lint warning(!). While helpful, it's quite unconventional.

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2026

jhpratt mentioned this pull request Jun 14, 2026
Rollup of 2 pull requests #157890
Closed

JonathanBrouwer mentioned this pull request Jun 14, 2026
Rollup of 3 pull requests #157893
Closed

JonathanBrouwer mentioned this pull request Jun 14, 2026
Rollup of 5 pull requests #157894
Merged

rust-borsBot merged commit e17f934 into rust-lang:mainJun 14, 2026
13 of 14 checks passed

rustbot added this to the 1.98.0 milestone Jun 14, 2026

fmease deleted the orphanck-improv-diag branch June 14, 2026 20:42

Uh oh!

Uh oh!

Conversation

fmease commented Jun 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

jackh726 commented Jun 14, 2026

Uh oh!

rustbot commented Jun 14, 2026

Uh oh!

fmease commented Jun 14, 2026

Uh oh!

rust-borsBot commented Jun 14, 2026

Uh oh!

rust-borsBot commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 14, 2026

Uh oh!

rust-borsBot commented Jun 14, 2026

Uh oh!

rust-borsBot commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 14, 2026

Uh oh!

rust-borsBot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fmease commented Jun 9, 2026•
edited
Loading

rust-borsBot commented Jun 14, 2026•
edited
Loading

rust-borsBot commented Jun 14, 2026•
edited
Loading