Skip to content

Deny todo!() in tidy - #157706

Merged
rust-bors[bot] merged 16 commits into
rust-lang:mainfrom
jdonszelmann:deny-todo
Jul 13, 2026
Merged

Deny todo!() in tidy#157706
rust-bors[bot] merged 16 commits into
rust-lang:mainfrom
jdonszelmann:deny-todo

Conversation

@jdonszelmann

@jdonszelmannjdonszelmann commented Jun 10, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend A-tidy Area: The tidy tool PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 10, 2026
@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

WaffleLapkin
WaffleLapkin reviewed Jun 10, 2026
View reviewed changes
Comment threadlibrary/std/src/sys/net/connection/uefi/mod.rs
Comment threadcompiler/rustc_ast_passes/src/diagnostics.rs
@rust-bors

This comment has been minimized.

Sign in to view
@KivooeoKivooeo added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026
Kivooeo
Kivooeo reviewed Jun 20, 2026
View reviewed changes
Comment threadsrc/tools/tidy/src/style.rs Outdated
@JonathanBrouwerJonathanBrouwer removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Jun 20, 2026
@KivooeoKivooeo added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 28, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

Some changes occurred in coverage tests.

cc @Zalathar

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbotrustbot added A-CI Area: Our Github Actions CI A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 30, 2026
@rustbot

rustbot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann

jdonszelmann commented Jul 13, 2026

Copy link
Copy Markdown
ContributorAuthor

@bors try jobs=x86_64-gnu

@JonathanBrouwer I ran a ripgrep, I think this is the last one. I hope. If the try succeeds, I'll mark as r+ again

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of#157706- jdonszelmann:deny-todo, r=<try>
a478e76
Deny `todo!()` in tidy
try-job: x86_64-gnu
@rust-bors

rust-borsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: a478e76 (a478e76258063ac6fbee62f792674fcce651eeae)
Base parent: 48c2cee (48c2cee70232ecc3a6a8e285b2e15620b39f82a7)

@jdonszelmann

jdonszelmann commented Jul 13, 2026

Copy link
Copy Markdown
ContributorAuthor

@bors r=wafflelapkin

@rust-bors

rust-borsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ea03e5c has been approved by wafflelapkin

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 13, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157706- jdonszelmann:deny-todo, r=wafflela…
b361539
…pkin
Deny `todo!()` in tidy
Implements rust-lang/compiler-team#999
Part of rust-lang#158173
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 13, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of#159231- JonathanBrouwer:rollup-Q8QhSZ0, r=JonathanBro…
89abf2d
…uwer
Rollup of 13 pull requests
Successful merges:
- #159039 (resolve: fix effective visibilities for items in ambiguous glob sets)
- #157706 (Deny `todo!()` in tidy)
- #156712 (Pointer authentication config and user facing options)
- #158535 (Support `#[track_caller]` on EII declarations)
- #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- #159002 (Small refactorings in `need_type_info` module)
- #159202 (Bump rustc-demangle to 0.1.28)
- #159216 (Avoid using probe self_ty for delegation arguments)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #156609 (Consider structurally impossible Sized predicates in MIR)
- #158854 (Add `#[rustc_test_entrypoint_marker]`)
- #158998 (Some minor ast validation and visiting cleanups)
- #159123 (doc: clarify attr parser APIs)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 13, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157706- jdonszelmann:deny-todo, r=wafflela…
198ec66
…pkin
Deny `todo!()` in tidy
Implements rust-lang/compiler-team#999
Part of rust-lang#158173
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 13, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of#159236- JonathanBrouwer:rollup-GB2gMaX, r=JonathanBro…
5fd724e
…uwer
Rollup of 14 pull requests
Successful merges:
- #159039 (resolve: fix effective visibilities for items in ambiguous glob sets)
- #157706 (Deny `todo!()` in tidy)
- #158535 (Support `#[track_caller]` on EII declarations)
- #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- #158846 (Fix unused variable warnings for diverging expressions)
- #159002 (Small refactorings in `need_type_info` module)
- #159202 (Bump rustc-demangle to 0.1.28)
- #159216 (Avoid using probe self_ty for delegation arguments)
- #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too)
- #156609 (Consider structurally impossible Sized predicates in MIR)
- #157993 (Expose more info about ADTs and functions in rustc_public)
- #158854 (Add `#[rustc_test_entrypoint_marker]`)
- #158998 (Some minor ast validation and visiting cleanups)
- #159123 (doc: clarify attr parser APIs)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 13, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157706- jdonszelmann:deny-todo, r=wafflela…
f222cd4
…pkin
Deny `todo!()` in tidy
Implements rust-lang/compiler-team#999
Part of rust-lang#158173
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 13, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of#159240- JonathanBrouwer:rollup-0W8C2Kq, r=JonathanBro…
776dc9e
…uwer
Rollup of 15 pull requests
Successful merges:
- #159039 (resolve: fix effective visibilities for items in ambiguous glob sets)
- #157706 (Deny `todo!()` in tidy)
- #156047 (Fix trait method resolution on an adjusted never type)
- #158535 (Support `#[track_caller]` on EII declarations)
- #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- #158846 (Fix unused variable warnings for diverging expressions)
- #159002 (Small refactorings in `need_type_info` module)
- #159202 (Bump rustc-demangle to 0.1.28)
- #159216 (Avoid using probe self_ty for delegation arguments)
- #156609 (Consider structurally impossible Sized predicates in MIR)
- #157993 (Expose more info about ADTs and functions in rustc_public)
- #158804 (Clarify `as_uninit_mut` may point to uninitialized memory)
- #158854 (Add `#[rustc_test_entrypoint_marker]`)
- #158998 (Some minor ast validation and visiting cleanups)
- #159123 (doc: clarify attr parser APIs)
This was referenced Jul 13, 2026
Merged
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of#159246- JonathanBrouwer:rollup-ZywyNke, r=JonathanBro…
daf2e5e
…uwer
Rollup of 13 pull requests
Successful merges:
- #157706 (Deny `todo!()` in tidy)
- #158535 (Support `#[track_caller]` on EII declarations)
- #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- #158846 (Fix unused variable warnings for diverging expressions)
- #159002 (Small refactorings in `need_type_info` module)
- #159202 (Bump rustc-demangle to 0.1.28)
- #159216 (Avoid using probe self_ty for delegation arguments)
- #156609 (Consider structurally impossible Sized predicates in MIR)
- #157993 (Expose more info about ADTs and functions in rustc_public)
- #158804 (Clarify `as_uninit_mut` may point to uninitialized memory)
- #158854 (Add `#[rustc_test_entrypoint_marker]`)
- #158998 (Some minor ast validation and visiting cleanups)
- #159123 (doc: clarify attr parser APIs)
@rust-bors
rust-borsBot merged commit 490097d into rust-lang:mainJul 13, 2026
14 checks passed
rust-timer added a commit that referenced this pull request Jul 13, 2026
@rust-timer
Unrolled build for#157706
8a2d434
Rollup merge of #157706 - jdonszelmann:deny-todo, r=wafflelapkin
Deny `todo!()` in tidy
Implements rust-lang/compiler-team#999
Part of #158173
@rustbotrustbot added this to the 1.99.0 milestone Jul 13, 2026
github-actionsBot pushed a commit to rust-lang/stdarch that referenced this pull request Jul 16, 2026
@bors
Auto merge of #159246 - JonathanBrouwer:rollup-ZywyNke, r=JonathanBro…
e1e621d
…uwer
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#157706 (Deny `todo!()` in tidy)
- rust-lang/rust#158535 (Support `#[track_caller]` on EII declarations)
- rust-lang/rust#158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- rust-lang/rust#158846 (Fix unused variable warnings for diverging expressions)
- rust-lang/rust#159002 (Small refactorings in `need_type_info` module)
- rust-lang/rust#159202 (Bump rustc-demangle to 0.1.28)
- rust-lang/rust#159216 (Avoid using probe self_ty for delegation arguments)
- rust-lang/rust#156609 (Consider structurally impossible Sized predicates in MIR)
- rust-lang/rust#157993 (Expose more info about ADTs and functions in rustc_public)
- rust-lang/rust#158804 (Clarify `as_uninit_mut` may point to uninitialized memory)
- rust-lang/rust#158854 (Add `#[rustc_test_entrypoint_marker]`)
- rust-lang/rust#158998 (Some minor ast validation and visiting cleanups)
- rust-lang/rust#159123 (doc: clarify attr parser APIs)
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Jul 23, 2026
@bors
Auto merge of #159246 - JonathanBrouwer:rollup-ZywyNke, r=JonathanBro…
c4cfb2a
…uwer
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#157706 (Deny `todo!()` in tidy)
- rust-lang/rust#158535 (Support `#[track_caller]` on EII declarations)
- rust-lang/rust#158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- rust-lang/rust#158846 (Fix unused variable warnings for diverging expressions)
- rust-lang/rust#159002 (Small refactorings in `need_type_info` module)
- rust-lang/rust#159202 (Bump rustc-demangle to 0.1.28)
- rust-lang/rust#159216 (Avoid using probe self_ty for delegation arguments)
- rust-lang/rust#156609 (Consider structurally impossible Sized predicates in MIR)
- rust-lang/rust#157993 (Expose more info about ADTs and functions in rustc_public)
- rust-lang/rust#158804 (Clarify `as_uninit_mut` may point to uninitialized memory)
- rust-lang/rust#158854 (Add `#[rustc_test_entrypoint_marker]`)
- rust-lang/rust#158998 (Some minor ast validation and visiting cleanups)
- rust-lang/rust#159123 (doc: clarify attr parser APIs)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #159246 - JonathanBrouwer:rollup-ZywyNke, r=JonathanBro…
3eaaa0c
…uwer
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#157706 (Deny `todo!()` in tidy)
- rust-lang/rust#158535 (Support `#[track_caller]` on EII declarations)
- rust-lang/rust#158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder))
- rust-lang/rust#158846 (Fix unused variable warnings for diverging expressions)
- rust-lang/rust#159002 (Small refactorings in `need_type_info` module)
- rust-lang/rust#159202 (Bump rustc-demangle to 0.1.28)
- rust-lang/rust#159216 (Avoid using probe self_ty for delegation arguments)
- rust-lang/rust#156609 (Consider structurally impossible Sized predicates in MIR)
- rust-lang/rust#157993 (Expose more info about ADTs and functions in rustc_public)
- rust-lang/rust#158804 (Clarify `as_uninit_mut` may point to uninitialized memory)
- rust-lang/rust#158854 (Add `#[rustc_test_entrypoint_marker]`)
- rust-lang/rust#158998 (Some minor ast validation and visiting cleanups)
- rust-lang/rust#159123 (doc: clarify attr parser APIs)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments
@KivooeoKivooeoKivooeo left review comments
@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

A-CIArea: Our Github Actions CIA-run-makeArea: port run-make Makefiles to rmake.rsA-rustdoc-jsArea: Rustdoc's JS front-endA-rustdoc-jsonArea: Rustdoc JSON backendA-rustdoc-searchArea: Rustdoc's search featureA-test-infra-minicoreArea: `minicore` test auxiliary and `//@ add-core-stubs`A-testsuiteArea: The testsuite used to check the correctness of rustcA-tidyArea: The tidy toolO-windowsOperating system: WindowsPG-exploit-mitigationsProject group: Exploit mitigationsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jdonszelmann@rustbot@rust-log-analyzer@Kivooeo@JonathanBrouwer@lcnr@WaffleLapkin