Uh oh!
There was an error while loading. Please reload this page.
[Experiment]: Test EII for RawOsError in core - #158116
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8679f7c to
cd28ccaCompare
This comment has been minimized.
This comment has been minimized.
Seem entirely unrelated to me
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
They now fail because libcore implements an EII. Crates that implement an EII are never considered unused as removing them would affect which implementation is picked for an EII or even give an error if there ie no default. That check should probably be changed to ignore the default implementation of an EII.
There was a problem hiding this comment.
Ahhh ok. I'll update this bodge commit to note this an be a bit more surgical than just outright deleting the tests. Thanks!
Kobzol
commented
Jun 19, 2026
@bors delegate=try |
✌️ @bushrat011899, you can now perform try builds on this pull request! You can now post |
bushrat011899
commented
Jun 19, 2026
Thank you! @bors try |
This comment has been minimized.
This comment has been minimized.
[Experiment]: Test EII for `RawOsError` in `core`
mejrs
commented
Jun 19, 2026
If you turn this into an actual PR can you also ensure eii+stability attributes work properly? I think the implementation supports this but I'm glancing at the test suite and don't see any tests for it. |
bushrat011899
commented
Jun 19, 2026
Noted! I suspect this won't be an actual PR for a while. Mac OS and Windows not working isn't too bad since I can fallback to an atomic pointer. But the GCC compatibility isn't something I know how to work around. |
bushrat011899
commented
Jun 19, 2026
Linux seems to build fine (as expected). Gonna try Windows now, which will probably fail pretty quickly. @bors try jobs=dist-x86_64-msvc |
This comment has been minimized.
This comment has been minimized.
[Experiment]: Test EII for `RawOsError` in `core` try-job: dist-x86_64-msvc
Kobzol
commented
Jun 19, 2026
Just note that the |
bushrat011899
commented
Jun 19, 2026
Try build cancelled. Cancelled workflows: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bushrat011899
commented
Jun 20, 2026
Try build cancelled. Cancelled workflows: |
This comment has been minimized.
This comment has been minimized.
[Experiment]: Test EII for `RawOsError` in `core` try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
bushrat011899
commented
Jun 20, 2026
Gonna try using @bors try jobs=aarch64-apple,x86_64-mingw-1 |
This comment has been minimized.
This comment has been minimized.
[Experiment]: Test EII for `RawOsError` in `core` try-job: aarch64-apple try-job: x86_64-mingw-1
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
💔 Test for 5b208ea failed: CI. Failed jobs:
|
bushrat011899
commented
Jun 20, 2026
@bors try jobs=aarch64-apple,x86_64-mingw-1 |
@bushrat011899: 🔑 Insufficient privileges: not in try users |
Kobzol
commented
Jun 20, 2026
Sorry, all delegation was reset today due to some bors implementation changes 😅 @bors delegate try |
✌️ @bushrat011899, you can now perform try builds on this pull request! You can now post |
bushrat011899
commented
Jun 20, 2026
All good, thanks for fixing it up! Was worried is hit some limit last night 😅 @bors try jobs=aarch64-apple,x86_64-mingw-1 |
This comment has been minimized.
This comment has been minimized.
[Experiment]: Test EII for `RawOsError` in `core` try-job: aarch64-apple try-job: x86_64-mingw-1
rust-log-analyzer
commented
Jun 20, 2026
The job Click to see the possible cause of the failure (guessed by this bot) |
💔 Test for 9a73571 failed: CI. Failed jobs:
|
☔ The latest upstream changes (presumably #158379) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
bushrat011899
commented
Jun 26, 2026
Closing as this experiment was intended to quickly check the state of EII for use in |
View all comments
Objective
Checking with CI what kind of issues there may be with using EII for #155625. I'm expecting this to fail on Mac OS and Windows.
Notable Issues
cfgit out.corewill always be marked as used even if it isn't actually in use because of the EII symbols.no_stdfrom working ontarget_vendor = "apple".no_std, implying strong symbols work correctly. This affectsall(windows, target_env = "gnu")