Uh oh!
There was an error while loading. Please reload this page.
Always escape grapheme extenders in str::escape_debug - #158303
Always escape grapheme extenders in str::escape_debug#158303Jules-Bertholet wants to merge 1 commit into
str::escape_debug#158303Conversation
rustbot
commented
Jun 23, 2026
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
str::escape_debugstr::escape_debugMark-Simulacrum
commented
Jun 28, 2026
I'll go ahead and kick off an FCP here, and cc @Manishearth (but I imagine your opinion here will match that given on the other PRs). @rfcbot fcp merge libs-api |
@Mark-Simulacrum has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Yes this is fine. But I don't want to keep reviewing minor changes like this: if @Jules-Bertholet wants to keep making changes like this I would prefer seeing a proposal with a holistic strategy. |
This comment has been minimized.
This comment has been minimized.
rust-rfcbot
commented
Aug 18, 2026
🔔 This is now entering its final comment period, as per the review above. 🔔 |
This matches the behavior of `impl Debug for str`.
fd70c0f to
66594ecComparerustbot
commented
Aug 18, 2026
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rust-rfcbot
commented
Aug 28, 2026
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
This matches the behavior of
impl Debug for str.@rustbot label A-Unicode T-libs-api needs-fcp