Skip to content

Allow BackwardIncompatibleDropHint in polonius legacy - #158384

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged

Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
KiChjang:allow-backward-incompat-drop-hint

Conversation

@KiChjang

@KiChjangKiChjang commented Jun 25, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Fixes#157568.

Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2026
@rustbot

rustbot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@KiChjang

KiChjang commented Jun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

r? @lqd

@rustbotrustbot assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang

KiChjang commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

This is actually a small enough PR that anyone can just review, so r? @folkertdev

@rustbotrustbot assigned folkertdev and unassigned lqdJul 8, 2026
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

Isn't this hint only used when migrating to edition2024? Why do you want to do this?

Especially since we're planning on removing the legacy implementation in due time.

@KiChjang

KiChjang commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.

lqd
lqd reviewed Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev

folkertdev commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

r? lqd

@rustbotrustbot assigned lqd and unassigned folkertdevJul 8, 2026
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

r? me

It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).

Thanks!

@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 6573670.

@rust-bors
rust-borsBotforce-pushed the allow-backward-incompat-drop-hint branch from 77a6ade to 6573670CompareJuly 8, 2026 19:12
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6573670 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 8, 2026
Closed
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

Darn, why did CI pass before. This will make the rollup fail :(

@bors r-

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 8, 2026
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 8, 2026
@rust-bors

rust-borsBot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#158973), which was unapproved.

View changes since this unapproval

@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed the allow-backward-incompat-drop-hint branch from 6573670 to 23cf412CompareJuly 9, 2026 16:37
@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@KiChjang

KiChjang commented Jul 9, 2026

Copy link
Copy Markdown
ContributorAuthor

@lqd because main changed and added a crash test for the issue. We weren't fast enough :(

@lqd

lqd commented Jul 9, 2026

Copy link
Copy Markdown
Member

Incredible :)

Thanks for fixing it. Again.

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 23cf412 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 9, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
This was referenced Jul 9, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot merged commit e57a124 into rust-lang:mainJul 10, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 10, 2026
rust-timer added a commit that referenced this pull request Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang deleted the allow-backward-incompat-drop-hint branch July 10, 2026 06:37
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust · GitHub
Skip to content
Allow BackwardIncompatibleDropHint in polonius legacy - #158384
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Jul 10, 2026
Merged
Allow BackwardIncompatibleDropHint in polonius legacy#158384
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
KiChjang:allow-backward-incompat-drop-hint
Conversation
@KiChjang
@KiChjangKiChjang
commented
Jun 25, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
View all comments
Fixes#157568.
Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 25, 2026
@rustbot
rustbot
commented
Jun 25, 2026

Copy link


Copy Markdown

Collaborator
r? @folkertdev
rustbot has assigned @folkertdev.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates
@KiChjang
KiChjang
commented
Jun 25, 2026

Copy link


Copy Markdown

ContributorAuthor
r? @lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJun 25, 2026
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
This is actually a small enough PR that anyone can just review, so r? @folkertdev
@rustbotrustbot
assigned folkertdev and unassigned lqdJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Isn't this hint only used when migrating to edition2024? Why do you want to do this?
Especially since we're planning on removing the legacy implementation in due time.
@KiChjang
KiChjang
commented
Jul 8, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.
lqd
lqd
reviewed
Jul 8, 2026
View reviewed changes
Comment threadtests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev
folkertdev
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
r? lqd
@rustbotrustbot
assigned lqd and unassigned folkertdevJul 8, 2026
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
r? me
It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).
Thanks!
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors squash
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🔨 2 commits were squashed into 6573670.
@rust-bors
rust-borsBotforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
77a6ade to
6573670CompareJuly 8, 2026 19:12
@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 6573670 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
1d1647e
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 8, 2026
 Closed

@lqd
lqd
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Darn, why did CI pass before. This will make the rollup fail :(
@bors r-
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Jul 8, 2026
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 8, 2026
@rust-bors
rust-borsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#158973), which was unapproved.
View changes since this unapproval
@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang
KiChjangforce-pushed
the
allow-backward-incompat-drop-hint
branch
from
6573670 to
23cf412CompareJuly 9, 2026 16:37
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
@rustbot
rustbot
commented
Jul 9, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@KiChjang
KiChjang
commented
Jul 9, 2026

Copy link


Copy Markdown

ContributorAuthor
@lqd because main changed and added a crash test for the issue. We weren't fast enough :(
@lqd
lqd
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
Incredible :)
Thanks for fixing it. Again.
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Jul 9, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 23cf412 has been approved by lqd
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 9, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 9, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
cfa2774
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Jul 9, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
@bors
Auto merge of#159037- JonathanBrouwer:rollup-QBjj3wg, r=JonathanBro…
8e54754
…uwer
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158510 (Enable `static_position_independent_executables` on all gnu and musl targets)
- #158541 (Move `std::io::Write` to `core::io`)
- #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
@jhpratt
Rollup merge ofrust-lang#158384- KiChjang:allow-backward-incompat-d…
f8c1b63
…rop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixesrust-lang#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

This was referenced Jul 9, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Jul 10, 2026
@bors
Auto merge of#159046- jhpratt:rollup-mqQhHMX, r=jhpratt
3ead112
Rollup of 24 pull requests
Successful merges:
- #150946 (intrinsics: Add a fallback for non-const libm float functions)
- #158541 (Move `std::io::Write` to `core::io`)
- #156027 (Consider captured regions for opaque type region liveness.)
- #156370 (Reject linked dylib EII default overrides)
- #156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- #157561 (rustdoc: do not include extra stuff in span)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158645 (Fix splat ICEs and ban it in closures)
- #158859 (Improve `-Zls` diagnostic message on `.rs` files)
- #158988 (Redo `TokenStreamIter`)
- #158347 (Improve generic parameters handling for #[diagnostic::on_const])
- #158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- #158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- #158739 (view-types: HIR lowering)
- #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- #158883 (tests: fix enum-match.rs to handle LLVM 23)
- #158886 (Add documentation for the `no_std` attribute)
- #158940 (Implement feature `char_to_u32`)
- #158951 (Merge three `MaxUniverse`s into one)
- #158960 (Fix bootstrap submodule path prefix matching)
- #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- #158995 (Use REST API in linkchecker script)
- #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- #159036 (bootstrap: expand '@argfile' arguments to rustc shim)
@rust-bors
rust-borsBot
merged commit e57a124
into
rust-lang:mainJul 10, 2026

13 checks passed

@rustbotrustbot
added this to the 1.99.0 milestone
Jul 10, 2026
rust-timer added a commit
that referenced
this pull request
Jul 10, 2026
@rust-timer
Unrolled build for#158384
d8980f3
Rollup merge of #158384 - KiChjang:allow-backward-incompat-drop-hint, r=lqd
Allow BackwardIncompatibleDropHint in polonius legacy
Fixes#157568.
Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@KiChjang
KiChjang
deleted the

allow-backward-incompat-drop-hint

branch
July 10, 2026 06:37
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #159046 - jhpratt:rollup-mqQhHMX, r=jhpratt
0ce9727
Rollup of 24 pull requests
Successful merges:
- rust-lang/rust#150946 (intrinsics: Add a fallback for non-const libm float functions)
- rust-lang/rust#158541 (Move `std::io::Write` to `core::io`)
- rust-lang/rust#156027 (Consider captured regions for opaque type region liveness.)
- rust-lang/rust#156370 (Reject linked dylib EII default overrides)
- rust-lang/rust#156508 (Infer all anonymous lifetimes in assoc consts as `'static`)
- rust-lang/rust#157561 (rustdoc: do not include extra stuff in span)
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
- rust-lang/rust#158645 (Fix splat ICEs and ban it in closures)
- rust-lang/rust#158859 (Improve `-Zls` diagnostic message on `.rs` files)
- rust-lang/rust#158988 (Redo `TokenStreamIter`)
- rust-lang/rust#158347 (Improve generic parameters handling for #[diagnostic::on_const])
- rust-lang/rust#158384 (Allow BackwardIncompatibleDropHint in polonius legacy)
- rust-lang/rust#158722 (delegation: do not always inherit `ConstArgHasType` predicates)
- rust-lang/rust#158739 (view-types: HIR lowering)
- rust-lang/rust#158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent)
- rust-lang/rust#158883 (tests: fix enum-match.rs to handle LLVM 23)
- rust-lang/rust#158886 (Add documentation for the `no_std` attribute)
- rust-lang/rust#158940 (Implement feature `char_to_u32`)
- rust-lang/rust#158951 (Merge three `MaxUniverse`s into one)
- rust-lang/rust#158960 (Fix bootstrap submodule path prefix matching)
- rust-lang/rust#158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")
- rust-lang/rust#158995 (Use REST API in linkchecker script)
- rust-lang/rust#158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)
- rust-lang/rust#159036 (bootstrap: expand '@argfile' arguments to rustc shim)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang@rustbot@lqd@folkertdev@rust-log-analyzer