Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #158498
Closed
JonathanBrouwer wants to merge 21 commits into
Closed
Conversation
Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
…oded lib.rmeta-link archive members, and routes add_archive read through it so each rlib link metadata is decoded at most once per link. This is a demand from a previous discussion and we split it out as its own PR. It gives that PR a decode once path tp read instead of reparsing each rlib per crate once native_lib_filenames moves to a link time read.
Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
…=petrochenkov Adds RmetaLinkCache a per-link cache that uses path as the key of dec… Adds `RmetaLinkCache` a per link and path keyed cache of decoded `lib.rmeta-link` archive members and routes the add_archive read through it so that each rlib link metadata is decoded only one per link at most. This is a request that originated from the discussion in rust-lang#156735 and we split it out as its own PR. It gives that PR a decode once path to read instead of reparsing each `rlib` per crate, and this will be in effect once `native_lib_filenames` moves to a link-time read. Part of rust-lang#138243
…, r=notriddle,GuillaumeGomez Add new `unused_footnote_definition` rustdoc lint Follow-up of rust-lang#137803 (where the two first commits come from). It adds a new lint which checks for unused footnote definitions. r? @notriddle
…y-count, r=petrochenkov Fix too-short variance slice in `variances_of` cycle recovery This changes the cycle-error fallback in `variances_of` to size the slice the same way the provider does in [`variance/solve.rs:117`](https://github.com/rust-lang/rust/blob/32ea3615cc027bcb8fd720c7511ffb484f6223a3/compiler/rustc_hir_analysis/src/variance/solve.rs#L117). This can otherwise ICE under the parallel frontend in `relate_args_with_variances` for items that inherit their generics from a parent (like a tuple struct constructor). See rust-lang#154560 (comment)
…rget, r=JonathanBrouwer Allow the unstable attribute on foreign type While working the `FnPtr` trait in rust-lang#156176@carbotaniuman was trying to implement `Code` as an extern type but got an error as the current stability infrastructure does not allow `unstable` attribute on foreign type. rust-lang#158200 This PR fixes that by allowing the `unstable` attribute on ForeignTy and adds test to verify. @rustbot r? @JonathanBrouwer
…itions, r=GuillaumeGomez Upgrade `jsonsocck` and `jsondoclint` to edition 2024. No code changes were necessary to perform the upgrade. I used `cargo fix --edition`, and additionally had an AI tool review the source code against the [Rust 2024 edition guide](https://github.com/rust-lang/edition-guide/tree/master/src/rust-2024) and the [edition upgrade guide](https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html) to ensure the change works properly. r? @GuillaumeGomez **AI disclosure:** This PR is the product of a combination of manual work and AI tools. I secured approval in advance from the designated reviewer. I stand behind the quality of the code I'm submitting, and I vouch it's as good or better compared to if I had written every line by my own hand.
…-types-edition, r=GuillaumeGomez Upgrade `rustdoc-json-types` to 2024 edition. No code changes were necessary to perform the upgrade. I used `cargo fix --edition`, and additionally had an AI tool review the source code against the [Rust 2024 edition guide](https://github.com/rust-lang/edition-guide/tree/master/src/rust-2024) and the [edition upgrade guide](https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html) to ensure the change works properly. Same approach as in rust-lang#158470. I don't believe this will raise the MSRV of `rustdoc-types`, because [its MSRV is already 1.85](https://crates.io/crates/rustdoc-types) which [supports the 2024 edition](https://blog.rust-lang.org/2025/02/20/Rust-1.85.0/). r? @GuillaumeGomez **AI disclosure:** This PR is the product of a combination of manual work and AI tools. I secured approval in advance from the designated reviewer. I stand behind the quality of the code I'm submitting, and I vouch it's as good or better compared to if I had written every line by my own hand.
JonathanBrouwer
commented
Jun 27, 2026
MemberAuthor
@bors r+ rollup=never p=5 |
Contributor
Contributor
💔 Test for a254fa8 failed: CI. Failed job:
|
JonathanBrouwer
commented
Jun 27, 2026
MemberAuthor
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 27, 2026
Rollup of 6 pull requests try-job: x86_64-gnu-llvm-22-3
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 27, 2026
…uwer Rollup of 6 pull requests Successful merges: - #158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #158163 (Fix too-short variance slice in `variances_of` cycle recovery) - #158233 (Allow the unstable attribute on foreign type) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)
rust-log-analyzer
commented
Jun 27, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
💔 Test for e941358 failed: CI. Failed job:
|
JonathanBrouwer
commented
Jun 27, 2026
MemberAuthor
@bors retry |
Contributor
❗ You can only retry pull requests that are approved and have a previously failed auto build. Hint: There is currently a pending auto build on this PR. To cancel it, run |
rust-log-analyzer
commented
Jun 27, 2026
Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain) Click to see the possible cause of the failure (guessed by this bot) |
rust-log-analyzer
commented
Jun 27, 2026
Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
💔 Test for 7165505 failed: CI. Failed job:
|
Contributor
PR #137858, which is a member of this rollup, was unapproved. |
rust-log-analyzer
commented
Jun 27, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-log-analyzer
commented
Jun 27, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Successful merges:
unused_footnote_definitionrustdoc lint #137858 (Add newunused_footnote_definitionrustdoc lint)variances_ofcycle recovery #158163 (Fix too-short variance slice invariances_ofcycle recovery)jsonsocckandjsondoclintto edition 2024. #158470 (Upgradejsonsocckandjsondoclintto edition 2024.)rustdoc-json-typesto 2024 edition. #158488 (Upgraderustdoc-json-typesto 2024 edition.)r? @ghost
Create a similar rollup