Skip to content

Fix spacing issue for unused parentheses lint - #158591

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-158583-unused-parens-space
Jun 30, 2026
Merged

Fix spacing issue for unused parentheses lint#158591
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-158583-unused-parens-space

Conversation

@chenyukang

@chenyukangchenyukang commented Jun 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

There is a typo.

Fixes#158583

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 16 candidates

nnethercote
nnethercote approved these changes Jun 30, 2026
View reviewed changes

@nnethercotennethercote left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

For next time: when fixing an issue like this it's nice to add the new test in the first commit and then fix the problem in the second commit. That way the reviewer can see how the output changes.

View changes since this review

@nnethercote

nnethercote commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cd0a3c4 has been approved by nnethercote

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jun 30, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of#158595- JonathanBrouwer:rollup-vgnGLp0, r=JonathanBro…
fddf7e0
…uwer
Rollup of 7 pull requests
Successful merges:
- #158073 (bootstrap: fix panic when repo path contains spaces by switching to CARGO_ENCODED_RUSTFLAGS)
- #158256 (Avoid parser panics bubbling out to proc macros)
- #158561 (Avoid building rustdoc for tests without doctests)
- #158562 (Improve tracing of steps in bootstrap)
- #157445 (Allow section override when using patchable-function-entries)
- #158327 (Move attribute and keyword docs from `std` to `core`)
- #158591 (Fix spacing issue for unused parentheses lint)
rust-borsBot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of#158595- JonathanBrouwer:rollup-vgnGLp0, r=JonathanBro…
3873d4d
…uwer
Rollup of 7 pull requests
Successful merges:
- #158073 (bootstrap: fix panic when repo path contains spaces by switching to CARGO_ENCODED_RUSTFLAGS)
- #158256 (Avoid parser panics bubbling out to proc macros)
- #158561 (Avoid building rustdoc for tests without doctests)
- #158562 (Improve tracing of steps in bootstrap)
- #157445 (Allow section override when using patchable-function-entries)
- #158327 (Move attribute and keyword docs from `std` to `core`)
- #158591 (Fix spacing issue for unused parentheses lint)
rust-borsBot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of#158595- JonathanBrouwer:rollup-vgnGLp0, r=JonathanBro…
0dd2d73
…uwer
Rollup of 7 pull requests
Successful merges:
- #158073 (bootstrap: fix panic when repo path contains spaces by switching to CARGO_ENCODED_RUSTFLAGS)
- #158256 (Avoid parser panics bubbling out to proc macros)
- #158561 (Avoid building rustdoc for tests without doctests)
- #158562 (Improve tracing of steps in bootstrap)
- #157445 (Allow section override when using patchable-function-entries)
- #158327 (Move attribute and keyword docs from `std` to `core`)
- #158591 (Fix spacing issue for unused parentheses lint)
rust-borsBot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of#158595- JonathanBrouwer:rollup-vgnGLp0, r=JonathanBro…
5165714
…uwer
Rollup of 7 pull requests
Successful merges:
- #158073 (bootstrap: fix panic when repo path contains spaces by switching to CARGO_ENCODED_RUSTFLAGS)
- #158256 (Avoid parser panics bubbling out to proc macros)
- #158561 (Avoid building rustdoc for tests without doctests)
- #158562 (Improve tracing of steps in bootstrap)
- #157445 (Allow section override when using patchable-function-entries)
- #158327 (Move attribute and keyword docs from `std` to `core`)
- #158591 (Fix spacing issue for unused parentheses lint)
@rust-bors
rust-borsBot merged commit cdfa297 into rust-lang:mainJun 30, 2026
13 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 30, 2026
rust-timer added a commit that referenced this pull request Jun 30, 2026
@rust-timer
Unrolled build for#158591
7daaabd
Rollup merge of #158591 - chenyukang:yukang-fix-158583-unused-parens-space, r=nnethercote
Fix spacing issue for unused parentheses lint
There is a typo.
Fixes#158583
bjorn3 pushed a commit to bjorn3/miri that referenced this pull request Jul 1, 2026
@bors
Auto merge of #158595 - JonathanBrouwer:rollup-vgnGLp0, r=JonathanBro…
d47289c
…uwer
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#158073 (bootstrap: fix panic when repo path contains spaces by switching to CARGO_ENCODED_RUSTFLAGS)
- rust-lang/rust#158256 (Avoid parser panics bubbling out to proc macros)
- rust-lang/rust#158561 (Avoid building rustdoc for tests without doctests)
- rust-lang/rust#158562 (Improve tracing of steps in bootstrap)
- rust-lang/rust#157445 (Allow section override when using patchable-function-entries)
- rust-lang/rust#158327 (Move attribute and keyword docs from `std` to `core`)
- rust-lang/rust#158591 (Fix spacing issue for unused parentheses lint)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercotennethercotennethercote approved these changes

Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

unused_parens help text as of 1.92 suggests replacing paren with space, looks weird

3 participants

@chenyukang@rustbot@nnethercote