Skip to content

Tweaks to MIR building scope API - #158706

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
cjgillot:drop-api
Jul 5, 2026
Merged

Tweaks to MIR building scope API#158706
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
cjgillot:drop-api

Conversation

@cjgillot

Copy link
Copy Markdown
Contributor

Some simplifications that come from staring too long at that code

All call sites use a static `DropKind` value, and we already have a
dedicated named method for lints. Switch to only use dedicated methods for
consistency.
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in match lowering

cc @Nadrieril

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir
  • compiler, mir expanded to 75 candidates
  • Random selection from 20 candidates

@Nadrieril

Copy link
Copy Markdown
Member

Looks good

r? me

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 28ed28a has been approved by Nadrieril

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-borsrust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 3, 2026
@rust-borsrust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 3, 2026
Tweaks to MIR building scope API
Some simplifications that come from staring too long at that code
@jhprattjhpratt mentioned this pull request Jul 3, 2026
rust-borsBot pushed a commit that referenced this pull request Jul 5, 2026
Rollup of 18 pull requests
Successful merges:
- #158692 (Add release notes for 1.96.1)
- #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
- #152860 (Port the `without_debuginfo` test from `backtrace-rs` to the testsuite)
- #155932 (MIR Call terminator: evaluate destination place before arguments)
- #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
- #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
- #157835 (expand free alias types in the auto-trait orphan check)
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158434 (delegation: refactor AST -> HIR lowering)
- #158552 (make some tidy errors around python easier to understand)
- #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
- #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
- #158711 (library: Comment on libtest's dicey internal soundness)
- #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
- #158659 (refactor the normalization in `coerce_shared_info`)
- #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
- #158698 (Update TypeVisitable implementation)
- #158706 (Tweaks to MIR building scope API)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
Tweaks to MIR building scope API
Some simplifications that come from staring too long at that code
rust-borsBot pushed a commit that referenced this pull request Jul 5, 2026
…uwer
Rollup of 20 pull requests
Successful merges:
- #158692 (Add release notes for 1.96.1)
- #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
- #155932 (MIR Call terminator: evaluate destination place before arguments)
- #155989 (Update `transmute_copy` to ub_checks and `?Sized`)
- #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
- #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
- #157835 (expand free alias types in the auto-trait orphan check)
- #157857 (Stabilize `#[my_macro] mod foo;` (part of `proc_macro_hygiene`))
- #158377 (add `-Zforce-intrinsic-fallback` flag)
- #158434 (delegation: refactor AST -> HIR lowering)
- #158552 (make some tidy errors around python easier to understand)
- #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
- #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
- #158711 (library: Comment on libtest's dicey internal soundness)
- #158751 (rustdoc: Fix crash when trying to inline foreign item which cannot have attributes)
- #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
- #158659 (refactor the normalization in `coerce_shared_info`)
- #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
- #158698 (Update TypeVisitable implementation)
- #158706 (Tweaks to MIR building scope API)
rust-borsBot pushed a commit that referenced this pull request Jul 5, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- #158692 (Add release notes for 1.96.1)
- #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
- #155932 (MIR Call terminator: evaluate destination place before arguments)
- #155989 (Update `transmute_copy` to ub_checks and `?Sized`)
- #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
- #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
- #157835 (expand free alias types in the auto-trait orphan check)
- #157857 (Stabilize `#[my_macro] mod foo;` (part of `proc_macro_hygiene`))
- #158434 (delegation: refactor AST -> HIR lowering)
- #158552 (make some tidy errors around python easier to understand)
- #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
- #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
- #158711 (library: Comment on libtest's dicey internal soundness)
- #158751 (rustdoc: Fix crash when trying to inline foreign item which cannot have attributes)
- #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
- #158659 (refactor the normalization in `coerce_shared_info`)
- #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
- #158698 (Update TypeVisitable implementation)
- #158706 (Tweaks to MIR building scope API)
@rust-bors
rust-borsBot merged commit 9f3f117 into rust-lang:mainJul 5, 2026
13 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jul 5, 2026
rust-timer added a commit that referenced this pull request Jul 5, 2026
Rollup merge of #158706 - cjgillot:drop-api, r=Nadrieril
Tweaks to MIR building scope API
Some simplifications that come from staring too long at that code
@cjgillot
cjgillot deleted the drop-api branch July 6, 2026 00:53
@theemathastheemathas modified the milestones: 1.98.0, 1.99.0Jul 6, 2026
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jul 6, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- rust-lang/rust#158692 (Add release notes for 1.96.1)
- rust-lang/rust#134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
- rust-lang/rust#155932 (MIR Call terminator: evaluate destination place before arguments)
- rust-lang/rust#155989 (Update `transmute_copy` to ub_checks and `?Sized`)
- rust-lang/rust#156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
- rust-lang/rust#157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
- rust-lang/rust#157835 (expand free alias types in the auto-trait orphan check)
- rust-lang/rust#157857 (Stabilize `#[my_macro] mod foo;` (part of `proc_macro_hygiene`))
- rust-lang/rust#158434 (delegation: refactor AST -> HIR lowering)
- rust-lang/rust#158552 (make some tidy errors around python easier to understand)
- rust-lang/rust#158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
- rust-lang/rust#158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
- rust-lang/rust#158711 (library: Comment on libtest's dicey internal soundness)
- rust-lang/rust#158751 (rustdoc: Fix crash when trying to inline foreign item which cannot have attributes)
- rust-lang/rust#158539 (Move `SizeHint` and `IoHandle` to `core::io`)
- rust-lang/rust#158659 (refactor the normalization in `coerce_shared_info`)
- rust-lang/rust#158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
- rust-lang/rust#158698 (Update TypeVisitable implementation)
- rust-lang/rust#158706 (Tweaks to MIR building scope API)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cjgillot@rustbot@Nadrieril@theemathas@jackh726